<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
+1 for moving both <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px;line-height: 19.5px">Morphic-pre.1491 and Morphic-cmfcmf.1490 to trunk.</span><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px;line-height: 19.5px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px;line-height: 19.5px">Best,</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px;line-height: 19.5px">Marcel</span></div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 03.07.2019 02:46:45 schrieb David T. Lewis <lewis@mail.msen.com>:</p><div style="font-family:Arial,Helvetica,sans-serif">tl;dr Is there any reason NOT to move/merge Morphic-pre.1491 and<br>Morphic-cmfcmf.1490 from inbox to trunk?<br><br>Descending from Morphic-pre.1489, we have Morphic-pre.1490 that was moved<br>from inbox to treated, and we also have Morphic-cmfcmf.1490 still in inbox.<br>Parallel to that, we also have inbox Morphic-pre.1491, with inbox Morphic-ct.1492<br>descended from it, and Morphic-ct.1492 depending on inbox Tools-ct.851 (and<br>presumably also Compiler-ct.407 and Tests-ct.412.<br><br>I have not tested these, but based on the well-documented commit notices<br>for Morphic-pre.1491 and Morphic-cmfcmf.1490, both should be moved/merged<br>to trunk. <br><br>The other inbox packages from Christoph Thiede appear to still be under<br>discussion on the list.<br><br>In the interest of reducing bit rot in the inbox, can anyone think of a<br>good reason that Morphic-pre.1491 and Morphic-cmfcmf.1490 should not go<br>into trunk now?<br><br>Thanks,<br>Dave<br><br><br>On Sun, Jun 30, 2019 at 10:08:05AM +0000, commits@source.squeak.org wrote:<br>> A new version of Morphic was added to project The Inbox:<br>> http://source.squeak.org/inbox/Morphic-cmfcmf.1490.mcz<br>> <br>> ==================== Summary ====================<br>> <br>> Name: Morphic-cmfcmf.1490<br>> Author: cmfcmf<br>> Time: 30 June 2019, 12:04:13.370226 pm<br>> UUID: ab2320d7-f8f4-df46-a786-ec28230e912c<br>> Ancestors: Morphic-pre.1489<br>> <br>> When wrapping a Morph into a flex shell, first add the flex shell to the Morph's owner (and thus to the Morph's world) before making the Morph a submorph of the flex shell.<br>> This avoids unnecessarily sending outOfWorld: to the Morph when adding it to the new flex shell (which doesn't have a world after creation) and intoWorld: when adding the flex shell to the Morph's owner right thereafter.<br>> <br>> =============== Diff against Morphic-pre.1489 ===============<br>> <br>> Item was changed:<br>> ----- Method: Morph>>addFlexShell (in category 'rotate scale and flex') -----<br>> addFlexShell<br>> "Wrap a rotating and scaling shell around this morph."<br>> <br>> | oldHalo myWorld flexMorph anIndex |<br>> - <br>> oldHalo:= self halo.<br>> myWorld := self world.<br>> self owner<br>> ifNil: [flexMorph := self newTransformationMorph asFlexOf: self]<br>> ifNotNil: [:myOwner |<br>> anIndex := myOwner submorphIndexOf: self.<br>> + "Avoid triggering outOfWorld: on self by first adding flexMorph to myOwner and only then making myself a submorph of flexMorph via asFlexOf:"<br>> + flexMorph := self newTransformationMorph.<br>> - flexMorph := self newTransformationMorph asFlexOf: self.<br>> myOwner addMorph: flexMorph asElementNumber: anIndex.<br>> + flexMorph asFlexOf: self.<br>> myWorld ifNotNil: [myWorld startSteppingSubmorphsOf: flexMorph]].<br>> self transferStateToRenderer: flexMorph.<br>> oldHalo ifNotNil: [oldHalo setTarget: flexMorph].<br>> <br>> ^ flexMorph!<br>> <br>> <br><br></div></blockquote>
</div></body>