<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>For reference, the GNU Smalltalk specification does not allow this kind of expression ([:x]). Personally, I would find the syntax clear & unique, but when developing a solution for multiple Smalltalk dialects, this might be a disadvantage.</p>
<p><br>
</p>
<p>Maybe introduce a preference similar to #<span>allowUnderscoreAsAssignment? Or would this make the things unnecessarily complex?</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="x_Signature">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Tobias Pape <Das.Linux@gmx.de><br>
<b>Gesendet:</b> Donnerstag, 15. August 2019 08:11:30<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: ShoutCore-ct.69.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText"><br>
> On 15.08.2019, at 03:29, Levente Uzonyi <leves@caesar.elte.hu> wrote:<br>
> <br>
> On Wed, 14 Aug 2019, commits@source.squeak.org wrote:<br>
> <br>
>> A new version of ShoutCore was added to project The Inbox:<br>
>> <a href="http://source.squeak.org/inbox/ShoutCore-ct.69.mcz">http://source.squeak.org/inbox/ShoutCore-ct.69.mcz</a><br>
>> <br>
>> ==================== Summary ====================<br>
>> <br>
>> Name: ShoutCore-ct.69<br>
>> Author: ct<br>
>> Time: 14 August 2019, 10:43:04.7164 pm<br>
>> UUID: 7d165f4e-09bf-a445-a664-5e8edb9867b8<br>
>> Ancestors: ShoutCore-ul.68<br>
>> <br>
>> Fix bug in SHParserST80: Wrong styling after blocks with arguments without statements<br>
> <br>
> If you mean that Shout should accept [ :x ], then no, I'm pretty sure that's not valid smalltalk syntax, even if Parser accepts it.<br>
> The vertical bar, even though I consider it unnecessary in all cases, is mandatory when there are arguments.<br>
<br>
I only got to know this "shortcut syntax" because eliot used it either Cog or somewhere in trunk when preparing something (Spur? full block closures? I forgot). So this is a syntax idiosyncrasy that is in active use, not only "old code".
<br>
<br>
Either we forbid it in the parser and change all of the image or allow it in Shout.<br>
<br>
Best regards<br>
-Tobias<br>
<br>
> <br>
> Levente<br>
> <br>
>> <br>
>> Thanks Jakob for the report!<br>
>> <br>
>> =============== Diff against ShoutCore-ul.68 ===============<br>
>> <br>
>> Item was changed:<br>
>> ----- Method: SHParserST80>>parseBlockArguments (in category 'parse') -----<br>
>> parseBlockArguments<br>
>> <br>
>> currentTokenFirst == $: ifFalse: [ ^self ].<br>
>> [ currentTokenFirst == $: ] whileTrue: [<br>
>> self<br>
>> scanPast: #blockArgColon;<br>
>> parseArgument: #blockPatternArg ].<br>
>> + ((self parseVerticalBarForTemporaries: #blockArgsBar) and: [<br>
>> + currentTokenFirst ~= $] ])<br>
>> + ifFalse: [<br>
>> + self fail ": Missing block args bar" ]!<br>
>> - (self parseVerticalBarForTemporaries: #blockArgsBar) ifFalse: [<br>
>> - self fail ": Missing block args bar" ]!<br>
> <br>
<br>
<br>
<br>
</div>
</span></font>
</body>
</html>