<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Does anyone remember for what scenarios this method was written here? Why should it be specific to Morphic?</p>
<p><br>
</p>
<p></p>
<p style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size:16px">
The one scenario I could think of was a ProjectViewMorph pointing to its own project. But in this case, the current Trunk implementation actually does not work but gives you an infinite number of security checks.</p>
<div><span style="font-size:12pt">From my point of view, this condition should not be handled in a Project, but in the corresponding ProjectViewMorph, which decides whether to actually delete the project or only the view. Would you agree with that?</span><br>
</div>
<p></p>
<p><span style="font-size:12pt"><br>
</span></p>
<p><span style="font-size:12pt">I wonder how we can make this check in the view because usually (at least in Morphic), a ProjectViewMorph is wrapped by an "anonymous" SystemWindow where the latter sends #okToClose to the model. I</span><span style="font-size:12pt">s
there any special reason why we do not have a simple ProjectViewModel with ToolBuilder and dedicated #okToClose implementation? This would make things so much easier ... Hypothetically, one could then rewrite the current ProjectViewMorph as a wrapper for the
ProjectViewModel, just for compatibility reasons.</span><br>
</p>
<p><span style="font-size:12pt"><br>
</span></p>
<p><span style="font-size:12pt">I would be glad to hear your opinions :)</span></p>
<p><span style="font-size:12pt"><br>
</span></p>
<p><span style="font-size:12pt">Best,</span></p>
<p><span style="font-size:12pt">Christoph</span></p>
<div id="x_Signature">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Samstag, 21. September 2019 20:33:53<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Inbox: Morphic-ct.1537.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">A new version of Morphic was added to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Morphic-ct.1537.mcz">http://source.squeak.org/inbox/Morphic-ct.1537.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-ct.1537<br>
Author: ct<br>
Time: 21 September 2019, 8:33:43.718935 pm<br>
UUID: d13309f1-8b1d-5742-8d85-81ed5a803904<br>
Ancestors: Morphic-mt.1526<br>
<br>
Add support for closing the current project. In this case, we do not want to suppress the user confirmation.<br>
<br>
=============== Diff against Morphic-mt.1526 ===============<br>
<br>
Item was removed:<br>
- ----- Method: MorphicProject>>okToChange (in category 'release') -----<br>
- okToChange<br>
- "If the view is from somewhere else than the current project, just delete it."<br>
- <br>
- ^ self parent ~~ Project current<br>
- or: [super okToChange]!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>