<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Hi,</p>
<p><br>
</p>
<p>No special reason. Each trackInfo item describes one tracks item, so I thought it could be a good idea to set them at once. Equal to #setString:setRuns: or #real:imaginary:, for example.</p>
<p>If you don't think it improves code quality, I can abstain from it. :)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="x_Signature">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Tobias Pape <Das.Linux@gmx.de><br>
<b>Gesendet:</b> Dienstag, 1. Oktober 2019 20:58:49<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: Sound-ct.69.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Hi<br>
<br>
I don't understand the rationale here.<br>
Care to explain?<br>
What's so different with the "dual" setter?<br>
Best regards<br>
-Tobias<br>
> On 01.10.2019, at 20:25, commits@source.squeak.org wrote:<br>
> <br>
> A new version of Sound was added to project The Inbox:<br>
> <a href="http://source.squeak.org/inbox/Sound-ct.69.mcz">http://source.squeak.org/inbox/Sound-ct.69.mcz</a><br>
> <br>
> ==================== Summary ====================<br>
> <br>
> Name: Sound-ct.69<br>
> Author: ct<br>
> Time: 1 October 2019, 8:25:38.912339 pm<br>
> UUID: b0d38e4d-1231-494f-8502-e1a631e232b3<br>
> Ancestors: Sound-eem.66<br>
> <br>
> Add convenience setter for MIDIScore<br>
> <br>
> These values are strongly related and should in most cases be set at once.<br>
> <br>
> =============== Diff against Sound-eem.66 ===============<br>
> <br>
> Item was changed:<br>
> ----- Method: MIDIFileReader>>asScore (in category 'chunk reading') -----<br>
> asScore<br>
> <br>
> ^ MIDIScore new<br>
> + tracks: tracks trackInfo: trackInfo;<br>
> - tracks: tracks;<br>
> - trackInfo: trackInfo;<br>
> tempoMap: tempoMap;<br>
> ticksPerQuarterNote: ticksPerQuarter;<br>
> source: stream localName<br>
> !<br>
> <br>
> Item was added:<br>
> + ----- Method: MIDIScore>>tracks:trackInfo: (in category 'accessing') -----<br>
> + tracks: trackList trackInfo: trackInfoList<br>
> + <br>
> + self tracks: trackList; trackInfo: trackInfoList.!<br>
> <br>
> <br>
<br>
<br>
<br>
</div>
</span></font>
</body>
</html>