<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>sounds great! <span style="font-size: 12pt;">Did you already have a look at </span><span style="font-size: 12pt;">Morphic-ct.1554? As it happens, I worked on #debugAction for the debug menu myself today and eliminated some duplication. Maybe you could merge
these changes? :-)</span></p>
<p><span style="font-size: 12pt;"><br>
</span></p>
<p><span style="font-size: 12pt;">Also, maybe we should consider combining #doButtonAction and #performAction? It would be great to have the debugAction for every morph ... Could we just override #doButtonAction in PluggableButtonMorph and offer the debugAction
without any condition?</span></p>
<p><span style="font-size: 12pt;"><br>
</span></p>
<p><span style="font-size: 12pt;">Best,</span></p>
<p><span style="font-size: 12pt;">Christoph</span></p>
<div id="Signature">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Dienstag, 1. Oktober 2019 18:33:54<br>
<b>An:</b> Alan Grimes via Squeak-dev<br>
<b>Betreff:</b> [squeak-dev] Please Review | Further Debugger Improvements</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
<div>Hi, all.</div>
<div><br>
</div>
<div>Please find attached a change set to further improve our debugger infrastructure.</div>
<div><br>
</div>
<div>- Replaces ErrorRecursion and ErrorRecursionGard with a process-local variable DebuggerErrorRecursionFlag.</div>
<div>- !!! Adds several tests in DebuggerTests.</div>
<div>- Simplifies Project >> #interruptName:preemptedProcess:</div>
<div>- Simplifies "Debug it" invocation. See Process class >> #forBlock:at: and senders of it such as TextEditor >> #debugIt.</div>
<div>- Adds PluggableTextMorph >> #debugAction and MenuItemMorph >> #debugAction. See those morph's debug menus via halo.</div>
<div>- Move log-file writing for low space to SmalltalkImage >> #lowSpaceWatcher.</div>
<div>- Adds Debugger >> #close, similar to Project >> #close.</div>
<div><br>
</div>
<div>There are still some quirks with MVC debugging but Morphic should be fine.</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
</div>
</div>
</body>
</html>