<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Okay, then discard the proposal :)</p>
<p>Or can I move it to the Treated Inbox myself?</p>
<p><span></span></p>
<div id="Signature">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Mittwoch, 2. Oktober 2019 08:47:38<br>
<b>An:</b> Alan Grimes via Squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: Sound-ct.69.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
This only makes sense if both are required to construct a meaningful object. Just for convenience, it wouldn't add anything. <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">#setString:setRuns: for Text is such a meaningful combination.</span>
<div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px"><br>
</span></span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif"><span style="font-size: 13px">-1 :-)<br>
</span></span>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br>
</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Best,<br>
Marcel</span></div>
</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 01.10.2019 22:02:03 schrieb Tobias Pape <das.linux@gmx.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif"><br>
> On 01.10.2019, at 21:49, Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>
wrote:<br>
> <br>
> Hi,<br>
> <br>
> No special reason. Each trackInfo item describes one tracks item, so I thought it could be a good idea to set them at once. Equal to #setString:setRuns: or #real:imaginary:, for example.<br>
<br>
I see your point. However, these two are more private (as most #set… are). The one for Complex could be even thought of as primitive and maybe this method shouldn't be necessary conceptually.<br>
<br>
> If you don't think it improves code quality, I can abstain from it. :)<br>
<br>
No problem, I was just wondering. <br>
In cases where you want to communicate the _caller_ that something should be thought of as a unit, I would probably make a class-side convenience constructor.<br>
<br>
Keep it coming :D<br>
<br>
Best regards<br>
-Tobias<br>
<br>
> <br>
> Best,<br>
> Christoph<br>
> Von: Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org>im Auftrag von Tobias Pape
<das.linux@gmx.de><br>
> Gesendet: Dienstag, 1. Oktober 2019 20:58:49<br>
> An: squeak-dev@lists.squeakfoundation.org<br>
> Betreff: Re: [squeak-dev] The Inbox: Sound-ct.69.mcz<br>
> <br>
> Hi<br>
> <br>
> I don't understand the rationale here.<br>
> Care to explain?<br>
> What's so different with the "dual" setter?<br>
> Best regards<br>
> -Tobias<br>
> > On 01.10.2019, at 20:25, commits@source.squeak.org wrote:<br>
> > <br>
> > A new version of Sound was added to project The Inbox:<br>
> > http://source.squeak.org/inbox/Sound-ct.69.mcz<br>
> > <br>
> > ==================== Summary ====================<br>
> > <br>
> > Name: Sound-ct.69<br>
> > Author: ct<br>
> > Time: 1 October 2019, 8:25:38.912339 pm<br>
> > UUID: b0d38e4d-1231-494f-8502-e1a631e232b3<br>
> > Ancestors: Sound-eem.66<br>
> > <br>
> > Add convenience setter for MIDIScore<br>
> > <br>
> > These values are strongly related and should in most cases be set at once.<br>
> > <br>
> > =============== Diff against Sound-eem.66 ===============<br>
> > <br>
> > Item was changed:<br>
> > ----- Method: MIDIFileReader>>asScore (in category 'chunk reading') -----<br>
> > asScore<br>
> > <br>
> > ^ MIDIScore new<br>
> > + tracks: tracks trackInfo: trackInfo;<br>
> > - tracks: tracks;<br>
> > - trackInfo: trackInfo;<br>
> > tempoMap: tempoMap;<br>
> > ticksPerQuarterNote: ticksPerQuarter;<br>
> > source: stream localName<br>
> > !<br>
> > <br>
> > Item was added:<br>
> > + ----- Method: MIDIScore>>tracks:trackInfo: (in category 'accessing') -----<br>
> > + tracks: trackList trackInfo: trackInfoList<br>
> > + <br>
> > + self tracks: trackList; trackInfo: trackInfoList.!<br>
> > <br>
> > <br>
<br>
<br>
<br>
</das.linux@gmx.de></squeak-dev-bounces@lists.squeakfoundation.org></christoph.thiede@student.hpi.uni-potsdam.de></div>
</blockquote>
</div>
</div>
</body>
</html>