<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div dir="auto" style="direction: ltr; margin: 0; padding: 0; font-family: sans-serif; font-size: 11pt; color: black; ">
UI for editing subtopics is following later. I need a vacation first :) <span id="OutlookSignature">
</span></div>
<br>
<br>
<br>
<div class="gmail_quote">On Thu, Oct 3, 2019 at 1:43 AM +0200, "Thiede, Christoph"
<span dir="ltr"><<a href="mailto:Christoph.Thiede@student.hpi.uni-potsdam.de" target="_blank">Christoph.Thiede@student.hpi.uni-potsdam.de</a>></span> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="3D"ltr""><style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr">
<p>Do you think we should install a mediator the file browsing (highlighted below) at some place like ToolSet to reduce dependencies? Or is that still insignificant?</p>
<br>
<div style="color: rgb(0, 0, 0);">
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Donnerstag, 3. Oktober 2019 01:39 Uhr<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Inbox: HelpSystem-Core-ct.120.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">A new version of HelpSystem-Core was added to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/HelpSystem-Core-ct.120.mcz" id="LPlnk951749" previewremoved="true">http://source.squeak.org/inbox/HelpSystem-Core-ct.120.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: HelpSystem-Core-ct.120<br>
Author: ct<br>
Time: 3 October 2019, 1:39:46.913682 am<br>
UUID: c9b2afad-2786-1f47-a2f5-8ee6258fe75c<br>
Ancestors: HelpSystem-Core-ct.119<br>
<br>
Adds browse entry into the HelpBrowser menu<br>
<br>
=============== Diff against HelpSystem-Core-ct.119 ===============<br>
<br>
Item was added:<br>
+ ----- Method: ClassAPIHelpTopic>>browseTopic (in category 'tools') -----<br>
+ browseTopic<br>
+ <br>
+ ^ self theClass theMetaClass browse!<br>
<br>
Item was added:<br>
+ ----- Method: ClassBasedHelpTopic>>browseSubtopic: (in category 'tools') -----<br>
+ browseSubtopic: aTopic<br>
+ <br>
+ ^ ToolSet browse: self helpClass theMetaClass selector: aTopic key!<br>
<br>
Item was added:<br>
+ ----- Method: ClassBasedHelpTopic>>browseTopic (in category 'tools') -----<br>
+ browseTopic<br>
+ <br>
+ ^ self helpClass theMetaClass browse!<br>
<br>
<span style="background-color: rgb(255, 255, 0);">Item was added:</span><br>
<span style="background-color: rgb(255, 255, 0);">+ ----- Method: DirectoryBasedHelpTopic>>browseTopic (in category 'tools') -----</span><br>
<span style="background-color: rgb(255, 255, 0);">+ browseTopic</span><br>
<span style="background-color: rgb(255, 255, 0);">+ </span><br>
<span style="background-color: rgb(255, 255, 0);">+ ^ FileList openOn: self directoryEntry asFileDirectory!</span><br>
<span style="background-color: rgb(255, 255, 0);"></span><br>
<span style="background-color: rgb(255, 255, 0);"></span><span style="background-color: rgb(255, 255, 0);"><span style="background-color: rgb(255, 255, 0);">Item</span> was added:</span><br>
<span style="background-color: rgb(255, 255, 0);">+ ----- Method: FileBasedHelpTopic>>browseTopic (in category 'tools') -----</span><br>
<span style="background-color: rgb(255, 255, 0);">+ browseTopic</span><br>
<span style="background-color: rgb(255, 255, 0);">+ </span><br>
<span style="background-color: rgb(255, 255, 0);">+ ^ FileList openOn: self fileEntry containingDirectory!</span><br>
<br>
Item was added:<br>
+ ----- Method: HelpBrowser>>browseTopic (in category 'actions') -----<br>
+ browseTopic<br>
+ <br>
+ ^ (self currentTopic respondsTo: #browseTopic)<br>
+ ifTrue: [self currentTopic browseTopic]<br>
+ ifFalse: [self currentParentTopic browseSubtopic: self currentTopic]!<br>
<br>
Item was added:<br>
+ ----- Method: HelpBrowser>>canBrowseTopic (in category 'testing') -----<br>
+ canBrowseTopic<br>
+ <br>
+ ^ (self currentTopic respondsTo: #browseTopic)<br>
+ or: [self currentParentTopic respondsTo: #browseSubtopic:]!<br>
<br>
Item was changed:<br>
----- Method: HelpBrowser>>treeKey:from:event: (in category 'menus') -----<br>
treeKey: aChar from: aView event: anEvent<br>
<br>
anEvent anyModifierKeyPressed ifFalse: [^ false].<br>
aChar<br>
caseOf: {<br>
+ [$b] -> [self browseTopic].<br>
[$i] -> [self inspectTopic].<br>
[$I] -> [self exploreTopic]. }<br>
otherwise: [^ false].<br>
^ true!<br>
<br>
Item was changed:<br>
----- Method: HelpBrowser>>treeListMenu: (in category 'menus') -----<br>
treeListMenu: aMenu<br>
<treeListMenu><br>
<br>
self currentTopic ifNil: [^ aMenu].<br>
<br>
aMenu<br>
add: 'Inspect (i)' action: #inspectTopic;<br>
add: 'Explore (I)' action: #exploreTopic.<br>
<br>
+ self canBrowseTopic ifTrue: [<br>
+ aMenu<br>
+ addLine;<br>
+ add: 'Browse (b)' action: #browseTopic].<br>
+ <br>
^ aMenu!<br>
<br>
Item was added:<br>
+ ----- Method: MethodListHelpTopic>>browseTopic (in category 'tools') -----<br>
+ browseTopic<br>
+ <br>
+ ^ self theClass browse!<br>
<br>
Item was added:<br>
+ ----- Method: PackageAPIHelpTopic>>browseTopic (in category 'tools') -----<br>
+ browseTopic<br>
+ <br>
+ ^ (PackageInfo named: packageName) browse!<br>
<br>
<br>
</div>
</span></font></div>
</div>
</div>
</blockquote>
</div>
</body>
</html>