<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Yes, you're right :)</p>
<p>You find the use of Symbol>>#value: "too meta"? I like it as a good readable shorthand.</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="x_Signature">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Tobias Pape <Das.Linux@gmx.de><br>
<b>Gesendet:</b> Montag, 14. Oktober 2019 09:16:21<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: HelpSystem-Core-ct.125.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Hi<br>
<br>
I'd like to propose a little change:<br>
<br>
<br>
> On 14.10.2019, at 00:34, commits@source.squeak.org wrote:<br>
> <br>
> ----- Method: ClassBasedHelpTopic>>contents (in category 'accessing') -----<br>
> contents<br>
> "A book has no contents. Only its pages do."<br>
> <br>
> + ^ self defaultSubtopic ifNil: [''] ifNotNil: #contents!<br>
<br>
^ self defaultSubtopic<br>
ifNotNil: [:topic | topic contents]<br>
ifNil: ['']<br>
<br>
This changes the order so that the non-exceptional case is first. It also avoids the meta-level.<br>
<br>
<br>
> - ^ ''!<br>
> <br>
> Item was added:<br>
> + ----- Method: ClassBasedHelpTopic>>defaultSubtopic (in category 'accessing') -----<br>
> + defaultSubtopic<br>
> + <br>
> + ^ self helpClass defaultPageKey<br>
> + ifNotNil: [:key |<br>
> + self subtopics<br>
> + detect: [:topic | topic key = key]<br>
> + ifNone: [nil]]<br>
> + ifNil: [nil]!<br>
<br>
I'd leave out the 'ifNil: [nil]' case; it's implied when sending ifNotNil:.<br>
<br>
Best regards<br>
-Tobias<br>
<br>
</div>
</span></font>
</body>
</html>