<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Well, should I commit again, or is it easier for the merger to align the code style?</p>
<div id="Signature">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Dienstag, 15. Oktober 2019 15:23:54<br>
<b>An:</b> gettimothy via Squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: HelpSystem-Core-ct.125.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Christoph. :-)
<div><br>
</div>
<div>> <span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"> </span><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">I like it as a good readable shorthand.</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br>
</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">That's debatable. ;-) "#contents" is a Symbol. "[:topic | topic contents]" is a block with message sends. I find the latter more readable because it reveals the message sends. You
can debug it, put a "self halt" in it, etc.</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br>
</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">> </span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 10pt"> </span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 10pt">self defaultSubtopic
ifNil: [''] ifNotNil: #contents</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 10pt"><br>
</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 10pt">I don't like the asymmetry between block and symbol. So, in this case, I prefer blocks over that symbol shorthand for a second reason.</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br>
</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Best,</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">Marcel</span></div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 14.10.2019 11:55:39 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif">
<p>Yes, you're right :)</p>
<p>You find the use of Symbol>>#value: "too meta"? I like it as a good readable shorthand.</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="x_Signature">
<div name="x_divtagdefaultwrapper" style="font-family: Calibri,Arial,Helvetica,sans-serif;font-size: ;margin: 0">
<div><span style="font-size: 10pt;color: #808080"></span></div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Tobias Pape <Das.Linux@gmx.de><br>
<b>Gesendet:</b> Montag, 14. Oktober 2019 09:16:21<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: HelpSystem-Core-ct.125.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">Hi<br>
<br>
I'd like to propose a little change:<br>
<br>
<br>
> On 14.10.2019, at 00:34, commits@source.squeak.org wrote:<br>
> <br>
> ----- Method: ClassBasedHelpTopic>>contents (in category 'accessing') -----<br>
> contents<br>
> "A book has no contents. Only its pages do."<br>
> <br>
> + ^ self defaultSubtopic ifNil: [''] ifNotNil: #contents!<br>
<br>
^ self defaultSubtopic<br>
ifNotNil: [:topic | topic contents]<br>
ifNil: ['']<br>
<br>
This changes the order so that the non-exceptional case is first. It also avoids the meta-level.<br>
<br>
<br>
> - ^ ''!<br>
> <br>
> Item was added:<br>
> + ----- Method: ClassBasedHelpTopic>>defaultSubtopic (in category 'accessing') -----<br>
> + defaultSubtopic<br>
> + <br>
> + ^ self helpClass defaultPageKey<br>
> + ifNotNil: [:key |<br>
> + self subtopics<br>
> + detect: [:topic | topic key = key]<br>
> + ifNone: [nil]]<br>
> + ifNil: [nil]!<br>
<br>
I'd leave out the 'ifNil: [nil]' case; it's implied when sending ifNotNil:.<br>
<br>
Best regards<br>
-Tobias<br>
<br>
</div>
</span></span></div>
</blockquote>
</div>
</div>
</body>
</html>