<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Eliot.<div><br></div><div>I don't think this works as expected. Please take a look at StringTest >> testFindSelector. The semantics of String >> #findSelector and Scanner >> #typedScanTokens: seem quite different.</div><div><br></div><div>Also, you forgot to commit TextEditor >> #selectedLiteral to make #sendersOfIt work as you intended.</div><div><br></div><div>Should we roll back this commit and polish it through the inbox first? ;-)</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 30.11.2019 01:50:55 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p><div style="font-family:Arial,Helvetica,sans-serif">Eliot Miranda uploaded a new version of Morphic to project The Trunk:<br>http://source.squeak.org/trunk/Morphic-eem.1596.mcz<br><br>==================== Summary ====================<br><br>Name: Morphic-eem.1596<br>Author: eem<br>Time: 29 November 2019, 4:50:37.46714 pm<br>UUID: e4ca2f3d-c9db-4468-bb91-cf698317b2f1<br>Ancestors: Morphic-mt.1595<br><br>Have seNders in the text editor also look up references to literals.<br><br>=============== Diff against Morphic-mt.1595 ===============<br><br>Item was changed:<br> ----- Method: TextEditor>>selectedSelector (in category 'menu messages') -----<br> selectedSelector<br> "Try to make a selector out of the current text selection"<br>+ | tokens |<br>+ tokens := Scanner new typedScanTokens: self selection string.<br>+ ^tokens isEmpty ifFalse: [tokens first]!<br>- ^self selection string findSelector!<br><br>Item was changed:<br> ----- Method: TextEditor>>sendersOfIt (in category 'menu messages') -----<br> sendersOfIt<br> "Open a senders browser on the selected selector"<br> <br>- | aSelector |<br> self lineSelectAndEmptyCheck: [^ self].<br>+ self selectedSelector ifNotNil:<br>+ [:aSelector| ^self systemNavigation browseAllCallsOn: aSelector].<br>+ self selectedLiteral ifNotNil:<br>+ [:aLiteral| ^self systemNavigation browseAllCallsOn: aLiteral].<br>+ morph flash!<br>- (aSelector := self selectedSelector) == nil ifTrue: [^ morph flash].<br>- self systemNavigation browseAllCallsOn: aSelector!<br><br><br></div></blockquote></div>