<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Sorry for the confusion. As I tried to explain, I must admit that I never wrote a real implementation of #<span>shortPrintString. I was not aware of this when I uploaded this commit. The implementation I used for testing was only a fake:</span></p>
<p><span style="font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont;"><br>
</span></p>
<p><span style="font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont;">shortPrintString</span><br>
</p>
<p><span></span></p>
<div style="font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; font-size: 16px; margin-top: 14pt; margin-bottom: 14pt;">
^ self printString copyWithRegex: '\s*' matchesReplacedWith: ' '<br>
</div>
<div><br>
</div>
<div>I don't think this would be valuable for Trunk? Do you think an implementation of ParseNode>>#shortPrintString would be useful in general, or could we use the "copyWithRegex" trick in #<span>initializeCommonRequestStrings?</span></div>
<div><span><br>
</span></div>
<div><span>Best,</span></div>
<div><span>Christoph</span></div>
<div id="Signature">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Dienstag, 3. Dezember 2019 09:25:54<br>
<b>An:</b> John Pfersich via Squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: System-ct.1120.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Christoph.
<div><br>
</div>
<div>> <span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">I'm afraid that this implementation must be missing at the moment.</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br>
</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">I am a little bit confused. You added the very first send of #</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">veryShortPrintOn: in System-ct.1117.
No class implements it. Then, in </span><span style="font-family: Calibri, sans-serif;font-size: 14.6667px">System-ct.1120, you changed that to #</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">shortPrintString, which is only
implemented on Color. Then again, ParseNode implements #shortPrintOn:.</span></div>
<div><br>
</div>
<div>So, could you please add #shortPrintString to this inbox commit? :-)</div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br>
</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Best,</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Marcel</span></div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 03.12.2019 08:54:05 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<p>Hi Marcel, sorry for the really long delay!</p>
<p><br>
</p>
<p>I'm afraid that this implementation must be missing at the moment. In my image, I had fast faked it with:</p>
<p><br>
</p>
<p>shortPrintString</p>
<p><span> ^ self printString copyWithRegex: '\s*' matchesReplacedWith: ' '</span><br>
</p>
<p><span><br>
</span></p>
<p><span>But respecting parse trees such as [' ' , '</span></p>
<p><span>'] decompile (sic), I am not sure whether this would be a good implementation ...</span></p>
<p>Otherwise, implementing something like #shortPrintOn: in every ParseNode class would cause a lot of duplication or, alternatively, raise the complexity of the existing printing methods (each extended with another argument for the print selector to use for
descendents).</p>
<p><br>
</p>
<p>In general, do you think such a method might be useful at all? If not, the "regex replace" trick could be directly applied in <span>initializeCommonRequestStrings, how do you think about it?</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="Signature">
<div name="divtagdefaultwrapper" style="font-family: Calibri,Arial,Helvetica,sans-serif;font-size: ;margin: 0">
<div><span style="font-size: 10pt;color: #808080"></span></div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Dienstag, 19. November 2019 12:03:30<br>
<b>An:</b> John Pfersich via Squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: System-ct.1120.mcz</span>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
<div>Hi Christoph.</div>
<div><br>
</div>
Neither #<span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">veryShortPrintOn: nor #</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">shortPrintString are implemented in ParseNode. Does this contribution depend
on something else?</span>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br>
</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Best,</span></div>
<div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Marcel</span></div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 26.10.2019 22:23:05 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">A new version of System was added to project The Inbox:<br>
http://source.squeak.org/inbox/System-ct.1120.mcz<br>
<br>
==================== Summary ====================<br>
<br>
Name: System-ct.1120<br>
Author: ct<br>
Time: 26 October 2019, 10:22:46.213469 pm<br>
UUID: 7ed0a01b-5518-e24f-9ead-65e1789c94d4<br>
Ancestors: System-ct.1117<br>
<br>
Revise System-ct.1117 (concerning CommonRequestStrings): Fix wrong dependency and improve code formatting<br>
<br>
=============== Diff against System-ct.1117 ===============<br>
<br>
Item was changed:<br>
----- Method: Utilities class>>initializeCommonRequestStrings (in category 'common requests') -----<br>
initializeCommonRequestStrings<br>
"Initialize the common request strings, a directly-editable list of expressions that can be evaluated from the 'do...' menu."<br>
<br>
CommonRequestStrings := StringHolder new contents: (<br>
+ String streamContents: [:stream | self commonRequestBlocks<br>
+ do: [:block | block decompile statements<br>
+ do: [:statement | stream<br>
+ nextPutAll: (statement shortPrintString<br>
+ copyWithRegex: '\s+'<br>
+ matchesReplacedWith: String space);<br>
+ nextPut: $.]<br>
+ separatedBy: [stream cr]]<br>
+ separatedBy: [stream cr; nextPut: $-; cr]])<br>
- String streamContents: [:stream |<br>
- self commonRequestBlocks<br>
- do: [:block |<br>
- block decompile statements<br>
- do: [:statement |<br>
- statement veryShortPrintOn: stream.<br>
- stream nextPut: $.]<br>
- separatedBy: [stream cr]]<br>
- separatedBy: [stream cr; nextPut: $-; cr]])<br>
<br>
"Utilities initializeCommonRequestStrings"!<br>
<br>
<br>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</body>
</html>