<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hey Eliot,<div><br></div><div>take a look at Morphic-mt.1602. Is that more like what you suggested?</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 04.12.2019 16:16:15 schrieb Eliot Miranda <eliot.miranda@gmail.com>:</p><div style="font-family:Arial,Helvetica,sans-serif">Hi Marcel,<br><br><br>> On Dec 4, 2019, at 6:15 AM, commits@source.squeak.org wrote:<br>> <br>> A new version of Morphic was added to project The Inbox:<br>> http://source.squeak.org/inbox/Morphic-mt.1601.mcz<br>> <br>> ==================== Summary ====================<br>> <br>> Name: Morphic-mt.1601<br>> Author: mt<br>> Time: 4 December 2019, 3:14:52.073613 pm<br>> UUID: 19583b0d-de7d-45e3-bf18-c4b7b2690b47<br>> Ancestors: Morphic-mt.1600<br>> <br>> Proposal: For "implementors of it!" on class bindings or class-var bindings or other global bindings, browse the underlying class of it. For the user's convenience. At the moment, implementors-of-it on such bindings does simply nothing.<br><br>+100 for the functionality. But I would definitely call “browseClass:” something different such as “browseClassOrPoolDefining:”. The binding could be that of a class or of a class/pool variable. browseClass: isn’t a good name and if it just browses classes that are the values of bindings it isn’t that useful. <br><br>The vm contains a number of pools, the largest of which defines the opcodes in the JIT’s abstract machine. So my WiFi’s is full of bindings other than those that define classes.<br><br><br>> =============== Diff against Morphic-mt.1600 ===============<br>> <br>> Item was changed:<br>> ----- Method: TextEditor>>implementorsOfIt (in category 'menu messages') -----<br>> implementorsOfIt<br>> + "Open an implementors browser on the selected selector or a regular browser if the selection is a class binding."<br>> + <br>> - "Open an implementors browser on the selected selector"<br>> - | aSelector |<br>> self lineSelectAndEmptyCheck: [^ self].<br>> + self selectedBinding ifNotNil:<br>> + [:binding | ^ self systemNavigation browseClass: binding].<br>> + self selectedSelector ifNotNil:<br>> + [:selector | ^ self systemNavigation browseAllImplementorsOf: selector].<br>> + morph flash!<br>> - (aSelector := self selectedSelector) == nil ifTrue: [^ morph flash].<br>> - model browseAllImplementorsOf: aSelector!<br>> <br>> <br><br></div></blockquote>
</div></body>