<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
> <span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">What are your goals to make changes like this?</span><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br></span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">So close to a release, my goals are to not add new dependencies between packages.</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br></span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">> </span><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">In general, wouldn't generic error handling like this increase the risk of suppressing unexpected errors?</span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br></span></div><div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">The very meaning of #</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 10pt">valueSupplyingAnswers: is to suppress interactive stuff. Maybe we could add a Transcript output to log those errors. Also, this mechanism deserves to be re-designed. There is a lot of things going on in this method. We need better extension points for this and tests and ... :-)</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 10pt"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 10pt">Best,</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 10pt">Marcel</span></div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 07.12.2019 00:06:37 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif">
<p>Just curious: #matchesRegex: is defined in Regex-Core as well as RegexSyntaxError.</p>
<p>What are your goals to make changes like this?</p>
<p>In general, wouldn't generic error handling like this increase the risk of suppressing unexpected errors? :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: rgb(0,0,0);font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family: Calibri,Arial,Helvetica,sans-serif;font-size: ;margin: 0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><span style="font-family: Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont"></font></div>
</div>
</span></div>
</div>
</div>
</div>
</div>
<div><span style="font-size: 10pt;color: #808080"></span></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Mittwoch, 27. November 2019 10:25:56<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Kernel-mt.1283.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">Marcel Taeumel uploaded a new version of Kernel to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Kernel-mt.1283.mcz">http://source.squeak.org/trunk/Kernel-mt.1283.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Kernel-mt.1283<br>
Author: mt<br>
Time: 27 November 2019, 10:25:51.203363 am<br>
UUID: 04694a24-76a1-a941-b664-645ffc7f27e6<br>
Ancestors: Kernel-nice.1282<br>
<br>
Removes Kernel -> Regex dependency.<br>
<br>
=============== Diff against Kernel-nice.1282 ===============<br>
<br>
Item was changed:<br>
----- Method: BlockClosure>>valueSupplyingAnswers: (in category 'evaluating') -----<br>
valueSupplyingAnswers: aListOfPairs<br>
"evaluate the block using a list of questions / answers that might be called upon to<br>
automatically respond to Object>>confirm: or FillInTheBlank requests"<br>
<br>
^self<br>
on: ProvideAnswerNotification<br>
do: [ :notification |<br>
| caption |<br>
caption := notification messageText withSeparatorsCompacted. "to remove new lines"<br>
aListOfPairs<br>
detect: [ :each |<br>
caption = each first<br>
or: [ (caption includesSubstring: each first caseSensitive: false)<br>
or: [ (each first match: caption)<br>
or: [ (caption respondsTo: #matchesRegex:)
<br>
+ and: [ [caption matchesRegex: each first] on: Error do: [false] ] ] ] ] ]<br>
- and: [ [caption matchesRegex: each first] on: RegexSyntaxError do: [false] ] ] ] ] ]<br>
ifFound: [ :answer | notification resume: answer second ]<br>
ifNone: [<br>
(ProvideAnswerNotification signal: notification messageText)<br>
ifNil: [ notification resume ]<br>
ifNotNil: [ :outerAnswer | notification resume: outerAnswer ] ] ]!<br>
<br>
<br>
</div>
</span></span>
</div></blockquote>
</div></body>