<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Christoph,<div><br></div><div>why did you change "self closeDialog" to "self abandon"?</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 07.12.2019 16:21:22 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p><div style="font-family:Arial,Helvetica,sans-serif">A new version of Morphic was added to project The Inbox:<br>http://source.squeak.org/inbox/Morphic-ct.1605.mcz<br><br>==================== Summary ====================<br><br>Name: Morphic-ct.1605<br>Author: ct<br>Time: 7 December 2019, 4:21:04.854219 pm<br>UUID: 3c7d5454-0b60-2a47-91fd-51d333eeeb3b<br>Ancestors: Morphic-mt.1604<br><br>Delete dialog windows if curtailed<br><br>This can happen when the user debugs its invocation and then abandons the debugger, but also in the following example:<br><br>[self inform: 'Carpe Squeak!'] valueWithin: 2 seconds onTimeout: []<br><br>Imho, it would be a bad idea to keep such a dialog window open if nothing will happen after you react on it.<br><br>=============== Diff against Morphic-mt.1604 ===============<br><br>Item was changed:<br> ----- Method: DialogWindow>>debugInvocation (in category 'running') -----<br> debugInvocation<br> <br>+ Processor activeProcess<br>- [Processor activeProcess<br> debug: self findInvocationContext<br>+ title: 'Dialog invocation'!<br>- title: 'Dialog invocation']<br>- ifCurtailed: [self closeDialog].!<br><br>Item was changed:<br> ----- Method: DialogWindow>>getUserResponse (in category 'running') -----<br> getUserResponse<br> <br> | hand world |<br> self message ifEmpty: [messageMorph delete]. "Do not waste space."<br> self paneMorph submorphs<br> ifEmpty: ["Do not waste space and avoid strange button-row wraps."<br> self paneMorph delete.<br> self buttonRowMorph wrapDirection: #none]. <br> <br> hand := self currentHand.<br> world := self currentWorld.<br> <br> self fullBounds.<br> self moveToPreferredPosition.<br> self openInWorld: world.<br> <br> hand showTemporaryCursor: nil. "Since we are out of context, reset the cursor."<br> <br> hand keyboardFocus in: [:priorKeyboardFocus |<br> hand mouseFocus in: [:priorMouseFocus |<br> self exclusive ifTrue: [hand newMouseFocus: self].<br> hand newKeyboardFocus: self.<br> <br>+ [[self isInWorld] whileTrue: [world doOneSubCycle]]<br>+ ifCurtailed: [self abandon].<br>- [self isInWorld] whileTrue:[world doOneSubCycle].<br> <br> hand newKeyboardFocus: priorKeyboardFocus.<br> hand newMouseFocus: priorMouseFocus]].<br> <br> ^ result!<br><br><br></div></blockquote>
</div></body>