<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>yes, I read your comment and liked your explanation :) Thanks for your tips!</p>
<p>I actually implemented this by trial & error, so I was not aware of the actual reason how it works before.</p>
<p><br>
</p>
<p>Same question as a few minutes ago: Would you like me to commit again or would this be unnecessary noise? :)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont"></font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Sonntag, 8. Dezember 2019 16:31:13<br>
<b>An:</b> John Pfersich via Squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: ShoutCore-mt.76.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Christoph,
<div><br>
</div>
<div>sounds good. Maybe a small comment on your comment from a previous contribution:</div>
<div><br>
</div>
<div><span style="font-size: 13.3333px">"little white lie to work in every situation"</span><br>
</div>
<div><span style="font-size: 13.3333px"><br>
</span></div>
<div><span style="font-size: 13.3333px">That's a bad comment. :-) Instead of explaining "true" with "to make it always work", you should try elaborate on the meaining of "true" in this situation. I know that the interface #rangeForPC... is not perfect. However,
a comment could state the relationship to the PC argument as specified above. This is what I tried to achieve with:</span></div>
<div><span style="font-size: 13.3333px"><br>
</span></div>
<div><span style="font-size: 13.3333px">"to really use the context's pc"</span><br>
</div>
<div><span style="font-size: 13.3333px"><br>
</span></div>
<div><span style="font-size: 13.3333px">Maybe this helps for writing comments in the future. :-)</span></div>
<div><span style="font-size: 13.3333px"><br>
</span></div>
<div><span style="font-size: 13.3333px">Best,</span></div>
<div><span style="font-size: 13.3333px">Marcel</span></div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 06.12.2019 23:54:15 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>Did you see <span>ShoutCore-ct.76? I think my solution could also work for dead contexts, instead of just refusing to style :-)</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: rgb(0,0,0);font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family: Calibri,Arial,Helvetica,sans-serif;font-size: ;margin: 0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><span style="font-family: Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont"></font></div>
</div>
</span></div>
</div>
</div>
</div>
</div>
<div><span style="font-size: 10pt;color: #808080"></span></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Donnerstag, 21. November 2019 15:51:18<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: ShoutCore-mt.76.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">Marcel Taeumel uploaded a new version of ShoutCore to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/ShoutCore-mt.76.mcz">http://source.squeak.org/trunk/ShoutCore-mt.76.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: ShoutCore-mt.76<br>
Author: mt<br>
Time: 21 November 2019, 3:51:18.231156 pm<br>
UUID: c0aa1566-69f3-1845-8993-0f5f67fcdb96<br>
Ancestors: ShoutCore-eem.75<br>
<br>
Fixes a bug with syntax highlighting for dead context's in the debugger.<br>
<br>
=============== Diff against ShoutCore-eem.75 ===============<br>
<br>
Item was changed:<br>
----- Method: SHParserST80>>initializeInstanceVariables (in category 'parse support') -----<br>
initializeInstanceVariables<br>
<br>
instanceVariables := classOrMetaClass <br>
ifNil: [ #() ]<br>
ifNotNil: [ classOrMetaClass allInstVarNames asArray ].<br>
allowUnderscoreAssignments := Scanner allowUnderscoreAsAssignment.<br>
allowUnderscoreSelectors := Scanner prefAllowUnderscoreSelectors.<br>
allowBlockArgumentAssignment := Scanner allowBlockArgumentAssignment.<br>
sourcePosition := 1.<br>
arguments<br>
ifNil: [ arguments := OrderedCollection with: nil ]<br>
ifNotNil: [ arguments reset; addLast: nil ].<br>
temporaries<br>
ifNil: [ temporaries := OrderedCollection with: nil ]<br>
ifNotNil: [ temporaries reset; addLast: nil ].<br>
+ (context notNil and: [ context isDead not ])<br>
+ ifTrue: [ self initializeVariablesFromContext ].<br>
- context ifNotNil: [ self initializeVariablesFromContext ].<br>
bracketDepth := 0.<br>
ranges<br>
ifNil: [ ranges := OrderedCollection new: 40 "Covers over 80% of all methods." ]<br>
ifNotNil: [ ranges reset ]!<br>
<br>
Item was changed:<br>
----- Method: SHParserST80>>initializeVariablesFromContext (in category 'parse support') -----<br>
initializeVariablesFromContext<br>
<br>
| contextSourcePcIndex contextSourceParser |<br>
contextSourcePcIndex := (context debuggerMap<br>
rangeForPC: context pc<br>
in: context method<br>
+ contextIsActiveContext: true "... to really use the context's pc.")<br>
- contextIsActiveContext: true "little white lie to work in every situation")<br>
start.<br>
contextSourceParser := self class new<br>
classOrMetaClass: context method methodClass;<br>
environment: self environment;<br>
source: (context method getSource first: contextSourcePcIndex);<br>
yourself.<br>
contextSourceParser parse.<br>
arguments := contextSourceParser activeArguments.<br>
temporaries := contextSourceParser activeTemporaries.!<br>
<br>
<br>
</div>
</span></span></div>
</blockquote>
</div>
</div>
</body>
</html>