<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Christoph,<div><br></div><div>sure you can update that version in the inbox. Still, i am not so sure about that extension point #<span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">defaultCategoryForSelector: you proposed in </span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Kernel-ct.1285...</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">What are other default categories for selectors (or messages)?</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Best,</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Marcel</span></div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 08.12.2019 19:44:31 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<p>Oops, I have always been using this wrong name when writing tests ... Thank you!</p>
<p><br>
</p>
<p>I need to know what is easier for you: Should I</p>
<p>a) <span style="font-size: 12pt">commit again with this commit as ancestor,</span></p>
<p><span style="font-size: 12pt">b) commit again with latest Trunk commit as ancestor, or</span></p>
<p><span style="font-size: 12pt">c) don't commit again at all to reduce noise and you can replace this single selector when merging? :)</span></p>
<p><span style="font-size: 12pt"><br>
</span></p>
<p><span style="font-size: 12pt">Best,</span></p>
<p><span style="font-size: 12pt">Christoph</span></p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: rgb(0, 0, 0);font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols">
<div name="divtagdefaultwrapper" style="font-family: Calibri,Arial,Helvetica,sans-serif;font-size: ;margin: 0">
<div><span style="font-size: 10pt;color: #808080"></span></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Sonntag, 8. Dezember 2019 15:54:44<br>
<b>An:</b> John Pfersich via Squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: SUnit-ct.121.mcz</span>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Yes, it must be 'tests' for the tests in test cases. ;-) Not 'testing'.
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 07.12.2019 22:06:07 schrieb David T. Lewis <lewis@mail.msen.com>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">Yes, it should be 'tests'.<br>
<br>
But don't feel badly about picking the "wrong" category, just have<br>
a look at what all the rest of us have done over the years:<br>
<br>
Dictionary withAll: ( { 'testing' . 'Testing' . 'tests' . 'test' }<br>
collect: [ :cat |<br>
cat -> (TestCase withAllSubclasses<br>
select: [ :cls | cls organization categories includes: cat ])]).<br>
<br>
Dave<br>
<br>
<br>
On Sat, Dec 07, 2019 at 08:40:39PM +0000, Thiede, Christoph wrote:<br>
> 'tests'?<br>
> <br>
> ________________________________<br>
> Von: Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org>im Auftrag von Chris Muller
<asqueaker@gmail.com><br>
> Gesendet: Samstag, 7. Dezember 2019 21:07:59<br>
> An: squeak dev<br>
> Betreff: Re: [squeak-dev] The Inbox: SUnit-ct.121.mcz<br>
> <br>
> "testing" is for messages that answer booleans. For example, TestCase>>#shouldPass.<br>
> <br>
> The #test... methods should be categorized differently.<br>
> <br>
> - Chris<br>
> <br>
> <br>
> On Sat, Dec 7, 2019 at 8:31 AM <><mailto:commits@source.squeak.org>> wrote:<br>
> A new version of SUnit was added to project The Inbox:<br>
> http://source.squeak.org/inbox/SUnit-ct.121.mcz<br>
> <br>
> ==================== Summary ====================<br>
> <br>
> Name: SUnit-ct.121<br>
> Author: ct<br>
> Time: 7 December 2019, 3:31:28.823146 pm<br>
> UUID: 56da0773-e6ce-8d44-9496-57eea4253f3f<br>
> Ancestors: SUnit-mt.120<br>
> <br>
> Specify default message category for test selectors. Depends on Kernel-mt.1284.<br>
> <br>
> =============== Diff against SUnit-mt.120 ===============<br>
> <br>
> Item was added:<br>
> + ----- Method: TestCase class>>defaultCategoryForSelector: (in category 'organization') -----<br>
> + defaultCategoryForSelector: aSelector<br>
> +<br>
> + aSelector isTestSelector<br>
> + ifTrue: [^ #testing].<br>
> + ^ super defaultCategoryForSelector: aSelector!<br>
> <br>
> <br>
<br>
> <br>
<br>
<br>
</mailto:commits@source.squeak.org></asqueaker@gmail.com></squeak-dev-bounces@lists.squeakfoundation.org></div>
</blockquote>
</div>
</div>
</div></blockquote></div>