<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Why not just use #ifError: in #calculateKeyArray? Shouldn't inspectors/debuggers be robust in any way?</p>
<p>Ideally, we could use a similar solution to #errorPrintString and display a short red note if the "keys could not be displayed." Imho, this would also a more accurate representation than faking an empty list
<span>when there is actually no list at all.</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont"></font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Donnerstag, 19. Dezember 2019 13:50:39<br>
<b>An:</b> John Pfersich via Squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: Tools-cmm.927.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hmm... #isInitialized feels like an anti pattern that violates the basic "information hiding" principle... Could we rename it to make the special tool use more clear? Maybe #canBeUsedInInspector ?
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 18.12.2019 10:06:54 schrieb Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">
<div>Hi Marcel,</div>
<div>Chris was wanting to step into "constructor" Dictionary new: 4<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Le mer. 18 déc. 2019 à 10:02, Marcel Taeumel <<a href="mailto:marcel.taeumel@hpi.de">marcel.taeumel@hpi.de</a>> a écrit :<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<div id="gmail-m_6083154281778913269__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: rgb(0,0,0)">
Hi Chris,
<div><br>
</div>
<div>I don't think that #isInitialized is necessary. Under which circumstances is a Dictionary or Set not initialized?</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div></div>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px">
<p style="color:rgb(170,170,170);margin-top:10px">Am 17.12.2019 23:15:49 schrieb Chris Muller <<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">This one removes the send to #asArray, it wasn't necessary.</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Dec 17, 2019 at 4:14 PM <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Chris Muller uploaded a new version of Tools to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Tools-cmm.927.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/inbox/Tools-cmm.927.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tools-cmm.927<br>
Author: cmm<br>
Time: 17 December 2019, 4:14:11.72576 pm<br>
UUID: 02595c45-7a56-4481-9038-3bca791d316e<br>
Ancestors: Tools-mt.925<br>
<br>
- Fix debugging of the initialization of Dictionary's.<br>
- Fix the order of entries rendered by inspectors of OrderedDictionary's.<br>
<br>
=============== Diff against Tools-mt.925 ===============<br>
<br>
Item was changed:<br>
----- Method: DictionaryInspector>>calculateKeyArray (in category 'selecting') -----<br>
calculateKeyArray<br>
"Recalculate the KeyArray from the object being inspected"<br>
+ keyArray := object isInitialized<br>
+ ifTrue: [ object keysInOrder ]<br>
+ ifFalse: [ Array empty ].<br>
+ selectionIndex := 0!<br>
- <br>
- keyArray := object keysSortedSafely asArray.<br>
- selectionIndex := 0.<br>
- !<br>
<br>
Item was added:<br>
+ ----- Method: HashedCollection>>isInitialized (in category '*Tools-Debugger') -----<br>
+ isInitialized<br>
+ ^ array notNil and: [ tally notNil ]!<br>
<br>
<br>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
<br>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</body>
</html>