<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Ah ok, the latter was already fixed in <span>Multilingual-nice.249 from the Inbox, nevermind :)</span></p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont"></font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Thiede, Christoph<br>
<b>Gesendet:</b> Samstag, 21. Dezember 2019 17:36:26<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] [BUG] Timestamps don't work for classes with special character names</font>
<div> </div>
</div>
<div>
<div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr">
<p>Hi Tobias,</p>
<p><br>
</p>
<p>what do you mean in detail?</p>
<p><br>
</p>
<p>If I create the class via System Browser and add the method, my change file ends with:</p>
<p><br>
</p>
<p></p>
<div><span style="font-family: Consolas, Courier, monospace; font-size: 10pt;">Object subclass: #CTTéstClass</span></div>
<div><span style="white-space: pre; font-family: Consolas, Courier, monospace; font-size: 10pt;"></span><span style="font-family: Consolas, Courier, monospace; font-size: 10pt;">instanceVariableNames: ''</span></div>
<div><span style="white-space: pre; font-family: Consolas, Courier, monospace; font-size: 10pt;"></span><span style="font-family: Consolas, Courier, monospace; font-size: 10pt;">classVariableNames: ''</span></div>
<div><span style="white-space: pre; font-family: Consolas, Courier, monospace; font-size: 10pt;"></span><span style="font-family: Consolas, Courier, monospace; font-size: 10pt;">poolDictionaries: ''</span></div>
<div><span style="white-space: pre; font-family: Consolas, Courier, monospace; font-size: 10pt;"></span><span style="font-family: Consolas, Courier, monospace; font-size: 10pt;">category: 'CT-Experiments'!</span></div>
<div><span style="font-family: Consolas, Courier, monospace; font-size: 10pt;">!CTTéstClass methodsFor: 'no messages' stamp: 'ct 12/21/2019 17:18'!</span></div>
<div><span style="font-family: Consolas, Courier, monospace; font-size: 10pt;">foo! !</span></div>
<br>
<p></p>
<p>However, CompiledMethod >> #timeStamp returns ''.</p>
<p><br>
</p>
<p>Here is a snapshot of the #timeStamp stackframe:</p>
<p><br>
<img size="366990" contenttype="image/png" id="img116366" style="max-width: 99.9%; user-select: none;" contextid="img863681" tabindex="0" src="cid:9a66cd4b-bad0-4e58-8cad-5ee25223b261"></p>
<p><br>
</p>
<p>Please note that "tokens at: tokenCount" returns the correct timestamp, but however, stamp is nil. What is this???</p>
<p><br>
</p>
<p>I'm not sure if I understand you correctly, but if you told me to search the hex of my change file for a "zero word", the only occurrence I could find is:</p>
<p><img size="11272" contenttype="image/png" id="img853222" style="max-width: 99.9%; user-select: none;" contextid="img327661" tabindex="0" src="cid:cda09063-bcf3-415d-ac79-97bc9aa8642b"><br>
</p>
<p>Which lead me to this:</p>
<p><img size="642514" contenttype="image/png" id="img768015" style="max-width: 99.9%; user-select: none;" contextid="img779266" tabindex="0" src="cid:9f5e7798-1326-4821-a94d-0b7cbfa567d6"><br>
</p>
<p>Does not seem related, but still looks somehow wrong ^^</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<br>
<div style="color: rgb(0, 0, 0);">
<div>
<hr style="display:inline-block; width:98%" tabindex="-1">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Tobias Pape <Das.Linux@gmx.de><br>
<b>Gesendet:</b> Samstag, 21. Dezember 2019 15:44 Uhr<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] [BUG] Timestamps don't work for classes with special character names</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText"><br>
> On 21.12.2019, at 15:16, Thiede, Christoph <Christoph.Thiede@student.hpi.uni-potsdam.de> wrote:<br>
> <br>
> Hi all, found just another bug. If you get tired of them, just tell me :-)<br>
> <br>
> Steps to reproduce:<br>
> Print it:<br>
> class := Object subclass: #CTTèstClass "sic (with accent in name)!"<br>
> instanceVariableNames: ''<br>
> classVariableNames: ''<br>
> poolDictionaries: ''<br>
> category: 'CT-Experiments'.<br>
> class compile: 'foo ^ #foo'.<br>
> (class >> #foo) timeStamp<br>
> <br>
> Expected output:<br>
> Something like 'ct 12/21/2019 15:13'.<br>
> <br>
> Actual output:<br>
> ''.<br>
> <br>
> Please note that everything would have worked fine if we named class #CTTestClass (without accent) instead.<br>
> <br>
> Do we want to support special class names in general? If yes, this is a bug in my opinion. If no, we should raise an error in the first statement.<br>
> <br>
> Cause of infection not yet investigated.<br>
<br>
Please look at your .changes file whether at some point \00 bytes appear.<br>
<br>
Best regards<br>
-Tobias<br>
<br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>