<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Tim,<div><br></div><div>looks good. Would you fix the typo and add #translated calls?</div><div><br></div><div>'Select a preferences file to load' translated</div><div><br></div><div>'There was an error restoring the preferences from file {1}.' translated format: {fname}</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 24.12.2019 20:56:32 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p><div style="font-family:Arial,Helvetica,sans-serif">tim Rowledge uploaded a new version of PreferenceBrowser to project The Inbox:<br>http://source.squeak.org/inbox/PreferenceBrowser-tpr.98.mcz<br><br>==================== Summary ====================<br><br>Name: PreferenceBrowser-tpr.98<br>Author: tpr<br>Time: 24 December 2019, 11:56:24.390074 am<br>UUID: 686fff60-db2c-4f95-a3f4-486b0e3c68db<br>Ancestors: PreferenceBrowser-mt.97<br><br>Possible change to allow users to save preferences to other than the default directory and with names other than 'my.prefs'.<br><br>=============== Diff against PreferenceBrowser-mt.97 ===============<br><br>Item was changed:<br> ----- Method: PreferenceBrowser>>loadFromDiskSelected (in category 'preferences search') -----<br>+ loadFromDiskSelected<br>+ "Ask the user to select a saved preference file to load. If none is chosen then do nothing. If there is an error during the loading inform the user; this may leave the preferences in a messy state as we aren't tracking where the erro ocurred"<br>+ (Project uiManager chooseFileMatching: '*.prefs' label: 'Select a preferences file to load')<br>+ ifNotNil: [:fname | Cursor wait<br>+ showWhile: [[preferences loadPreferencesFrom: fname]<br>+ on: Error<br>+ do: [:ex | self inform: 'there was an error restoring the preferences from ' , fname]]] !<br>- loadFromDiskSelected <br>- <br>- (Project uiManager<br>- confirm: 'Do you really want to restore your\personal preferences from disk?\\The file ''my.prefs'' will be loaded.' translated withCRs<br>- title: 'Restore Preferences from Disk') ifFalse: [^ self].<br>- <br>- preferences restorePreferencesFromDisk!<br><br>Item was changed:<br> ----- Method: PreferenceBrowser>>saveToDiskSelected (in category 'preferences search') -----<br>+ saveToDiskSelected<br>+ "save the current preferences settings to file; the default is 'my.prefs' in the current default directory. Allow the user to choose where they should go"<br>+ (Project uiManager saveFilenameRequest: 'Save prefernces to file' initialAnswer: 'my.prefs')<br>+ ifNotNil: [:fname | Cursor wait<br>+ showWhile: [[preferences storePreferencesIn: fname]<br>+ on: Error<br>+ do: [:ex | self inform: 'there was an error storing your preferences to disk']]]!<br>- saveToDiskSelected <br>- <br>- (Project uiManager<br>- confirm: 'Do you really want to overwrite your\personal preferences on disk?\\The file ''my.prefs'' will be updated.' translated withCRs<br>- title: 'Save Preferences to Disk') ifFalse: [^ self].<br>- <br>- preferences storePreferencesToDisk!<br><br><br></div></blockquote>
</div></body>