<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
+1<div><br></div><div>Could you also update StringTest >> #testFindSelector?</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 27.12.2019 22:30:08 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p><div style="font-family:Arial,Helvetica,sans-serif">Nicolas Cellier uploaded a new version of Collections to project The Inbox:<br>http://source.squeak.org/inbox/Collections-nice.867.mcz<br><br>==================== Summary ====================<br><br>Name: Collections-nice.867<br>Author: nice<br>Time: 27 December 2019, 10:29:53.018596 pm<br>UUID: d3b5ceb3-62ab-4f61-a9a3-dd757041b47f<br>Ancestors: Collections-mt.866<br><br>Fix sendersOfIt for searching senders of an expression including a literal (byte) array<br><br>If you select following text<br><br> preference: 'Send Mouse Wheel Events to Keyboard Focus'<br> categoryList: #(Morphic keyboard mouse)<br> description: 'If enabled, follow the behavior known from Microsoft Windows, where the mouse wheel works for the widget that has the keyboard focus. If disabled, follow the Mac OS style, where the mouse wheel is send to the widget under the mouse position'<br> type: #Boolean<br> <br>and browse senders, then if search for senders of #preference: instead of the whole keyword<br><br>This is because '#(Morphic keyboard mouse)' was replaced with '#aSymbol keyboard mouse)'<br><br>=============== Diff against Collections-mt.866 ===============<br><br>Item was changed:<br> ----- Method: String>>findSelector (in category 'converting') -----<br> findSelector<br> "Dan's code for hunting down selectors with keyword parts; while this doesn't give a true parse, in most cases it does what we want, in where it doesn't, we're none the worse for it."<br> | sel possibleParens |<br> sel := self withBlanksTrimmed.<br> (sel includes: $:)<br> ifTrue:<br> [sel := sel copyWithRegex: '''[^'']*''' matchesReplacedWith: '''a string'''.<br>+ sel := sel copyWithRegex: '#[^\[\(\s\.$]*' matchesReplacedWith: '#aSymbol'.<br>- sel := sel copyWithRegex: '#[^\s\.$]*' matchesReplacedWith: '#aSymbol'.<br> sel := sel copyReplaceAll: ':' with: ': '. "for the style (aa max:bb) with no space"<br> sel := sel copyReplaceAll: '[:' with: '[ :'. "for the style ([:a) with no space" <br> possibleParens := sel substrings.<br> sel := self class streamContents:<br> [:s | | level |<br> level := 0.<br> possibleParens do:<br> [:token |<br> (level = 0 and: [token endsWith: ':'])<br> ifTrue: [s nextPutAll: token]<br> ifFalse: [level := level<br> + (token occurrencesOf: $() - (token occurrencesOf: $))<br> + (token occurrencesOf: $[) - (token occurrencesOf: $])<br> + (token occurrencesOf: ${) - (token occurrencesOf: $})]]]]<br> ifFalse:<br> [sel := self substrings ifNotEmpty: [:tokens | tokens last]].<br> sel ifEmpty: [^ nil].<br> sel first = $# ifTrue:<br> [sel := sel allButFirst.<br> sel ifEmpty: [^ nil]].<br> sel isOctetString ifTrue: [sel := sel asOctetString].<br> ^ Symbol lookup: sel!<br><br><br></div></blockquote>
</div></body>