<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
        {margin-top:0;
        margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>This is small enough to go into 5.3, or do you see any possible issues?</p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont"></font></div>
</div>
</font></div>
</div>
</div>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody"><br>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">Best,</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">Christoph</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Freitag, 10. Januar 2020 21:18:13<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Inbox: Morphic-ct.1616.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Christoph Thiede uploaded a new version of Morphic to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Morphic-ct.1616.mcz">http://source.squeak.org/inbox/Morphic-ct.1616.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-ct.1616<br>
Author: ct<br>
Time: 10 January 2020, 9:18:04.681555 pm<br>
UUID: 9b47b0c2-2b44-9647-9fc0-61b8ebaf053f<br>
Ancestors: Morphic-mt.1615<br>
<br>
Fixes a bug in NewBalloonMorph that leads to permanent flashing when the balloon is very high and does not fit to the left of the balloon.<br>
<br>
Example to reproduce:<br>
<br>
Morph new<br>
        balloonText: 'Squeak is ' , (((1 to: 1000) gather: [:i | 'very ']) as: String) , ' cool';<br>
        position: 10 @ 100;<br>
        openInWorld.<br>
<br>
=============== Diff against Morphic-mt.1615 ===============<br>
<br>
Item was changed:<br>
  ----- Method: NewBalloonMorph>>popUpAt:forHand: (in category 'initialization') -----<br>
  popUpAt: point forHand: aHand<br>
         "Pop up the receiver as balloon help for the given hand"<br>
  <br>
+        #(bottomLeft topLeft bottomRight topRight)<br>
+                detect: [:nextOrientation |<br>
+                        | pointWithOffset |<br>
+                        self orientation: nextOrientation.<br>
+                        pointWithOffset := point + self tailOffset.<br>
+                        self move: pointWithOffset.<br>
+                        self bounds: (self bounds translatedToBeWithin: aHand world bounds).<br>
+                        (self bounds perform: self orientation) = pointWithOffset]<br>
+                ifNone: ["Keep last try."<br>
+                        "Avoid popping up under the cursor - this would make the receiver flash infinitely."<br>
+                        (self bounds containsPoint: aHand position)<br>
+                                ifTrue: [self left: aHand x + 1]].<br>
-        #(bottomLeft topLeft bottomRight topRight) detect: [:nextOrientation |<br>
-                | pointWithOffset |<br>
-                self orientation: nextOrientation.<br>
-                pointWithOffset := point + self tailOffset.<br>
-                self move: pointWithOffset.<br>
-                self bounds: (self bounds translatedToBeWithin: aHand world bounds).<br>
-                (self bounds perform: self orientation) = pointWithOffset] ifNone: ["Keep last try."].<br>
                 <br>
         aHand world addMorphFront: self.<br>
         aHand resetBalloonHelp: self.!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>