<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p></p>
<div><span style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size:16px">1. Sorry to raise this discussion again, but shouldn't this have rather
gone into two separate commits? :-)</span><br>
</div>
<div><br>
</div>
<div>2. > <span style="font-size:12pt">- Fix inescapable modal dialog.</span>
<div><br>
</div>
</div>
<p></p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">Interesting. Can you give an example to reproduce?
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont"></font></div>
</div>
</font></div>
</div>
</div>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody"><br>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">3. > (<span style="font-size:12pt">self font widthOf: $m) * 5</span>
<div><br>
</div>
<div>Why do we hard-code this magic character here? What's so special about $m?</div>
<div><br>
</div>
<div>Best,</div>
<div>Christoph</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Freitag, 17. Januar 2020 03:43:37<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Morphic-cmm.1617.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Chris Muller uploaded a new version of Morphic to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Morphic-cmm.1617.mcz">http://source.squeak.org/trunk/Morphic-cmm.1617.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-cmm.1617<br>
Author: cmm<br>
Time: 10 January 2020, 7:32:31.635312 pm<br>
UUID: ce0033f9-62f5-4c12-9b75-24d613d56c50<br>
Ancestors: Morphic-tpr.1616<br>
<br>
- Fix inescapable modal dialog.<br>
- Fix truncation of the first line of PluggableListMorphs when a font larger than the default is used.<br>
<br>
=============== Diff against Morphic-tpr.1616 ===============<br>
<br>
Item was changed:<br>
----- Method: DialogWindow>>getUserResponse (in category 'running') -----<br>
getUserResponse<br>
<br>
| hand world |<br>
self message ifEmpty: [messageMorph delete]. "Do not waste space."<br>
self paneMorph submorphs<br>
ifEmpty: ["Do not waste space and avoid strange button-row wraps."<br>
self paneMorph delete.<br>
self buttonRowMorph wrapDirection: #none]. <br>
<br>
hand := self currentHand.<br>
world := self currentWorld.<br>
<br>
self fullBounds.<br>
self moveToPreferredPosition.<br>
self openInWorld: world.<br>
<br>
hand showTemporaryCursor: nil. "Since we are out of context, reset the cursor."<br>
<br>
hand keyboardFocus in: [:priorKeyboardFocus |<br>
hand mouseFocus in: [:priorMouseFocus |<br>
self exclusive ifTrue: [hand newMouseFocus: self].<br>
hand newKeyboardFocus: self.<br>
<br>
[[self isInWorld] whileTrue: [world doOneSubCycle]]<br>
ifCurtailed: [self cancelDialog].<br>
<br>
hand newKeyboardFocus: priorKeyboardFocus.<br>
+ hand releaseMouseFocus]].<br>
- hand newMouseFocus: priorMouseFocus]].<br>
<br>
^ result!<br>
<br>
Item was changed:<br>
----- Method: PluggableListMorph>>initialize (in category 'initialization') -----<br>
initialize<br>
- <br>
listMorph := self createListMorph.<br>
super initialize.<br>
- <br>
self scroller<br>
layoutPolicy: TableLayout new;<br>
addMorph: listMorph. <br>
+ self<br>
+ minimumWidth: (self font widthOf: $m) * 5 ;<br>
+ minimumHeight: self font height<br>
<br>
- self minimumWidth: (self font widthOf: $m) * 5.<br>
- <br>
!<br>
<br>
Item was changed:<br>
----- Method: ProportionalSplitterMorph>>topBoundary (in category 'queries - geometry') -----<br>
topBoundary<br>
"Answer the topmost x position the receiver could be moved to."<br>
<br>
| splitter morphs |<br>
splitter := self splitterAbove.<br>
morphs := self commonNeighbours: leftOrTop with: splitter.<br>
- <br>
^ (splitter<br>
ifNil: [owner isSystemWindow ifTrue: [owner panelRect top]<br>
ifFalse: [owner innerBounds top]]<br>
ifNotNil: [splitter bottom])<br>
+ (self minimumHeightOf: morphs)!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>