<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p>> <span style="font-size:12pt">- In case of multiple-keyword messages, don't leave a space at the end of the header line</span></p>
<div><br>
</div>
<p></p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">For illustration: This (though absolutely minor) bug has already affected more than 15 % of all methods in a pure Trunk image.* It is great that so many people use this exciting workflow! :D</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">*Vivide users can convince themselves of this statistic by running (takes a few seconds):
<div></div>
</div>
</div>
</div>
</div>
</div>
</div>
<blockquote style="margin:0 0 0 40px; border:none; padding:0px">
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4">
<div>allMethods := self systemNavigation allMethods.<br>
<span style="font-size: 12pt;">methods := methods select: [:m | m selector isKeyword].<br>
</span><span style="font-size: 12pt;">badMethods := methods select: [:m | m getSource asString lines first last isSeparator].<br>
</span><span style="font-size: 12pt;">badMethods size. "4006"</span></div>
<div><span style="font-size: 12pt;">(badMethods size / methods size) roundTo: 0.01. "0.15"</span></div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4">
<div></div>
<div></div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
:-)</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<br>
</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
Best,</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
Christoph<br>
<br>
<div style="color:rgb(0,0,0)">
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Sonntag, 19. Januar 2020 23:30 Uhr<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Inbox: Tools-ct.933.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt">
<div class="PlainText">Christoph Thiede uploaded a new version of Tools to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Tools-ct.933.mcz" id="LPlnk149372" previewremoved="true">http://source.squeak.org/inbox/Tools-ct.933.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tools-ct.933<br>
Author: ct<br>
Time: 19 January 2020, 11:30:07.448545 pm<br>
UUID: 07b49992-f5e3-f14a-af86-82ed4b35cee6<br>
Ancestors: Tools-mt.929<br>
<br>
Slightly revise stub method generation.<br>
<br>
- In case of multiple-keyword messages, don't leave a space at the end of the header line<br>
- In case of exactly two keywords of the same class, name them 'anObject' and 'anotherObject' rather than numbering them<br>
- Eliminate unwanted 'anUndefinedObject' arguments and replace them with 'anObject' instead<br>
- Refactoring/decomposition<br>
<br>
=============== Diff against Tools-mt.929 ===============<br>
<br>
Item was added:<br>
+ ----- Method: Message>>createStubArguments (in category '*Tools-Debugger') -----<br>
+ createStubArguments<br>
+ <br>
+ | argNames canonicalNames canonicalQuantities |<br>
+ argNames := OrderedCollection new: self arguments size.<br>
+ canonicalNames := self arguments collect: #canonicalArgumentName.<br>
+ canonicalQuantities := canonicalNames asBag valuesAndCounts.<br>
+ canonicalNames withIndexDo: [:canonicalName :index |<br>
+ | argName |<br>
+ argName := canonicalName in: [:name |<br>
+ (name first isVowel ifTrue: ['an'] ifFalse: ['a']), name].<br>
+ (argNames includes: argName) ifTrue: [<br>
+ (canonicalQuantities at: canonicalName) = 2<br>
+ ifTrue: [<br>
+ argName := 'another' , canonicalName]<br>
+ ifFalse: [<br>
+ [argNames includes: argName]<br>
+ whileTrue: [argName := argName , index]]].<br>
+ argNames add: argName].<br>
+ ^ argNames!<br>
<br>
Item was changed:<br>
----- Method: Message>>createStubMethod (in category '*Tools-Debugger') -----<br>
createStubMethod<br>
+ <br>
| argNames |<br>
argNames := Set new.<br>
+ ^ String streamContents: [ :stream |<br>
+ self printStubPatternOn: stream.<br>
+ stream<br>
+ crtab;<br>
+ nextPutAll: '^ self shouldBeImplemented' ]!<br>
- ^ String streamContents: [ :s |<br>
- self selector keywords doWithIndex: [ :key :i |<br>
- | aOrAn argName arg argClassName |<br>
- s nextPutAll: key.<br>
- ((key last = $:) or: [self selector isInfix]) ifTrue: [<br>
- arg := self arguments at: i.<br>
- argClassName := arg canonicalArgumentName.<br>
- aOrAn := argClassName first isVowel ifTrue: ['an'] ifFalse: ['a'].<br>
- argName := aOrAn, argClassName.<br>
- [argNames includes: argName] whileTrue: [argName := argName, i asString].<br>
- argNames add: argName.<br>
- s nextPutAll: ' '; nextPutAll: argName; space<br>
- ].<br>
- ].<br>
- s cr; tab.<br>
- s nextPutAll: 'self shouldBeImplemented'<br>
- ].!<br>
<br>
Item was added:<br>
+ ----- Method: Message>>printStubPatternOn: (in category '*Tools-Debugger') -----<br>
+ printStubPatternOn: aStream<br>
+ <br>
+ | arguments |<br>
+ self selector isUnary<br>
+ ifTrue: [^ aStream nextPutAll: self selector].<br>
+ arguments := self createStubArguments.<br>
+ self selector keywords with: arguments do: [:key :argName |<br>
+ aStream<br>
+ nextPutAll: key;<br>
+ space;<br>
+ nextPutAll: argName;<br>
+ space].<br>
+ aStream skip: -1.!<br>
<br>
Item was added:<br>
+ ----- Method: UndefinedObject>>canonicalArgumentName (in category '*Tools-Debugger') -----<br>
+ canonicalArgumentName<br>
+ "It is never useful to expect nil as an argument"<br>
+ ^ self class superclass name!<br>
<br>
<br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>