<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Wow, thanks for the fast fix and explanation! :-)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Eliot Miranda <eliot.miranda@gmail.com><br>
<b>Gesendet:</b> Sonntag, 19. Januar 2020 02:41:23<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] [BUG] Compiler Bug: Code generation with cascade and #caseOf: fails</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi Christoph,</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat, Jan 18, 2020 at 12:10 PM Thiede, Christoph <<a href="mailto:Christoph.Thiede@student.hpi.uni-potsdam.de">Christoph.Thiede@student.hpi.uni-potsdam.de</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div id="gmail-m_6290639382527216870divtagdefaultwrapper" dir="ltr" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p><b>Steps to reproduce:</b></p>
<p>Do it:</p>
<blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px">
<p>Object compile: '</p>
<p></p>
<div>foo: anObject</div>
<p></p>
<p></p>
<div><span style="white-space:pre-wrap"></span>^ self foo</div>
<p></p>
<p></p>
<div><span style="white-space:pre-wrap"></span> flag: #bar;</div>
<p></p>
<p></p>
<div><span style="white-space:pre-wrap"></span> caseOf: { [#corge] -> [self grault: anObject] }</div>
<p></p>
<p></p>
<div>'</div>
<p></p>
</blockquote>
<p></p>
<p><br>
</p>
<p><b style="font-size:12pt">Error:</b><br>
</p>
<p><span style="font-size:12pt">In TempVariableNode >> #isReferencedWithinBlockExtent:: MessageNotUnderstood: UndefinedObject >> #rangleIncludes:.</span></p>
<p><span style="font-size:12pt">anInterval is nil.</span></p>
<p><span style="font-size:12pt">In #<span>computeCopiedValues:, </span>blockExtent of the BlockNode <span>{[#corge]} is nil.</span></span></p>
<p><span style="font-size:12pt"><span><br>
</span></span></p>
<p><span style="font-size:12pt"><span><span style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size:16px">This may be related to the </span><span style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size:16px">observation
made in </span><a href="http://forum.world.st/BUG-Cannot-compile-cascade-sent-to-block-td5108942.html" id="gmail-m_6290639382527216870LPlnk553879" style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size:16px" target="_blank">http://forum.world.st/BUG-Cannot-compile-cascade-sent-to-block-td5108942.html</a><span style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size:16px"> that
blockExtent can be nil.</span><br>
</span></span></p>
<p><span style="font-size:12pt"><span>Maybe we should handle optimized BlockNodes differently in this method?</span></span></p>
<p>Not (yet?) further investigated.</p>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>I see a contradiction. The cascaded message "caseOf: { [#corge] -> [self grault: anObject]" has special = 0, which means it hasn't been optimized. But both of its blocks are marked as being optimized. We can't have that discrepancy. Ether a cascaded
caseOf: is (to be) inlined (special > 0) and its blocks are optimized, or it is not to be inlined and its blocks are not to be optimized.</div>
<div><br>
</div>
<div>Ah, the bug I believe is this:</div>
<div><br>
</div>
<div>
<div>ensureCanCascade: encoder</div>
<div><span class="gmail-Apple-tab-span" style="white-space:pre"></span>special > 0 ifTrue:</div>
<div><span class="gmail-Apple-tab-span" style="white-space:pre"></span>[special := 0.</div>
<div><span class="gmail-Apple-tab-span" style="white-space:pre"></span>receiver := originalReceiver.</div>
<div><span class="gmail-Apple-tab-span" style="white-space:pre"></span>selector := encoder encodeSelector: originalSelector.</div>
<div><span class="gmail-Apple-tab-span" style="white-space:pre"></span>arguments := originalArguments.</div>
<div><span class="gmail-Apple-tab-span" style="white-space:pre"></span>receiver isBlockNode ifTrue: [receiver deoptimize].</div>
<div><span class="gmail-Apple-tab-span" style="white-space:pre"></span>arguments do:</div>
<div><span class="gmail-Apple-tab-span" style="white-space:pre"></span>[:each|</div>
<div><span class="gmail-Apple-tab-span" style="white-space:pre"></span>each isBlockNode ifTrue:</div>
<div><span class="gmail-Apple-tab-span" style="white-space:pre"></span>[each deoptimize]]]</div>
</div>
<div><br>
</div>
<div>This assumes that optimized blocks only appear as arguments, not also in BraceNode elements, as they do in case statements.</div>
<div>Fixed in Compiler-eem.416<br>
</div>
<div><br>
</div>
<div>_,,,^..^,,,_<br>
</div>
</div>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div><span style="font-size:small;border-collapse:separate">
<div>best, Eliot</div>
</span></div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>