<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Marcel, can you give an example where the #fixIntervalCache workaround in the former #printIt implementation is needed? :)</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Mittwoch, 22. Januar 2020 10:19:00<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Inbox: Morphic-ct.1619.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Christoph Thiede uploaded a new version of Morphic to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Morphic-ct.1619.mcz">http://source.squeak.org/inbox/Morphic-ct.1619.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-ct.1619<br>
Author: ct<br>
Time: 22 January 2020, 10:18:49.982972 am<br>
UUID: 7857d3bc-414b-cf4a-87bd-9d0aae05616f<br>
Ancestors: Morphic-cmm.1618<br>
<br>
Proposal: Unify all doIt related operations in PluggableTextMorph by delegating them to the editor.<br>
<br>
This also fixes the fact that certain hooks such as #printIt:result:, #inspectIt:result:, or #exploreIt:result: were ignored when triggering the operation via the textmorph menu instead of shortcut. This is not an expected behavior, is it?<br>
<br>
=============== Diff against Morphic-cmm.1618 ===============<br>
<br>
Item was changed:<br>
----- Method: PluggableTextMorph>>doIt (in category 'menu commands') -----<br>
doIt<br>
+ ^ self handleEdit: [textMorph editor doIt]!<br>
- ^self handleEdit: [textMorph editor evaluateSelection]!<br>
<br>
Item was changed:<br>
----- Method: PluggableTextMorph>>exploreIt (in category 'menu commands') -----<br>
exploreIt<br>
+ ^ self handleEdit: [textMorph editor exploreIt]!<br>
- <br>
- <br>
- self handleEdit:<br>
- [textMorph editor evaluateSelectionAndDo: [:result | result explore]].!<br>
<br>
Item was changed:<br>
----- Method: PluggableTextMorph>>inspectIt (in category 'menu commands') -----<br>
inspectIt<br>
+ ^ self handleEdit: [textMorph editor inspectIt]!<br>
- <br>
- self handleEdit:<br>
- [textMorph editor evaluateSelectionAndDo: [:result | result inspect]]!<br>
<br>
Item was changed:<br>
----- Method: PluggableTextMorph>>printIt (in category 'menu commands') -----<br>
printIt<br>
+ ^ self handleEdit: [textMorph editor printIt]!<br>
- | oldEditor |<br>
- textMorph editor selectFrom: selectionInterval first to: selectionInterval last;<br>
- model: model. "For, eg, evaluateSelection"<br>
- textMorph handleEdit: [(oldEditor := textMorph editor) evaluateSelectionAndDo:<br>
- [:result |<br>
- self flag: #fixIntervalCache. "mt: We should find a better design for discarding unused text editors in text morphs and restoring them on demand."<br>
- selectionInterval := oldEditor markIndex to: oldEditor pointIndex -1.<br>
- textMorph installEditorToReplace: oldEditor.<br>
- textMorph handleEdit: [oldEditor afterSelectionInsertAndSelect: result printString].<br>
- selectionInterval := oldEditor markIndex to: oldEditor pointIndex -1.<br>
- <br>
- textMorph editor selectFrom: selectionInterval first to: selectionInterval last.<br>
- self scrollSelectionIntoView]]!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>