<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hm, it would be also nice if the menu items could implement #applyUserInterfaceTheme properly ...</p>
<p><br>
</p>
<p><img size="41191" contenttype="image/png" id="img309290" style="max-width: 99.9%; user-select: none;" contextid="img4498" tabindex="0" src="cid:4fcba34b-f7f4-4a6a-8ebb-3f530a222200"><br>
</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">By the way: The indent of labels next to symbols is hard-coded and not the same for icons and markers (see MenuItemMorph >> <span>drawLabelOn:)</span>. We currently don't have any mechanism for centering all icons
 horizontally and all labels to the left, do we?</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">Best,</div>
<div class="_rp_T4" id="Item.MessagePartBody">Christoph</div>
</div>
</div>
</div>
<br>
<div style="color: rgb(0, 0, 0);">
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Montag, 17. Februar 2020 16:18 Uhr<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Morphic-mt.1624.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Marcel Taeumel uploaded a new version of Morphic to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Morphic-mt.1624.mcz" id="LPlnk842709" previewremoved="true">http://source.squeak.org/trunk/Morphic-mt.1624.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-mt.1624<br>
Author: mt<br>
Time: 17 February 2020, 4:18:38.814347 pm<br>
UUID: 9aec0d72-c81c-6041-9bd4-8c1826a49d65<br>
Ancestors: Morphic-mt.1623<br>
<br>
Fixes three (hi-dpi / demo mode) scaling issues:<br>
(1) selected icon in docking bars<br>
(2) box replacement in windows (thanks to Christoph (ct)!)<br>
(3) full-screen icon in world main docking bar.<br>
<br>
=============== Diff against Morphic-mt.1623 ===============<br>
<br>
Item was changed:<br>
  ----- Method: DockingBarItemMorph>>selectedIcon: (in category 'accessing') -----<br>
+ selectedIcon: aFormOrNil<br>
- selectedIcon: aForm<br>
  <br>
+        selectedIcon := aFormOrNil<br>
+                ifNotNil: [:form | form scaleIconToDisplay].!<br>
-        selectedIcon := aForm!<br>
<br>
Item was changed:<br>
  ----- Method: SystemWindow>>applyUserInterfaceTheme (in category 'user interface') -----<br>
  applyUserInterfaceTheme<br>
  <br>
         super applyUserInterfaceTheme.<br>
         <br>
         self<br>
                 setDefaultParameters;<br>
+                replaceBoxes;<br>
                 refreshWindowColor.<br>
  <br>
         self isLookingFocused<br>
                 ifTrue: [self lookUnfocused; lookFocused]<br>
                 ifFalse: [self lookFocused; lookUnfocused].<br>
                 <br>
         self isCollapsed ifTrue: [self setProperty: #applyTheme toValue: true].!<br>
<br>
Item was changed:<br>
  ----- Method: TheWorldMainDockingBar>>toggleFullScreenOn: (in category 'right side') -----<br>
  toggleFullScreenOn: aDockingBar <br>
         <br>
         | toggleMorph onIcon offIcon box bgColor |<br>
+        offIcon := (MenuIcons fullscreenWireframeIcon dyed:<br>
+                                        (self userInterfaceTheme logoColor ifNil: [Color black])) scaleIconToDisplay.<br>
+        onIcon := (MenuIcons fullscreenWireframeIcon dyed:<br>
+                                        (self userInterfaceTheme selectionLogoColor ifNil: [Color white])) scaleIconToDisplay.<br>
-        offIcon := MenuIcons fullscreenWireframeIcon dyed:<br>
-                                        (self userInterfaceTheme logoColor ifNil: [Color black]).<br>
-        onIcon := MenuIcons fullscreenWireframeIcon dyed:<br>
-                                        (self userInterfaceTheme selectionLogoColor ifNil: [Color white]).<br>
         bgColor := (UserInterfaceTheme current get: #selectionColor for: #DockingBarItemMorph) ifNil: [Color blue].<br>
         <br>
         toggleMorph := offIcon asMorph.<br>
         <br>
         box := Morph new<br>
                 color: Color transparent;<br>
                 hResizing: #shrinkWrap;<br>
                 vResizing: #spaceFill;<br>
                 listCentering: #center;<br>
                 width: toggleMorph width;<br>
                 changeTableLayout;<br>
                 <br>
                 borderWidth: 1;<br>
                 borderColor: Color transparent;<br>
                 balloonText: 'toggle full screen mode' translated;<br>
                 addMorph: toggleMorph.<br>
                 <br>
         toggleMorph setToAdhereToEdge: #rightCenter. <br>
                 <br>
         box<br>
                 on: #mouseUp<br>
                 send: #value<br>
                 to:<br>
                         [ DisplayScreen toggleFullScreen. <br>
                         "toggleMorph image: MenuIcons smallFullscreenOffIcon" ] ;<br>
  <br>
                 on: #mouseEnter<br>
                 send: #value<br>
                 to: [<br>
                         toggleMorph image: onIcon.<br>
                         box color: bgColor; borderColor: bgColor];<br>
                 <br>
                 on: #mouseLeave<br>
                 send: #value<br>
                 to: [<br>
                         toggleMorph image: offIcon.<br>
                         box color: Color transparent; borderColor: Color transparent].<br>
                                 <br>
         aDockingBar addMorphBack: box!<br>
<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>