<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>great work! Thanks for the fix and the feedback.</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Dienstag, 18. Februar 2020 14:53:57<br>
<b>An:</b> John Pfersich via Squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: Morphic-ct.1625.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
And you chose #mouseFocus:, which is not the public interface to use. Take a look at senders of #mouseFocus: vs. #newMouseFocus: :-)
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 18.02.2020 14:52:04 schrieb Marcel Taeumel <marcel.taeumel@hpi.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
<div>Hi Christoph.</div>
<div><br>
</div>
Addressed in Morphic-mt.1625.
<div><br>
</div>
<div>Note that "h owner" is dangerous because that can be anything you are not in control in this piece of code. Also, the focus holder was correct for this scenario. That's why I suspected the bug to be somewhere else and started debugging. Took me about 3
hours. -.-" It was related to mouse-over dispatching, which affects mouse-enter and mouse-leave events, which trigger the halo.
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 17.02.2020 17:11:38 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">Christoph Thiede uploaded a new version of Morphic to project The Inbox:<br>
http://source.squeak.org/inbox/Morphic-ct.1625.mcz<br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-ct.1625<br>
Author: ct<br>
Time: 17 February 2020, 5:11:24.527432 pm<br>
UUID: e4c9f15a-c480-d542-9ad3-20490c73e5f1<br>
Ancestors: Morphic-mt.1623<br>
<br>
Fixes broken balloon helps on halo handles<br>
<br>
Please review.<br>
<br>
=============== Diff against Morphic-mt.1623 ===============<br>
<br>
Item was changed:<br>
----- Method: Morph>>invokeHaloOrMove: (in category 'meta-actions') -----<br>
invokeHaloOrMove: anEvent<br>
"Special gestures (cmd-mouse on the Macintosh; Alt-mouse on Windows and Unix) allow a mouse-sensitive morph to be moved or bring up a halo for the morph."<br>
| h tfm doNotDrag |<br>
h := anEvent hand halo.<br>
"Prevent wrap around halo transfers originating from throwing the event back in"<br>
doNotDrag := false.<br>
h ifNotNil:[<br>
(h innerTarget == self) ifTrue:[doNotDrag := true].<br>
(h innerTarget hasOwner: self) ifTrue:[doNotDrag := true].<br>
(self hasOwner: h target) ifTrue:[doNotDrag := true]].<br>
<br>
tfm := (self transformedFrom: nil) inverseTransformation.<br>
<br>
"cmd-drag on flexed morphs works better this way"<br>
h := self addHalo: (anEvent transformedBy: tfm).<br>
h ifNil: [^ self].<br>
doNotDrag ifTrue:[^self].<br>
"Initiate drag transition if requested"<br>
anEvent hand <br>
waitForClicksOrDrag: h<br>
event: (anEvent transformedBy: tfm)<br>
selectors: { nil. nil. nil. #startDragTarget:. }<br>
threshold: HandMorph dragThreshold.<br>
"Pass focus explicitly here"<br>
+ anEvent hand mouseFocus: h owner.<br>
- anEvent hand newMouseFocus: h.<br>
"Reset temporary cursors to make available halo interaction visible."<br>
anEvent hand showTemporaryCursor: nil.!<br>
<br>
<br>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</body>
</html>