<div dir="ltr"><div>Hi Marcel,</div><div><br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067__MailbirdStyleContent" style="font-size:10pt;font-family:Arial;color:rgb(0,0,0)"><div>> <span style="font-family:Arial,Helvetica,sans-serif;font-size:13px">especially for this one tiny little thing of a modal alert when renaming classes?</span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px">It is a more general issue. There should be no UI invocation code in a non-UI part of the system. So, "Transcript showln:." is fine but "self inform:" is not. Why? Because those cannot be trapped in scripts, which is - for example - unfortunate in automated pipelines such as our CI.</span></div></div></blockquote><div><br></div><div>Actually, they can.</div><div><br></div><div> "example 1"</div><div> [ self inform: 'stop everything and pay attention to me!' ] on: ProvideAnswerNotification do: [ : noti | noti resume ] "nil"</div><div><br></div><div> "example 2"</div><div> [UIManager default request: 'what is the answer?' initialAnswer: 'tell me now!' ] on: ProvideAnswerNotification do: [ : noti | noti resume: 42 ] "42 "<br></div><div><br></div><div>I assumed this is what the CI jobs were doing.. they're not?</div><div><br></div><div>I totally share your sentiments about no UI invocation code in the domain, and is how I do my own designs, of course, but Squeak chose default to being an <<interactive system>>, and requires handlers of ProvideAnswerNotification to make it non-interactive, rather than the other way around.</div><div><br></div><div>If you want to flip the above in 5.4 to the normal way -- signaling a kind of ProvideAnswerNotification whose defaultAction issues the modal popup -- then let's flip them, but it doesn't seem like we need a new layer of notification classes just yet. ProvideAnswerNotification may be sufficient.</div><div><br></div><div>Best,</div><div> Chris</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067__MailbirdStyleContent" style="font-size:10pt;font-family:Arial;color:rgb(0,0,0)"><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px">> </span><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px">What happened to simply opening up a MessageSet on the references afterward?</span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px">Still there. Unrelated to this issue. See the end of Browser >> #renameClass.</span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px">> </span><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px">Say, why do we need a modal alert at all?</span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px">I agree, that extra check in Class >> #rename: might not be necessary and maybe moved to our refactoring tools.</span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px">Best,</span></div><div><span style="font-family:Arial,Helvetica,sans-serif;font-size:13px">Marcel</span></div><div style="font-family:Arial,Helvetica,sans-serif;font-size:13px"></div><div></div>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px;min-width:500px">
<p style="color:rgb(170,170,170);margin-top:10px">Am 26.02.2020 00:21:48 schrieb Chris Muller <<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr"><div>-1. "Notice" is such a generic, common word to steal from all applications that might want to create their own, especially for this one tiny little thing of a modal alert when renaming classes? Say, why do we need a modal alert at all? What happened to simply opening up a MessageSet on the references afterward?</div><div></div><div><br></div><div> - Chris</div><div><br></div><div><br></div><div><br></div><div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 25, 2020 at 8:17 AM Marcel Taeumel <<a href="mailto:marcel.taeumel@hpi.de" target="_blank">marcel.taeumel@hpi.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex;min-width:500px"><div><div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948__MailbirdStyleContent" style="font-size:10pt;font-family:Arial;color:rgb(0,0,0)">
Just "Notice"?<div></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px;min-width:500px">
<p style="color:rgb(170,170,170);margin-top:10px">Am 25.02.2020 12:11:33 schrieb Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>>:</p><div style="font-family:Arial,Helvetica,sans-serif"><div dir="ltr"><br></div><div dir="ltr"><br><blockquote type="cite" style="min-width:500px">On Feb 25, 2020, at 1:40 AM, Marcel Taeumel <<a href="mailto:marcel.taeumel@hpi.de" target="_blank">marcel.taeumel@hpi.de</a>> wrote:<br><br></blockquote></div><blockquote type="cite" style="min-width:500px"><div dir="ltr"><div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948__MailbirdStyleContent" style="font-size:10pt;font-family:Arial;color:rgb(0,0,0)">
Fixed. BUT: Please take a look at<div><br></div><div>Kernel-mt.1305<br></div><div>Tools-mt.941<br></div><div><br></div><div>We need a name! :-)</div></div></div></blockquote><div><br></div>On second thoughts Notice might be a better name.<div><br><blockquote type="cite" style="min-width:500px"><div dir="ltr"><div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948__MailbirdStyleContent" style="font-size:10pt;font-family:Arial;color:rgb(0,0,0)"><div><br></div><div>Best,</div><div>Marcel</div><div></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px;min-width:500px">
<p style="color:rgb(170,170,170);margin-top:10px">Am 25.02.2020 10:11:22 schrieb Marcel Taeumel <<a href="mailto:marcel.taeumel@hpi.de" target="_blank">marcel.taeumel@hpi.de</a>>:</p><div style="font-family:Arial,Helvetica,sans-serif"><div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948__MailbirdStyleContent" style="font-size:10pt;font-family:Arial;color:rgb(0,0,0)">
> <span style="font-family:Calibri,Helvetica,sans-serif;font-size:16px">Maybe it is a sporadic issue?</span><div><span style="font-family:Calibri,Helvetica,sans-serif;font-size:16px"><br></span></div><div><span style="font-family:Calibri,Helvetica,sans-serif;font-size:16px">It is! Related to the ProgressNotification which I accidentially catch in Browser >> #renameClass. I wanted to get the UI call out of Class >> #rename:.</span></div><div><span style="font-family:Calibri,Helvetica,sans-serif;font-size:16px"><br></span></div><div><span style="font-family:Calibri,Helvetica,sans-serif;font-size:16px">That progress notification does not appear every time. Only above a certain threshold. That's why it appears to be sporadic.</span></div><div><span style="font-family:Calibri,Helvetica,sans-serif;font-size:16px"><br></span></div><div><span style="font-family:Calibri,Helvetica,sans-serif;font-size:16px">Best,</span></div><div><span style="font-family:Calibri,Helvetica,sans-serif;font-size:16px">Marcel</span></div><div></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px;min-width:500px">
<p style="color:rgb(170,170,170);margin-top:10px">Am 25.02.2020 09:37:13 schrieb Thiede, Christoph <<a href="mailto:christoph.thiede@student.hpi.uni-potsdam.de" target="_blank">christoph.thiede@student.hpi.uni-potsdam.de</a>>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948divtagdefaultwrapper" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif" dir="ltr">
<p>I could reproduce it one single time ... Maybe it is a sporadic issue?</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948Signature">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948divtagdefaultwrapper" dir="ltr" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="divtagdefaultwrapper">
<div>
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948Item.MessagePartBody">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948divtagdefaultwrapper"><span style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948Signature">
<div style="margin:0px"><span>
<div><span style="font-size:12pt;color:black"><span style="font-size:12pt"><a href="http://www.hpi.de/" rel="noopener noreferrer" id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948LPNoLP" target="_blank"><span style="font-size:10pt"><span id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948LPlnk909538"><font color="#757B80"></font></span></span></a></span></span></div>
</span></div>
</div>
</span></div>
</div>
</div>
</div>
</div>
<div><span style="font-size:10pt;color:rgb(128,128,128)"></span></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948divRplyFwdMsg" dir="ltr"><span style="font-family:Calibri,sans-serif;color:rgb(0,0,0)"><b>Von:</b> Squeak-dev <<a href="mailto:squeak-dev-bounces@lists.squeakfoundation.org" target="_blank">squeak-dev-bounces@lists.squeakfoundation.org</a>> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Dienstag, 25. Februar 2020 09:34:03<br>
<b>An:</b> John Pfersich via Squeak-dev; Chris Muller<br>
<b>Betreff:</b> Re: [squeak-dev] 5.3 cannot rename subclasses of Error</span>
<div> </div>
</div>
<div>
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948__MailbirdStyleContent" style="font-size:10pt;font-family:Arial;color:rgb(0,0,0)">
Hmm... I can reproduce the bug. Yet, calling "Error2 rename: #Error1" from a workspace works fine. Strange.
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div></div>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px;min-width:500px">
<p style="color:rgb(170,170,170);margin-top:10px">Am 25.02.2020 09:16:13 schrieb Thiede, Christoph <<a href="mailto:christoph.thiede@student.hpi.uni-potsdam.de" target="_blank">christoph.thiede@student.hpi.uni-potsdam.de</a>>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948divtagdefaultwrapper" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif" dir="ltr">
<p>Hi Chris,</p>
<p><br>
</p>
<p>in a fresh image, I cannot reproduce this. Are you sure the class has not been renamed or is it possible that the class list was not updated properly?</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948Signature">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948divtagdefaultwrapper" dir="ltr" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="divtagdefaultwrapper">
<div>
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948Item.MessagePartBody">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948divtagdefaultwrapper"><span style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948Signature">
<div style="margin:0px"><span>
<div><span style="font-size:12pt;color:black"><span style="font-size:12pt"><a href="http://www.hpi.de/" rel="noopener noreferrer" id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948LPNoLP" target="_blank"><span style="font-size:10pt"><span id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948LPlnk909538"><span style="color:rgb(117,123,128)"></span></span></span></a></span></span></div>
</span></div>
</div>
</span></div>
</div>
</div>
</div>
</div>
<div><span style="font-size:10pt;color:rgb(128,128,128)"></span></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%">
<div id="m_-1379859491229468369m_-40465228002448309gmail-m_-3947542674905690067m_5862657086341151352m_-3449357215696720334m_-3164436261442328885gmail-m_-1850168237517145948divRplyFwdMsg" dir="ltr"><span style="font-family:Calibri,sans-serif;color:rgb(0,0,0)"><b>Von:</b> Squeak-dev <<a href="mailto:squeak-dev-bounces@lists.squeakfoundation.org" target="_blank">squeak-dev-bounces@lists.squeakfoundation.org</a>> im Auftrag von Chris Muller <<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>><br>
<b>Gesendet:</b> Dienstag, 25. Februar 2020 06:29:00<br>
<b>An:</b> squeak dev<br>
<b>Betreff:</b> [squeak-dev] 5.3 cannot rename subclasses of Error</span>
<div> </div>
</div>
<div>
<div dir="ltr">
<div>In trunk / 5.3 RC.<br>
</div>
<div><br>
</div>
<div> - Make a subclass of Error called MyError1<br>
</div>
<div> - Make a subclass of Error called MyError2</div>
<div> - Delete MyError1</div>
<div> - Try to rename MyError2 to MyError1</div>
<div><br>
</div>
<div>The last step fails. No errors or debuggers, but the class is not renamed.</div>
<div><br>
</div>
<div>Works in 5.2.</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div></blockquote>
</div></div></blockquote>
</div><span></span><br></div></blockquote></div></div></blockquote>
</div></div><br>
</blockquote></div></div>
</div></blockquote></div><br>
</blockquote></div></div>