<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Levente,<div><br></div><div>hmm... but WeakSet does also not respond correctly to #isEmpty. Yes, there is a bug with tally calculation as you descrined. However, all weak collections can only support #maybeNotEmpty and never #isEmpty (because of the false case).</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 26.02.2020 14:54:46 schrieb Levente Uzonyi <leves@caesar.elte.hu>:</p><div style="font-family:Arial,Helvetica,sans-serif">Hi Marcel,<br><br>The cause of the problem is that unlike other weak hashed collections, <br>WeakIdentityDictionary does not recalculate tally in <br>#noCheckNoGrowFillFrom:. And that's a bug, because it lets tally increase <br>indefinitely.<br><br>The bug appears now, because before Undeclared became a <br>WeakIdentityDictionary, #compact, which is part of what ReleaseBuilder <br>does, would recalculate the tally via #noCheckNoGrowFillFrom:.<br><br>So, even for weak hashed collections, tally should never be larger than <br>the actual capacity (not #capacity, which currently implemented as array <br>size is a misnomer) of the collection.<br><br><br>Levente<br><br>On Wed, 26 Feb 2020, marcel.taeumel wrote:<br><br>> Maybe weak collections should never claim to be empty anymore after any<br>> element was added to them? I would understand that since repeated calls can<br>> return different results.<br>><br>> Best,<br>> Marcel<br>><br>><br>><br>> --<br>> Sent from: http://forum.world.st/Squeak-Dev-f45488.html<br><br></div></blockquote>
</div></body>