<div dir="ltr"><div>Hi all,<br></div><div>Note that I did execute the snippet so as to check that it worked, but then thought a good idea to add a comment...</div><div>So yes, syntactic color would have helped me see my typo!</div><div><br></div><div>Concerning StringHolder, well the name is certainly misleading.</div><div>We want to be able to write and test code from everywhere, so that's the reason why it behaves much like a code holder...</div><div>I don't think that it is a good idea to strip this behavior, it is an essential feature.<br></div><div><br></div><div>CodeHolder has more properties related to hosting methods (not just snippets) like inserting a breakpoint or considering method category (protocol).</div><div>MethodHolder seems something used exclusively by EToys, I didn't even know about its existence until now ...</div><div><br></div><div>For MC, having a CodeHolder with style seems like the most elementary thing to do.</div><div>We can eventually be pedantic and try to compile and validate the snippet upon accept, but I see no need to store resulting compiledMethod.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le sam. 7 mars 2020 à 14:26, Thiede, Christoph <<a href="mailto:Christoph.Thiede@student.hpi.uni-potsdam.de">Christoph.Thiede@student.hpi.uni-potsdam.de</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<div id="gmail-m_-918695404049963150divtagdefaultwrapper" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif" dir="ltr">
<p>Interesting idea. We could simply change the underlying representation of PackageInfo ('<span>preamble postscript preambleOfRemoval postscriptOfRemoval</span>') to hold CompiledMethods rather than StringHolders and rewrite the accessors to use Compiler and
#sourceText. However, then we could not use interactive compilation (no requestor). Hm, or could we maybe simply store instances of CodeHolder? This could also solve our problem that <span><a href="http://forum.world.st/Monticello-Load-Scripts-are-not-styled-td5109840.html" target="_blank">Monticello
Load Scripts are not styled</a>.</span></p>
<p><span><br>
</span></p>
<p><span>Speaking in general, should we maybe revise the existing StringHolder, CodeHolder, MethodHolder hierarchy? A very large part of the StringHolder implementation actually describes code-specific things. MethodHolder, on the other hand, is located in
Tools but its only three users are located in EToys. IMHO, an ideal StringHolder would not contain any code-related stuff, not even #buildCodePaneWith:. Or am I basically describing the behavior of a ValueHolder? In this case, the name of StringHolder is quite
confusing.</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="gmail-m_-918695404049963150Signature">
<div id="gmail-m_-918695404049963150divtagdefaultwrapper" dir="ltr" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="divtagdefaultwrapper">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%">
<div id="gmail-m_-918695404049963150divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>Von:</b> Squeak-dev <<a href="mailto:squeak-dev-bounces@lists.squeakfoundation.org" target="_blank">squeak-dev-bounces@lists.squeakfoundation.org</a>> im Auftrag von Jakob Reschke <<a href="mailto:forums.jakob@resfarm.de" target="_blank">forums.jakob@resfarm.de</a>><br>
<b>Gesendet:</b> Samstag, 7. März 2020 10:02:35<br>
<b>An:</b> <a href="mailto:squeak-dev@lists.squeakfoundation.org" target="_blank">squeak-dev@lists.squeakfoundation.org</a><br>
<b>Betreff:</b> [squeak-dev] Prevent syntax errors in preamble/postscript</font>
<div> </div>
</div>
<div>
<div dir="auto">Hello,
<div dir="auto"><br>
</div>
<div dir="auto">Thank you Nicolas for fixing this error so quickly.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Would it be possible to compile, but not evaluate those scripts automatically when they are saved? Or does something speak against it? It should prevent syntax errors.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Kind regards,</div>
<div dir="auto">Jakob</div>
<br>
<br>
<div class="gmail_quote" dir="auto">
<div dir="ltr" class="gmail_attr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>> schrieb am Sa., 7. März 2020, 01:17:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Nicolas Cellier uploaded a new version of Morphic to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Morphic-nice.1637.mcz" rel="noreferrer noreferrer" target="_blank">http://source.squeak.org/trunk/Morphic-nice.1637.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-nice.1637<br>
Author: nice<br>
Time: 7 March 2020, 1:16:54.439713 am<br>
UUID: 52276ad2-7bef-40fd-a762-6309da355518<br>
Ancestors: Morphic-nice.1636<br>
<br>
Fix broken postscript, apologies<br>
<br>
=============== Diff against Morphic-nice.1636 ===============<br>
<br>
Item was changed:<br>
+ (PackageInfo named: 'Morphic') postscript: '"Set a smoother scrolling, especially useful for trackpads"<br>
- (PackageInfo named: 'Morphic') postscript: '''Set a smoother scrolling, especially useful for trackpads"<br>
HandMorph minimumWheelDelta: 20.<br>
Smalltalk sendMouseWheelEvents: true.'!<br>
<br>
<br>
</blockquote>
</div>
</div>
</div>
</div>
<br>
</blockquote></div>