<div dir="auto">+1<div dir="auto">I wanted to do this. Especially annoying in SpurVMMaker.image</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le mar. 10 mars 2020 à 23:54, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Eliot Miranda uploaded a new version of EToys to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/EToys-eem.387.mcz" rel="noreferrer noreferrer" target="_blank">http://source.squeak.org/trunk/EToys-eem.387.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: EToys-eem.387<br>
Author: eem<br>
Time: 10 March 2020, 3:53:06.048241 pm<br>
UUID: 12d7f0bc-32f7-47d5-9d3b-d1f01f874f09<br>
Ancestors: EToys-mt.386<br>
<br>
Eliminate some underscore assignments which throw up unexpected errors on recompilation if one has the preference to allow underscore assignments turned off.<br>
<br>
=============== Diff against EToys-mt.386 ===============<br>
<br>
Item was changed:<br>
----- Method: BraceNode>>asMorphicSyntaxIn: (in category '*Etoys-tiles') -----<br>
asMorphicSyntaxIn: parent<br>
<br>
| row |<br>
<br>
+ row := (parent addRow: #brace on: self) layoutInset: 1.<br>
- row _ (parent addRow: #brace on: self) layoutInset: 1.<br>
row addMorphBack: (StringMorph new contents: <br>
(String streamContents: [:aStream | self printOn: aStream indent: 0])).<br>
+ ^row!<br>
- ^row<br>
- !<br>
<br>
Item was changed:<br>
----- Method: FreeCellStatistics>>reset (in category 'actions') -----<br>
reset<br>
<br>
+ sessionWins := 0.<br>
+ sessionLosses := 0.<br>
+ totalWins := 0.<br>
+ totalLosses := 0.<br>
+ streakWins := 0.<br>
+ streakLosses := 0.<br>
+ winsWithReplay := 0.<br>
+ lossesWithReplay := 0.<br>
+ lastGameWon := 0.<br>
+ lastGameLost := 0.<br>
+ currentCount := 0.<br>
+ currentType := nil.<br>
+ self changed!<br>
- sessionWins _ 0.<br>
- sessionLosses _ 0.<br>
- totalWins _ 0.<br>
- totalLosses _ 0.<br>
- streakWins _ 0.<br>
- streakLosses _ 0.<br>
- winsWithReplay := 0.<br>
- lossesWithReplay := 0.<br>
- lastGameWon _ 0.<br>
- lastGameLost _ 0.<br>
- currentCount _ 0.<br>
- currentType _ nil.<br>
- self changed.<br>
- <br>
- <br>
- !<br>
<br>
Item was changed:<br>
----- Method: LiteralNode>>asMorphicSyntaxIn: (in category '*Etoys-tiles') -----<br>
asMorphicSyntaxIn: parent<br>
<br>
| row |<br>
<br>
+ row := parent addRow: #literal on: self.<br>
- row _ parent addRow: #literal on: self.<br>
(key isVariableBinding) ifFalse: [<br>
row layoutInset: 1.<br>
^ row addMorphBack: (row addString: key storeString special: false)].<br>
key key isNil ifTrue: [<br>
^ row addTextRow: ('###',key value soleInstance name)<br>
] ifFalse: [<br>
^ row addTextRow: ('##', key key)<br>
+ ]!<br>
- ]. !<br>
<br>
Item was changed:<br>
----- Method: ParseNode>>asMorphicSyntaxIn: (in category '*Etoys-tiles') -----<br>
asMorphicSyntaxIn: parent<br>
<br>
| morph |<br>
"Default for missing implementations"<br>
<br>
+ morph := parent addColumn: #error on: self.<br>
- morph _ parent addColumn: #error on: self.<br>
morph addTextRow: self class printString.<br>
+ ^morph!<br>
- ^morph<br>
- <br>
- <br>
- !<br>
<br>
Item was changed:<br>
----- Method: VariableNode>>variableGetterBlockIn: (in category '*Etoys-tiles') -----<br>
variableGetterBlockIn: aContext<br>
<br>
| temps index ivars |<br>
<br>
(self type = 4 and: [self key isVariableBinding]) ifTrue: [<br>
^[self key value]<br>
].<br>
aContext ifNil: [^nil].<br>
self isSelfPseudoVariable ifTrue: [^[aContext receiver]].<br>
self type = 1 ifTrue: [<br>
+ ivars := aContext receiver class allInstVarNames.<br>
+ index := ivars indexOf: self name ifAbsent: [^nil].<br>
- ivars _ aContext receiver class allInstVarNames.<br>
- index _ ivars indexOf: self name ifAbsent: [^nil].<br>
^[aContext receiver instVarAt: index]<br>
].<br>
self type = 2 ifTrue: [<br>
+ temps := aContext tempNames.<br>
+ index := temps indexOf: self name ifAbsent: [^nil].<br>
- temps _ aContext tempNames.<br>
- index _ temps indexOf: self name ifAbsent: [^nil].<br>
^[aContext tempAt: index]<br>
].<br>
+ ^nil!<br>
- ^nil<br>
- !<br>
<br>
<br>
</blockquote></div>