<div dir="ltr">Hi Christoph,<div><br></div><div>This test is for Object>>#caseError only, not #caseOf:[otherwise:]. I started it out in ObjectTest, too, but then it looked like those tests were more "fundamental" while the purpose of this test was simply to expose the bug, so gave it its own class to expose the printing bug.</div><div><br></div><div>I think it sounds fine to include your other tests and rename it more general (heh, would that be "TestCase subclass: #CaseTest" ? :) ). I took a quick look at your changeset and it looks good, the only question I would have is are those three Object new fixtures exercising the function in a different way? Matching up the 'a''s 'b''s and 'c's was a bit tedious, especially trying to figure out if they're testing something unique or the same function..</div><div><br></div><div>Regards,</div><div> Chris</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 16, 2020 at 1:30 PM Thiede, Christoph <<a href="mailto:Christoph.Thiede@student.hpi.uni-potsdam.de" target="_blank">Christoph.Thiede@student.hpi.uni-potsdam.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<div dir="ltr">
<div id="gmail-m_-3166012170989081048gmail-m_-712650536545702890x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif">
<p>Hi Chris,</p>
<p><br>
</p>
<p>please have a look at <span style="font-size:12pt"><a href="http://forum.world.st/Merge-Request-caseOf-otherwise-with-arguments-td5112223.html" target="_blank">Merge Request: #caseOf:otherwise: with arguments</a> - I already tested #caseOf:[otherwise:]
there in detail. If you think these tests are written badly, please let me know, I depend on your feedback :-)</span></p>
<div id="gmail-m_-3166012170989081048gmail-m_-712650536545702890x_Signature">
<div id="gmail-m_-3166012170989081048gmail-m_-712650536545702890x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper">
<div>
<div id="gmail-m_-3166012170989081048gmail-m_-712650536545702890x_Item.MessagePartBody">
<div id="gmail-m_-3166012170989081048gmail-m_-712650536545702890x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="gmail-m_-3166012170989081048gmail-m_-712650536545702890x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="gmail-m_-3166012170989081048gmail-m_-712650536545702890x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" rel="noopener noreferrer" id="gmail-m_-3166012170989081048gmail-m_-712650536545702890LPNoLP" target="_blank"><font size="2"><span id="gmail-m_-3166012170989081048gmail-m_-712650536545702890LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
<div id="gmail-m_-3166012170989081048gmail-m_-712650536545702890x_Item.MessagePartBody"><br>
</div>
<div id="gmail-m_-3166012170989081048gmail-m_-712650536545702890x_Item.MessagePartBody">Best,</div>
<div id="gmail-m_-3166012170989081048gmail-m_-712650536545702890x_Item.MessagePartBody">Christoph</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%">
<div id="gmail-m_-3166012170989081048gmail-m_-712650536545702890x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <<a href="mailto:squeak-dev-bounces@lists.squeakfoundation.org" target="_blank">squeak-dev-bounces@lists.squeakfoundation.org</a>> im Auftrag von <a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a> <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>><br>
<b>Gesendet:</b> Samstag, 14. März 2020 00:09:39<br>
<b>An:</b> <a href="mailto:squeak-dev@lists.squeakfoundation.org" target="_blank">squeak-dev@lists.squeakfoundation.org</a>; <a href="mailto:packages@lists.squeakfoundation.org" target="_blank">packages@lists.squeakfoundation.org</a><br>
<b>Betreff:</b> [squeak-dev] The Trunk: Tests-cmm.428.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt">
<div>Chris Muller uploaded a new version of Tests to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Tests-cmm.428.mcz" target="_blank">http://source.squeak.org/trunk/Tests-cmm.428.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tests-cmm.428<br>
Author: cmm<br>
Time: 13 March 2020, 6:09:37.220407 pm<br>
UUID: cd4af6d7-7fed-44c1-bfe7-64a2de3cb7ee<br>
Ancestors: Tests-nice.427<br>
<br>
Tests for #caseError.<br>
<br>
=============== Diff against Tests-nice.427 ===============<br>
<br>
Item was added:<br>
+ TestCase subclass: #CaseErrorTest<br>
+ instanceVariableNames: ''<br>
+ classVariableNames: ''<br>
+ poolDictionaries: ''<br>
+ category: 'Tests-Bugs'!<br>
<br>
Item was added:<br>
+ ----- Method: CaseErrorTest>>printOn: (in category 'tests') -----<br>
+ printOn: aStream<br>
+ 3 caseOf: <br>
+ { [1] -> [aStream nextPutAll: 'option 1'].<br>
+ [2] -> [aStream nextPutAll: 'option 2'] }<br>
+ "caseError in printOn:"!<br>
<br>
Item was added:<br>
+ ----- Method: CaseErrorTest>>testCaseError (in category 'tests') -----<br>
+ testCaseError<br>
+ self<br>
+ should:<br>
+ [2 caseOf:<br>
+ { [1] -> ['option 1'] }]<br>
+ raise: Error!<br>
<br>
Item was added:<br>
+ ----- Method: CaseErrorTest>>testCaseErrorInPrintOn (in category 'tests') -----<br>
+ testCaseErrorInPrintOn<br>
+ self should: [ self printString ] raise: Error!<br>
<br>
<br>
</div>
</span></font>
</div>
<br>
</blockquote></div>