<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Nicolas.<div><br></div><div>> <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">due to hackish nature of this piece of code, it's going to be difficult to find an enlightening comment. </span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Eliot rather suggested a rewrite of this portion.</span></div><div><br></div><div>That's exactly the comment that would help me. Mark it as "under construction" somehow. Use comments and/or #flag:.</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 30.03.2020 12:32:28 schrieb Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">Personnally, I would use a constructor without index and let the Node take care of as yet uninitialized index, rather than leaking the knowledge of nil <=> uninitialized to the client side.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le lun. 30 mars 2020 à 12:28, Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi Marcel,</div><div>due to hackish nature of this piece of code, it's going to be difficult to find an enlightening comment.</div><div>Eliot rather suggested a rewrite of this portion.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le lun. 30 mars 2020 à 12:17, Marcel Taeumel <<a href="mailto:marcel.taeumel@hpi.de" target="_blank">marcel.taeumel@hpi.de</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div id="gmail-m_-5098793950502318622gmail-m_6169762647914217433__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: rgb(0,0,0)">
Hi all.<div><br></div><div>Changing a "0" into a "nil" deserves a comment *in* that changed method. Otherwise, this is meant to be changed back in the future because "0" maybe be more readable than "nil". :-)</div><div><br></div><div>Best,</div><div>Marcel</div><div></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px">
<p style="color:rgb(170,170,170);margin-top:10px">Am 28.03.2020 14:32:28 schrieb <a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a> <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>>:</p><div style="font-family:Arial,Helvetica,sans-serif">Nicolas Cellier uploaded a new version of Compiler to project The Trunk:<br><a href="http://source.squeak.org/trunk/Compiler-ct.426.mcz" target="_blank">http://source.squeak.org/trunk/Compiler-ct.426.mcz</a><br><br>==================== Summary ====================<br><br>Name: Compiler-ct.426<br>Author: ct<br>Time: 28 March 2020, 1:22:49.51256 am<br>UUID: 761924e9-77a0-1144-9533-8a7c22c03332<br>Ancestors: Compiler-ct.424<br><br>Fixes a bug regarding decompilation of special selectors.<br><br>The following did not work before:<br><br> (OrderedCollection >> #asArray) decompile generate valueWithReceiver: {42} asOrderedCollection arguments: #(). "MessageNotUnderstood: OrderedCollection>>#Array=>Array"<br><br>See also this thread: <a href="http://forum.world.st/The-Inbox-EToys-ct-367-mcz-tp5105507p5114020.html" target="_blank">http://forum.world.st/The-Inbox-EToys-ct-367-mcz-tp5105507p5114020.html</a><br><br>=============== Diff against Compiler-ct.424 ===============<br><br>Item was changed:<br> ----- Method: DecompilerConstructor>>codeAnySelector: (in category 'constructor') -----<br> codeAnySelector: selector<br> <br> ^SelectorNode new<br> key: selector<br>+ index: nil<br>- index: 0<br> type: SendType!<br><br><br></div></blockquote>
</div></div><br>
</blockquote></div>
</blockquote></div>
</div></blockquote>
</div></body>