<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Jakob, hi all,</p>
<p><br>
</p>
<p>> <span style="font-size: 12pt;">Did you intentionally not reply the mailing list?</span></p>
<div><br>
</div>
<p></p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">I could not find your previous mail on the list, too! However, we're back on the list now :)
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont"></font></div>
</div>
</font></div>
</div>
</div>
</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">Hm ... what about deprecating #orderedItems and introducing a new #allItems instead? Then we could avoid any internal confusion and had a stable public protocol.</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">> <span style="font-size: 12pt;">Which reminds me in general that Monticello classes could use some class comments. :-(</span>
<div><br>
</div>
<div>A really good idea! :D</div>
<div><br>
</div>
<div>Best,</div>
<div>Christoph</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Jakob Reschke <forums.jakob@resfarm.de><br>
<b>Gesendet:</b> Samstag, 11. April 2020 15:53:11<br>
<b>An:</b> Thiede, Christoph<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Monticello-ct.715.mcz</font>
<div> </div>
</div>
<div>
<div dir="auto">
<div dir="auto">Hi Christoph,</div>
<div dir="auto"><br>
</div>
<div dir="auto">Did you intentionally not reply the mailing list?</div>
<div dir="auto"><br>
</div>
<div>We should care, the method is public and AFAIK the class is also not in some private category. Also "outsiders" should not care about the instance variable, but about the interface. Which was altered by this change.
<div dir="auto"><br>
</div>
<div dir="auto">Which reminds me in general that Monticello classes could use some class comments. :-(<br>
<div dir="auto"><br>
</div>
<div dir="auto">Kinds regards,</div>
<div dir="auto">Jakob</div>
</div>
<br>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Thiede, Christoph <<a href="mailto:Christoph.Thiede@student.hpi.uni-potsdam.de" target="_blank" rel="noreferrer">Christoph.Thiede@student.hpi.uni-potsdam.de</a>> schrieb am Sa., 11. Apr. 2020, 14:41:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div dir="ltr">
<div id="m_3265196316685528204m_8043358064519030669x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif">
<p>Hi Jakob, sorry for the late reply!</p>
<p><br>
</p>
<p>My doubts about option 2 would be that as a developer of the sorter, you might not expect "self orderedItems" to return a different result than "orderedItems" (the instance variable). To me, this feels a bit like an anti-pattern.</p>
<p><br>
</p>
<p>I don't know whether we have to care about compatibility outside the Trunk: If not, we could introduce a new getter such as #allOrderedItems for this purpose ...</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="m_3265196316685528204m_8043358064519030669x_Signature">
<div id="m_3265196316685528204m_8043358064519030669x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper">
<div>
<div id="m_3265196316685528204m_8043358064519030669x_Item.MessagePartBody">
<div id="m_3265196316685528204m_8043358064519030669x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="m_3265196316685528204m_8043358064519030669x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="m_3265196316685528204m_8043358064519030669x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" rel="noopener noreferrer noreferrer noreferrer" id="m_3265196316685528204m_8043358064519030669LPNoLP" target="_blank"><font size="2"><span id="m_3265196316685528204m_8043358064519030669LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%">
<div id="m_3265196316685528204m_8043358064519030669x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Jakob Reschke <<a href="mailto:forums.jakob@resfarm.de" rel="noreferrer noreferrer" target="_blank">forums.jakob@resfarm.de</a>><br>
<b>Gesendet:</b> Freitag, 10. April 2020 08:39:31<br>
<b>An:</b> Thiede, Christoph<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Monticello-ct.715.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt">
<div>Hi,<br>
<br>
Is there a use case for not getting all the items, or getting an<br>
intermediate list? There wasn't before, right? I would find it strange<br>
if I had to tell the sorter "give me what you have got, I mean all of<br>
it". This would be unusual and presumably easy to forget. So without<br>
further arguments, I would pick option 2.<br>
<br>
Kind regards,<br>
Jakob<br>
<br>
Am Fr., 10. Apr. 2020 um 00:33 Uhr schrieb Thiede, Christoph<br>
<<a href="mailto:Christoph.Thiede@student.hpi.uni-potsdam.de" rel="noreferrer noreferrer" target="_blank">Christoph.Thiede@student.hpi.uni-potsdam.de</a>>:<br>
><br>
> Hi Jakob,<br>
><br>
><br>
> Thanks for the report - and I'm sorry to hear that I broke this!<br>
><br>
><br>
> The motivation for the deferred list was that #addToOrder: (and so the constructor #items:) actually does not sort the added items, but only their dependencies. That's why you need to send #addDeferred to the sorter after adding all other items. Before now,
I did not realize that #orderedItems has external users.<br>
><br>
><br>
> So there are two options:<br>
><br>
> 1. Permanently change the public protocol of the dependency sorter - if you want to get all items, you need to send #addDeferred ti the sorter before retrieving the #orderedItems. In the Trunk, we would need to update four senders in three classes for this
solution.<br>
><br>
> 2. Change #orderedItems to lazily append the deferred items to the returned list. This is not ideal as it makes the getter more expensive, but on the other hand, we can preserve compatibility by doing so.<br>
><br>
><br>
> I'm open for your opinion on both approaches, or for any other idea! :-)<br>
><br>
><br>
> Best,<br>
><br>
> Christoph<br>
><br>
> ________________________________<br>
> Von: Jakob Reschke <<a href="mailto:forums.jakob@resfarm.de" rel="noreferrer noreferrer" target="_blank">forums.jakob@resfarm.de</a>><br>
> Gesendet: Freitag, 10. April 2020 00:03:47<br>
> An: Thiede, Christoph; <a href="mailto:squeak-dev@lists.squeakfoundation.org" rel="noreferrer noreferrer" target="_blank">
squeak-dev@lists.squeakfoundation.org</a><br>
> Betreff: Re: [squeak-dev] The Trunk: Monticello-ct.715.mcz<br>
><br>
> Forgot to mention the net result of the issue: the postscripts gets<br>
> effectively removed in the saved version.<br>
><br>
> Am Fr., 10. Apr. 2020 um 00:02 Uhr schrieb Jakob Reschke<br>
> <<a href="mailto:forums.jakob@resfarm.de" rel="noreferrer noreferrer" target="_blank">forums.jakob@resfarm.de</a>>:<br>
> ><br>
> > It looks like this broke the writing of postscripts in FileTree repositories.<br>
> ><br>
> > MCFileTreePackageStructureStWriter>>acceptVisitor:forDefinitions:<br>
> > (MCDependencySorter sortItems: aCollection) does not include an<br>
> > MCPostscriptDefinition that is still present in aCollection.<br>
> ><br>
> > MCDependencySorter class>>sortItems:<br>
> > The sorter includes the MCPostscriptDefinition in the new deferred<br>
> > list, but not in the orderedItems. Therefore it is not included in the<br>
> > result of sortItems:, because it only returns the orderedItems, not<br>
> > the deferred ones.<br>
> ><br>
> > Christoph, can and must sortItems: be fixed or a different method?<br>
> ><br>
> ><br>
> > Am Do., 5. März 2020 um 21:05 Uhr schrieb <<a href="mailto:commits@source.squeak.org" rel="noreferrer noreferrer" target="_blank">commits@source.squeak.org</a>>:<br>
> > ><br>
> > > Nicolas Cellier uploaded a new version of Monticello to project The Trunk:<br>
> > > <a href="http://source.squeak.org/trunk/Monticello-ct.715.mcz" rel="noreferrer noreferrer" target="_blank">
http://source.squeak.org/trunk/Monticello-ct.715.mcz</a><br>
> > ><br>
> > > ==================== Summary ====================<br>
> > ><br>
> > > Name: Monticello-ct.715<br>
> > > Author: ct<br>
> > > Time: 6 February 2020, 6:58:26.533648 pm<br>
> > > UUID: 199bf8a3-5eee-1045-a44b-89ad30fa5523<br>
> > > Ancestors: Monticello-cmm.708<br>
> > ><br>
> > > Fixes wrong load and unload order of MCScriptDefinitions<br>
> > ><br>
> > > See <a href="http://forum.world.st/Monticello-Bug-Preamble-of-removal-is-executed-too-late-tp5108401.html" rel="noreferrer noreferrer" target="_blank">
http://forum.world.st/Monticello-Bug-Preamble-of-removal-is-executed-too-late-tp5108401.html</a>. Regression tests are in Tests-ct.426.<br>
> > ><br>
> > > Please review!<br>
> > ><br>
> > > =============== Diff against Monticello-cmm.708 ===============<br>
> > ><br>
> > > Item was added:<br>
> > > + ----- Method: MCDefinition>>wantsToBeOutermost (in category 'testing') -----<br>
> > > + wantsToBeOutermost<br>
> > > +<br>
> > > + ^ false!<br>
> > ><br>
> > > Item was changed:<br>
> > > Object subclass: #MCDependencySorter<br>
> > > + instanceVariableNames: 'required provided deferred orderedItems'<br>
> > > - instanceVariableNames: 'required provided orderedItems'<br>
> > > classVariableNames: ''<br>
> > > poolDictionaries: ''<br>
> > > category: 'Monticello-Loading'!<br>
> > ><br>
> > > Item was changed:<br>
> > > ----- Method: MCDependencySorter>>add: (in category 'building') -----<br>
> > > add: anItem<br>
> > > | requirements |<br>
> > > + (anItem wantsToBeOutermost)<br>
> > > + ifTrue: [^self addDeferred: anItem].<br>
> > > requirements := self unresolvedRequirementsFor: anItem.<br>
> > > requirements isEmpty<br>
> > > ifTrue: [self addToOrder: anItem]<br>
> > > ifFalse: [self addRequirements: requirements for: anItem].<br>
> > > ^anItem!<br>
> > ><br>
> > > Item was added:<br>
> > > + ----- Method: MCDependencySorter>>addDeferred (in category 'building') -----<br>
> > > + addDeferred<br>
> > > + deferred do: [:ea |<br>
> > > + self addToOrder: ea].!<br>
> > ><br>
> > > Item was added:<br>
> > > + ----- Method: MCDependencySorter>>addDeferred: (in category 'private') -----<br>
> > > + addDeferred: anItem<br>
> > > + ^ deferred add: anItem!<br>
> > ><br>
> > > Item was changed:<br>
> > > ----- Method: MCDependencySorter>>initialize (in category 'initialize-release') -----<br>
> > > initialize<br>
> > > provided := Set new.<br>
> > > required := Dictionary new.<br>
> > > + orderedItems := OrderedCollection new.<br>
> > > + deferred := OrderedCollection new.!<br>
> > > - orderedItems := OrderedCollection new.!<br>
> > ><br>
> > > Item was changed:<br>
> > > ----- Method: MCPackageLoader>>sorterForItems: (in category 'private') -----<br>
> > > sorterForItems: aCollection<br>
> > > | sorter |<br>
> > > sorter := MCDependencySorter items: aCollection.<br>
> > > sorter addExternalProvisions: self provisions.<br>
> > > + sorter addDeferred.<br>
> > > ^ sorter!<br>
> > ><br>
> > > Item was added:<br>
> > > + ----- Method: MCPostscriptDefinition>>wantsToBeOutermost (in category 'nil') -----<br>
> > > + wantsToBeOutermost<br>
> > > +<br>
> > > + ^ true!<br>
> > ><br>
> > > Item was added:<br>
> > > + ----- Method: MCRemovalPreambleDefinition>>wantsToBeOutermost (in category 'testing') -----<br>
> > > + wantsToBeOutermost<br>
> > > +<br>
> > > + ^ true!<br>
> > ><br>
> > ><br>
</div>
</span></font></div>
</blockquote>
</div>
</div>
</div>
</div>
</body>
</html>