<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
        {margin-top:0;
        margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Great idea! Are there any visible performance improvements? In any case, this change makes it more easy to explore and debug the matching process!</p>
<p><br>
</p>
<p>FYI, you left three return carets in this method. :-)</p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody"><br>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">Best,</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">Christoph</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Samstag, 11. April 2020 22:05:05<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Inbox: Regex-Core-ul.57.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Levente Uzonyi uploaded a new version of Regex-Core to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Regex-Core-ul.57.mcz">http://source.squeak.org/inbox/Regex-Core-ul.57.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Regex-Core-ul.57<br>
Author: ul<br>
Time: 11 April 2020, 9:42:43.405809 pm<br>
UUID: 3cda3ad5-49f2-41f1-ab9d-2f6fc242ae9d<br>
Ancestors: Regex-Core-ct.56<br>
<br>
- avoid generating RxmBranch nodes when there's no real branch. e.g. 'abc' asRegex<br>
<br>
=============== Diff against Regex-Core-ct.56 ===============<br>
<br>
Item was changed:<br>
  ----- Method: RxMatcher>>hookBranchOf:onto: (in category 'private') -----<br>
  hookBranchOf: regexNode onto: endMarker<br>
         "Private - Recurse down the chain of regexes starting at<br>
         regexNode, compiling their branches and hooking their tails <br>
         to the endMarker node."<br>
  <br>
+        ^regexNode regex <br>
+                ifNil: [ "Avoid creating a branch without an alternative."<br>
+                        ^(regexNode branch dispatchTo: self)<br>
+                                pointTailTo: endMarker; <br>
+                                yourself ]<br>
+                ifNotNil: [ :regex |<br>
+                        | rest |<br>
+                        rest := self hookBranchOf: regex onto: endMarker.<br>
+                        ^RxmBranch new<br>
+                                next: ((regexNode branch dispatchTo: self)<br>
-        | rest |<br>
-        rest := regexNode regex ifNotNil: [ :regex |<br>
-                self hookBranchOf: regex onto: endMarker ].<br>
-        ^RxmBranch new<br>
-                next: ((regexNode branch dispatchTo: self)<br>
                                         pointTailTo: endMarker; <br>
                                         yourself);<br>
+                                alternative: rest;<br>
+                                yourself ]<br>
+ !<br>
-                alternative: rest;<br>
-                yourself!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>