<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
> <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">I suppose it does make more sense asking a CompiledCode about it's "messages", than its "selectors". A strange subtlety..</span><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Hmm... what actually is a "message"? In this case, the term "selector" seems more appropriate because more technical. "Messages" need arguments? Or is that a "message send"? :-)</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">We have the following classes around the term "message":</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">- Message (for DNU)</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">- MessageSend (for callbacks)</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">I wouldn't associate those higher-level concepts with CompiledCode.</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Best,</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Marcel</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 16.04.2020 22:30:28 schrieb Chris Muller <asqueaker@gmail.com>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">I suppose it does make more sense asking a CompiledCode about it's "messages", than its "selectors". A strange subtlety..</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 16, 2020 at 2:09 PM Chris Muller <<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hm, now you've got two words to describe one thing ("message" and :"selector"). I like "selector", but don't you want to rename them all?<br></div><div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 15, 2020 at 6:07 PM <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Eliot Miranda uploaded a new version of Kernel to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Kernel-eem.1321.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk/Kernel-eem.1321.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Kernel-eem.1321<br>
Author: eem<br>
Time: 15 April 2020, 4:07:36.59453 pm<br>
UUID: 93f4b4c9-41ba-47f8-b220-72087fc41176<br>
Ancestors: Kernel-eem.1319<br>
<br>
Change a couple of CompiledCode methods to use selectorsDo:; messagesDo: should be deprecated at some point.<br>
<br>
=============== Diff against Kernel-eem.1319 ===============<br>
<br>
Item was changed:<br>
----- Method: CompiledCode>>messages (in category 'scanning') -----<br>
messages<br>
"Answer a Set of all the message selectors sent by this method."<br>
<br>
| result |<br>
result := Set new.<br>
+ self selectorsDo: [:selector | result add: selector].<br>
- self messagesDo: [:selector | result add: selector].<br>
^ result!<br>
<br>
Item was changed:<br>
----- Method: CompiledCode>>messagesSequence (in category 'scanning') -----<br>
messagesSequence<br>
"Answer a sequence of all the message selectors sent by this method in the order they are sent. Unlike #messages this may include duplicates. Note that both the sources and the decompiled sources might suggest different results. The returned information reflect the actual bytecode."<br>
<br>
^ Array streamContents: [:result |<br>
+ self selectorsDo: [:selector | result nextPut: selector]]!<br>
- self messagesDo: [:selector | result nextPut: selector]]!<br>
<br>
<br>
</blockquote></div>
</blockquote></div>
</div></blockquote>
</div></body>