<div dir="ltr">Why doesn't the test timeout catch it? I thought that was its primary purpose.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 17, 2020 at 4:30 AM Marcel Taeumel <<a href="mailto:marcel.taeumel@hpi.de">marcel.taeumel@hpi.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div id="gmail-m_-1300252416107269354__MailbirdStyleContent" style="font-size:10pt;font-family:Arial;color:rgb(0,0,0)">
The bigger issue is that we cannot interrupt recursive calls on printOn in "any case" .... :-/<div></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px">
<p style="color:rgb(170,170,170);margin-top:10px">Am 17.04.2020 09:34:40 schrieb Marcel Taeumel <<a href="mailto:marcel.taeumel@hpi.de" target="_blank">marcel.taeumel@hpi.de</a>>:</p><div style="font-family:Arial,Helvetica,sans-serif"><div id="gmail-m_-1300252416107269354__MailbirdStyleContent" style="font-size:10pt;font-family:Arial;color:rgb(0,0,0)">
Thanks Fabio!<div><br></div><div>We'll take a look at this test. I think it is not a good idea to modify a test's #printString as part of a test because that #printString is used to show failing tests in tools. ;-)</div><div><br></div><div>Best,</div><div>Marcel</div><div></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px">
<p style="color:rgb(170,170,170);margin-top:10px">Am 16.04.2020 10:54:10 schrieb Fabio Niephaus <<a href="mailto:lists@fniephaus.com" target="_blank">lists@fniephaus.com</a>>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr"><div>Trunk builds are working again:</div><div><a href="https://travis-ci.org/github/squeak-smalltalk/squeak-app/builds/675633268" target="_blank">https://travis-ci.org/github/squeak-smalltalk/squeak-app/builds/675633268</a><br></div><div><br></div><div>Bundles are at:</div><div><a href="http://files.squeak.org/6.0alpha/Squeak6.0alpha-19582-64bit/" target="_blank">http://files.squeak.org/6.0alpha/Squeak6.0alpha-19582-64bit/</a><br></div><div><a href="http://files.squeak.org/6.0alpha/Squeak6.0alpha-19582-32bit/" target="_blank">http://files.squeak.org/6.0alpha/Squeak6.0alpha-19582-32bit/</a><br></div><div><br></div><div>Fabio</div><div dir="ltr"><br></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 16, 2020 at 10:16 AM Fabio Niephaus <<a href="mailto:lists@fniephaus.com" target="_blank">lists@fniephaus.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Thu, Apr 16, 2020 at 9:46 AM Tobias Pape <<a href="mailto:Das.Linux@gmx.de" target="_blank">Das.Linux@gmx.de</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
> On 16.04.2020, at 09:41, Fabio Niephaus <<a href="mailto:lists@fniephaus.com" target="_blank">lists@fniephaus.com</a>> wrote:<br>
> <br>
> This change causes "Cannot allocate memory" errors in the 32bit VM during testing (and therefore fails trunk builds):<br>
> <a href="https://travis-ci.org/github/squeak-smalltalk/squeak-app/jobs/675293747#L6063" rel="noreferrer" target="_blank">https://travis-ci.org/github/squeak-smalltalk/squeak-app/jobs/675293747#L6063</a><br>
> <br>
<br>
> Please fix,<br>
<br>
Well, it exposes a bug in trunk, right?<br>
This test case merely documents this :)<br></blockquote><div><br></div><div>If it is failing this hard, the test needs to be excluded from CI (e.g. via [1]). Our CI picks up new tests automatically, which is almost always what we want. Except when adding these kinds of tests (I'm going to exclude the test case now).</div><div><br></div><div>This was merged a month ago, about the time trunk 64bit broke. I wish we'd take CI more seriously.</div><div><br></div><div>Fabio</div><div><br></div><div>[1] <a href="https://github.com/squeak-smalltalk/squeak-app/blob/2541c1083bbda64a0839e3858f7517a493219de9/smalltalk-ci/Squeak64-trunk.ston#L8" target="_blank">https://github.com/squeak-smalltalk/squeak-app/blob/2541c1083bbda64a0839e3858f7517a493219de9/smalltalk-ci/Squeak64-trunk.ston#L8</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
-t<br>
<br>
> Fabio<br>
> <br>
> Excerpt of stack trace:<br>
> ........<br>
> 0xfe9d53a8 s [] in CaseErrorTest(Object)>printStringLimitedTo:<br>
> 0xfe9d5430 s String class(SequenceableCollection class)>streamContents:limitedTo:<br>
> 0xfe9d5538 s CaseErrorTest(Object)>printStringLimitedTo:<br>
> 0xfe9d5598 s CaseErrorTest(Object)>printString<br>
> 0xfe9d55f8 s CaseErrorTest(Object)>caseError<br>
> 0xfe9d5658 s CaseErrorTest>printOn:<br>
> 0xfe9d56b8 s [] in CaseErrorTest(Object)>printStringLimitedTo:<br>
> 0xfe9d5740 s String class(SequenceableCollection class)>streamContents:limitedTo:<br>
> 0xfe9d5848 s CaseErrorTest(Object)>printStringLimitedTo:<br>
> 0xfe9d58a8 s CaseErrorTest(Object)>printString<br>
> 0xfe9d5908 s CaseErrorTest(Object)>caseError<br>
> 0xfe9d5968 s CaseErrorTest>printOn:<br>
> ........<br>
> <br>
> On Sat, Mar 14, 2020 at 12:09 AM <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>> wrote:<br>
> Chris Muller uploaded a new version of Tests to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/Tests-cmm.428.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk/Tests-cmm.428.mcz</a><br>
> <br>
> ==================== Summary ====================<br>
> <br>
> Name: Tests-cmm.428<br>
> Author: cmm<br>
> Time: 13 March 2020, 6:09:37.220407 pm<br>
> UUID: cd4af6d7-7fed-44c1-bfe7-64a2de3cb7ee<br>
> Ancestors: Tests-nice.427<br>
> <br>
> Tests for #caseError.<br>
> <br>
> =============== Diff against Tests-nice.427 ===============<br>
> <br>
> Item was added:<br>
> + TestCase subclass: #CaseErrorTest<br>
> + instanceVariableNames: ''<br>
> + classVariableNames: ''<br>
> + poolDictionaries: ''<br>
> + category: 'Tests-Bugs'!<br>
> <br>
> Item was added:<br>
> + ----- Method: CaseErrorTest>>printOn: (in category 'tests') -----<br>
> + printOn: aStream<br>
> + 3 caseOf: <br>
> + { [1] -> [aStream nextPutAll: 'option 1'].<br>
> + [2] -> [aStream nextPutAll: 'option 2'] }<br>
> + "caseError in printOn:"!<br>
> <br>
> Item was added:<br>
> + ----- Method: CaseErrorTest>>testCaseError (in category 'tests') -----<br>
> + testCaseError<br>
> + self<br>
> + should:<br>
> + [2 caseOf:<br>
> + { [1] -> ['option 1'] }]<br>
> + raise: Error!<br>
> <br>
> Item was added:<br>
> + ----- Method: CaseErrorTest>>testCaseErrorInPrintOn (in category 'tests') -----<br>
> + testCaseErrorInPrintOn<br>
> + self should: [ self printString ] raise: Error!<br>
> <br>
> <br>
> <br>
<br>
<br>
<br>
</blockquote></div></div>
</blockquote></div></div>
</div></blockquote>
</div></div></blockquote>
</div></div><br>
</blockquote></div>