<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>> <span>Maybe #browseIt and #sendersOfIt should also go through the model?</span></p>
<p><span><br>
</span></p>
<p><span>Afaik #browseAllCallsOn: already goes through the model, at least in MessageTraces? Sounds like a good idea for #browseClass:, too :-)</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Sonntag, 26. April 2020 16:30:38<br>
<b>An:</b> Robert via Squeak-dev; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Morphic-mt.1649.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Christoph.
<div><br>
</div>
<div>> <span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">What was the reason for sending it to the system navigation directly? :-)</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px"><br>
</span></div>
<div><span style="font-family: Calibri, Helvetica, sans-serif;font-size: 16px">No reason, just oversight ... and maybe evidence of a surprising, inconsistent extension point. Maybe #browseIt and #sendersOfIt should also go through the model? Well, #doIt and
#printIt do already go through the model if that model reponds to certain messages.</span></div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 24.04.2020 19:59:20 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif">
<p>Hi Marcel,</p>
<p><br>
</p>
<p><span style="font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 16px">apparently, </span>this change broke the #traceMessage preference since #<span>browseAllImplementorsOf:
is not dispatched to the MessageTrace any longer. What was the reason for sending it to the system navigation directly? :-)</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: rgb(0,0,0);font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family: Calibri,Arial,Helvetica,sans-serif;font-size: ;margin: 0">
<div><span style="font-size: 10pt;color: #808080"></span></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Mittwoch, 22. April 2020 10:46:19<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Morphic-mt.1649.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">Marcel Taeumel uploaded a new version of Morphic to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Morphic-mt.1649.mcz">http://source.squeak.org/trunk/Morphic-mt.1649.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-mt.1649<br>
Author: mt<br>
Time: 22 April 2020, 10:46:13.027214 am<br>
UUID: 6b61e640-ba14-0d47-80af-c926334d4b82<br>
Ancestors: Morphic-mt.1648<br>
<br>
Fixes small glitch in text editor's #implementorsOfIt to behave like #sendersOfIt.<br>
<br>
=============== Diff against Morphic-mt.1648 ===============<br>
<br>
Item was changed:<br>
----- Method: TextEditor>>implementorsOfIt (in category 'menu messages') -----<br>
implementorsOfIt<br>
"Open an implementors browser on the selected selector"<br>
+ <br>
- | aSelector |<br>
self lineSelectAndEmptyCheck: [^ self].<br>
+ self selectedSelector ifNotNil:<br>
+ [:aSelector| ^self systemNavigation browseAllImplementorsOf: aSelector].<br>
+ self selectedLiteral ifNotNil:<br>
+ [:aLiteral| ^self systemNavigation browseAllImplementorsOf: aLiteral].<br>
+ morph flash.!<br>
- (aSelector := self selectedSelector) == nil ifTrue: [^ morph flash].<br>
- model browseAllImplementorsOf: aSelector!<br>
<br>
<br>
</div>
</span></span></div>
</blockquote>
</div>
</div>
</body>
</html>