<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Christoph,<div><br></div><div>I wonder what the conventions in the Web-programming world are in this regard. Using Firefox, the PNG from TravisCI happens to be "just of the right size" on a low-dpi display. After zooming in, that picture gets blurry. I wouldn't bother 1-2 pixels off for the sake of not being blurry. Or maybe our text anchors need some option to be on the baseline but not considered when computing the line height?</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 26.04.2020 20:21:10 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p><div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: rgb(0, 0, 0);font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols">
<p>Hi Marcel,</p>
<p><br>
</p>
<p>> <span>While we cannot call #scaledToHeight: depending on the text's current font properties,</span></p>
<p><span><br>
</span></p>
<p><span>Why not? Is there any HTML style attribute we could use for this purpose, or would this be a too major change?</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<p><span><br>
</span></p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: rgb(0,0,0);font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="divtagdefaultwrapper" style="font-family: Calibri,Arial,Helvetica,sans-serif;font-size: ;margin: 0">
<div><span style="font-size: 10pt;color: #808080"></span></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Montag, 20. April 2020 10:06:45<br>
<b>An:</b> gettimothy via Squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: MonticelloConfigurations-mt.160.mcz</span>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
> <span style="font-size: 13.3333px">> </span><span style="font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 12pt">1.</span><span style="font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 12pt"> </span><span style="font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 12pt">Can
we automatically use #scaledToHeight: for the badge to avoid the inconsistent row heights?</span>
<div>> <span style="font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 16px">Oh, definitely. I forgot to call #scaleIconToDisplay ...</span></div>
<div><br>
</div>
<div>Sorry, I mixed that up. While we cannot call #scaledToHeight: depending on the text's current font properties, we should call #scaledToSize: and honor RealEstateAgent >> scaleFactor. It is the best we have at the moment. --- #scaleIconToDisplay would also
not work because that scales down bigger images, which we do not want in HTML content.</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid; border-width:1px; margin-top:20px; margin-left:0px; padding-left:10px">
<p style="color:#AAAAAA; margin-top:10px">Am 20.04.2020 08:49:49 schrieb Marcel Taeumel <marcel.taeumel@hpi.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
> <span style="font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 12pt">1.</span><span style="font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 12pt"> </span><span style="font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 12pt">Can
we automatically use #scaledToHeight: for the badge to avoid the inconsistent row heights?</span>
<p style="margin-top: 0px;margin-bottom: 0px;font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 16px">
<span style="font-size: 12pt"><br>
</span></p>
<p style="margin-top: 0px;margin-bottom: 0px;font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 16px">
<span style="font-size: 12pt">Oh, definitely. I forgot to call #scaleIconToDisplay. I would rather not make a assumptions about the surrounding text but maybe add support width/height to the <img> tag.</span></p>
<p style="margin-top: 0px;margin-bottom: 0px;font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 16px">
<span style="font-size: 12pt"><br>
</span></p>
<p style="margin-top: 0px;margin-bottom: 0px;font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 16px">
<span style="font-size: 12pt">> 2. TextURL and TextReference seem not to work well together: In my image, only the left half of the banner is actually clickable.</span></p>
<p style="margin-top: 0px;margin-bottom: 0px;font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 16px">
<span style="font-size: 12pt"><br>
</span></p>
<p style="margin-top: 0px;margin-bottom: 0px;font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 16px">
<span style="font-size: 12pt">You can open a new discussion for that. :-) And maybe isolate the issue first in a compact example for everybody to try out.</span></p>
<p style="margin-top: 0px;margin-bottom: 0px;font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 16px">
<span style="font-size: 12pt"><br>
</span></p>
<p style="margin-top: 0px;margin-bottom: 0px;font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 16px">
<span style="font-size: 12pt">Best,</span></p>
<p style="margin-top: 0px;margin-bottom: 0px;font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size: 16px">
<span style="font-size: 12pt">Marcel</span></p>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid; border-width:1px; margin-top:20px; margin-left:0px; padding-left:10px">
<p style="color:#AAAAAA; margin-top:10px">Am 18.04.2020 15:36:05 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: rgb(0,0,0);font-family: Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p>I love this idea! :D</p>
<p><br>
</p>
<p>Two comments:</p>
<p><span style="font-size: 12pt"><br>
</span></p>
<p><span style="font-size: 12pt">1.</span><span style="font-size: 12pt"> </span><span style="font-size: 12pt">Can we automatically use #scaledToHeight: for the badge to avoid the inconsistent row heights?</span></p>
<p><span style="font-size: 12pt">2. TextURL and TextReference seem not to work well together: In my image, only the left half of the banner is actually clickable.</span></p>
<p><span style="font-size: 12pt"><br>
</span></p>
<p><span style="font-size: 12pt">Best,</span></p>
<p><span style="font-size: 12pt">Christoph</span></p>
<br>
<div style="color:rgb(0,0,0)">
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family:Calibri,sans-serif; color:#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von David T. Lewis <lewis@mail.msen.com><br>
<b>Gesendet:</b> Freitag, 17. April 2020 20:49 Uhr<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: MonticelloConfigurations-mt.160.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">That's brilliant :-)<br>
<br>
Dave<br>
<br>
On Fri, Apr 17, 2020 at 07:04:17PM +0200, karl ramberg wrote:<br>
> Cool<br>
> <br>
> Best,<br>
> Karl<br>
> <br>
> On Fri, Apr 17, 2020 at 5:25 PM Marcel Taeumel <marcel.taeumel@hpi.de><br>
> wrote:<br>
> <br>
> ><br>
> > Am 17.04.2020 17:17:37 schrieb commits@source.squeak.org <<br>
> > commits@source.squeak.org>:<br>
> > Marcel Taeumel uploaded a new version of MonticelloConfigurations to<br>
> > project The Trunk:<br>
> > <a href="http://source.squeak.org/trunk/MonticelloConfigurations-mt.160.mcz" id="LPlnk815660" previewremoved="true">
http://source.squeak.org/trunk/MonticelloConfigurations-mt.160.mcz</a><br>
> ><br>
> > ==================== Summary ====================<br>
> ><br>
> > Name: MonticelloConfigurations-mt.160<br>
> > Author: mt<br>
> > Time: 17 April 2020, 5:17:27.82286 pm<br>
> > UUID: 6d32501e-f519-3b4a-ae1a-58b52360a937<br>
> > Ancestors: MonticelloConfigurations-mt.159<br>
> ><br>
> > Shows the current CI status in the update dialog.<br>
> ><br>
> > =============== Diff against MonticelloConfigurations-mt.159<br>
> > ===============<br>
> ><br>
> > Item was changed:<br>
> > ----- Method: MCMcmUpdater>>doUpdate: (in category 'updating') -----<br>
> > doUpdate: interactive<br>
> > "Update the image by loading all pending updates from the server. If this<br>
> > is<br>
> > the default updater for the system, update the system version when<br>
> > complete.<br>
> > If interteractive use a modal notifier, otherwise only update the<br>
> > transcript.<br>
> > Flush all caches. If a previous download failed this is often helpful"<br>
> ><br>
> > | config previousUpdateLevel ensureTranscriptSetting |<br>
> > previousUpdateLevel := SystemVersion current highestUpdate.<br>
> > MCFileBasedRepository flushAllCaches.<br>
> > ensureTranscriptSetting := MCConfiguration ensureOpenTranscript.<br>
> > [ MCConfiguration ensureOpenTranscript: interactive.<br>
> > config := self updateFromRepository.<br>
> > config ifNil: [<br>
> > interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from<br>
> > remote repository.' translated ].<br>
> > Transcript cr; show: '========== Unable to retrieve updates from remote<br>
> > repository. ==========' translated; cr.<br>
> > ^ self ].<br>
> > MCMcmUpdater default == self<br>
> > ifTrue: [<br>
> > config setSystemVersion.<br>
> > + interactive ifTrue: [<br>
> > + self inform: (self updateMessageFor: previousUpdateLevel)].<br>
> > - interactive ifTrue: [<br>
> > - self inform: ('Update completed.\\Version: {1}\Update: {3}{2}\\Url:<br>
> > {4}\Map: ''{5}''{6}' translated withCRs format: {<br>
> > - SystemVersion current version.<br>
> > - SystemVersion current highestUpdate.<br>
> > - previousUpdateLevel = SystemVersion current highestUpdate<br>
> > - ifTrue: ['']<br>
> > - ifFalse: [previousUpdateLevel asString, ' -> '].<br>
> > - self repository.<br>
> > - MCMcmUpdater updateMapName.<br>
> > - SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | String<br>
> > cr, String cr, d]})].<br>
> > Transcript cr;<br>
> > show: '========== Update completed: ' translated;<br>
> > show: previousUpdateLevel;<br>
> > show: ' -> ' ;<br>
> > show: SystemVersion current highestUpdate;<br>
> > show: ' =========='; cr ]<br>
> > ifFalse: [<br>
> > interactive<br>
> > ifTrue: [ self inform: 'Update completed.' ].<br>
> > Transcript cr; show: '========== Update completed. ==========' translated;<br>
> > cr ] ]<br>
> > ensure: [ MCConfiguration ensureOpenTranscript: ensureTranscriptSetting].<br>
> ><br>
> > !<br>
> ><br>
> > Item was changed:<br>
> > ----- Method: MCMcmUpdater>>doUpdate:upTo: (in category 'updating') -----<br>
> > doUpdate: interactive upTo: versionNumber<br>
> > "Update the image by loading all pending updates from the server. If this<br>
> > is<br>
> > the default updater for the system, update the system version when<br>
> > complete.<br>
> > If interteractive use a modal notifier, otherwise only update the<br>
> > transcript.<br>
> > Flush all caches. If a previous download failed this is often helpful"<br>
> ><br>
> > | config previousUpdateLevel |<br>
> > previousUpdateLevel := SystemVersion current highestUpdate.<br>
> > MCFileBasedRepository flushAllCaches.<br>
> > config := self updateFromRepositories: { self repository } upTo:<br>
> > versionNumber.<br>
> > config ifNil: [<br>
> > interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from<br>
> > remote repository.' translated ].<br>
> > Transcript cr; show: '========== Unable to retrieve updates from remote<br>
> > repository. ==========' translated; cr.<br>
> > ^ self ].<br>
> > MCMcmUpdater default == self<br>
> > ifTrue: [<br>
> > config setSystemVersion.<br>
> > + interactive ifTrue: [<br>
> > + self inform: (self updateMessageFor: previousUpdateLevel)].<br>
> > - interactive ifTrue: [<br>
> > - self inform: ('Update completed.\\Version: {1}\Update: {3}{2}\\Url:<br>
> > {4}\Map: ''{5}''{6}' translated withCRs format: {<br>
> > - SystemVersion current version.<br>
> > - SystemVersion current highestUpdate.<br>
> > - previousUpdateLevel = SystemVersion current highestUpdate<br>
> > - ifTrue: ['']<br>
> > - ifFalse: [previousUpdateLevel asString, ' -> '].<br>
> > - self repository.<br>
> > - MCMcmUpdater updateMapName.<br>
> > - SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | String<br>
> > cr, String cr, d]})].<br>
> > Transcript cr;<br>
> > show: '========== Update completed: ' translated;<br>
> > show: previousUpdateLevel;<br>
> > show: ' -> ' ;<br>
> > show: SystemVersion current highestUpdate;<br>
> > show: ' =========='; cr ]<br>
> > ifFalse: [<br>
> > interactive<br>
> > ifTrue: [ self inform: 'Update completed.' ].<br>
> > Transcript cr; show: '========== Update completed. ==========' translated;<br>
> > cr ]<br>
> > !<br>
> ><br>
> > Item was added:<br>
> > + ----- Method: MCMcmUpdater>>updateMessageFor: (in category 'private')<br>
> > -----<br>
> > + updateMessageFor: previousUpdateLevel<br>
> > +<br>
> > + ^ ('Update completed.<br>
> ><br>
> > Version: {1}<br>
> > Update: {3}*{2}*<br>
> ><br>
> > Url: {4}<br>
> > Map: ''{5}''<br>
> > TravisCI status: {6}' translated format: {<br>
> > + SystemVersion current version.<br>
> > + SystemVersion current highestUpdate.<br>
> > + previousUpdateLevel = SystemVersion current highestUpdate<br>
> > + ifTrue: ['']<br>
> > + ifFalse: [previousUpdateLevel asString, ' -> '].<br>
> > + self repository.<br>
> > + MCMcmUpdater updateMapName.<br>
> > + SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d |<br>
> > + '<br>
> ><br>
> > ', (d copyReplaceAll: String cr with: '<br>
> > ')].<br>
> > + SystemVersion current ciStatusBadgeUrl.<br>
> > + SystemVersion current ciStatusPageUrl.<br>
> > + }) asTextFromHtml!<br>
> ><br>
> ><br>
> ><br>
> ><br>
<br>
<br>
<br>
> <br>
<br>
<br>
</div>
</span></span></div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div></blockquote>
</div></body>