<body><div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Christoph.<div><br></div><div>- What about ToolSet class >> #askForDefault?</div><div>- What is the benefit of extracting #requestDefault out of #askDefault? It is not obvious that one has a side effect and the other does not.</div><div>- <span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">UIManager default</span><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"> -> Project uiManager</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px"><br></span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Best,</span></div><div><span style="font-family: Arial, Helvetica, sans-serif;font-size: 13px">Marcel</span></div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 16.05.2020 20:53:34 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p><div style="font-family:Arial,Helvetica,sans-serif">Christoph Thiede uploaded a new version of System to project The Inbox:<br>http://source.squeak.org/inbox/System-ct.1158.mcz<br><br>==================== Summary ====================<br><br>Name: System-ct.1158<br>Author: ct<br>Time: 16 May 2020, 8:53:15.785708 pm<br>UUID: 03cddc8b-5593-504d-95c0-fc6851a15d88<br>Ancestors: System-nice.1157<br><br>Refactor AppRegistry class >> #askForDefault. Add multilingual support. If request is cancelled by the user, don't set a default and return a fallback value.<br><br>=============== Diff against System-nice.1157 ===============<br><br>Item was changed:<br> ----- Method: AppRegistry class>>askForDefault (in category 'defaults') -----<br> askForDefault<br> <br>+ self requestDefault ifNotNil: [:newDefault |<br>+ default := newDefault].<br>+ ^ default ifNil: [self registeredClasses first]!<br>- self registeredClasses isEmpty ifTrue:<br>- [self inform: 'There are no ', self appName, ' applications registered.'.<br>- ^ default := nil].<br>- self registeredClasses size = 1 ifTrue:<br>- [^ default := self registeredClasses anyOne].<br>- default := UIManager default <br>- chooseFrom: (self registeredClasses collect: [:ea | ea nameForViewer])<br>- values: self registeredClasses<br>- title: 'Which ', self appName, ' would you prefer?'.<br>- default ifNil: [default := self registeredClasses first].<br>- ^default.!<br><br>Item was added:<br>+ ----- Method: AppRegistry class>>requestDefault (in category 'defaults') -----<br>+ requestDefault<br>+ <br>+ self registeredClasses isEmpty ifTrue: [<br>+ self inform: ('There are no {1} applications registered' translated format: {self appName}).<br>+ ^ nil].<br>+ self registeredClasses size = 1 ifTrue: [<br>+ ^ self registeredClasses anyOne].<br>+ ^ UIManager default<br>+ chooseFrom: (self registeredClasses collect: [:ea | ea nameForViewer])<br>+ values: self registeredClasses<br>+ title: ('Which {1} would you prefer?' translated format: {self appName})!<br><br><br></div></blockquote>
</div></body>