<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hmm... it re-uses the help string but duplicates the "Filterable Lists" name. Not sure what is better. <div><br></div><div>If I recall correctly, I decoupled the names to have more freedom when designing the wizard's pages. And to integrate pragma preferences and normal ones. But it felt wrong to copy over all help texts.</div><div><br></div><div>I suppose that it would be more consistent to also add #help* methods for each preference used in the wizard. Just like there are #state* and #toggle* methods. In such methods, one could easily hide your lookup suggestion.</div><div><br></div><div>#stateFilterableLists</div><div>#toggleFilterableLists</div><div>#helpFilterableLists</div><div><br></div><div>Hmm... it is not that easy to query the pragma preference object from having PluggableListMorph class >> #filterableLists ... so close! :-)</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 02.06.2020 05:47:54 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p><div style="font-family:Arial,Helvetica,sans-serif">A new version of PreferenceBrowser was added to project The Inbox:<br>http://source.squeak.org/inbox/PreferenceBrowser-cbc.103.mcz<br><br>==================== Summary ====================<br><br>Name: PreferenceBrowser-cbc.103<br>Author: cbc<br>Time: 1 June 2020, 8:47:46.016726 pm<br>UUID: a2e0791b-c23c-9044-9d60-4ac9c13e4db0<br>Ancestors: PreferenceBrowser-mt.102<br><br>Fixes similar issue to mt.103, except uses the test found in PreferenceBrowser instead of creating a new text. This method may be superior, since the preference help will be localized in one location.<br><br>=============== Diff against PreferenceBrowser-mt.102 ===============<br><br>Item was changed:<br> ----- Method: PreferenceWizardMorph>>initializePage04InteractionMore (in category 'initialization - pages') -----<br> initializePage04InteractionMore<br> <br>+ | currentPage pane filterableHelp |<br>- | currentPage pane |<br> currentPage := pages add: self createPage.<br> pane := self createScrollPane.<br> <br> currentPage addMorphBack: (self createLabel: 'Choose more interaction settings' color: Color white).<br> currentPage addMorphBack: pane.<br> <br>+ "Next line added because using 'normal' lookup does not find the right text."<br>+ filterableHelp := Preferences allPreferences<br>+ detect:[:pref | pref name = 'Filterable Lists']<br>+ ifFound: [:pref | (pref helpString lines joinSeparatedBy: ' ') withBlanksTrimmed]<br>+ ifNone: [''].<br> pane scroller firstSubmorph addAllMorphsBack: {<br> self createCheckbox: 'Windows raise on click' translated for: #WindowsRaiseOnClick help: #(window raise).<br> self createCheckbox: 'Windows always active' for: #WindowsAlwaysActive help: #(window content active).<br> self createCheckbox: 'Window buttons always active' translated for: #WindowButtonsAlwaysActive help: #(window control active).<br> self createVerticalSpace.<br> self createCheckbox: 'Smart horizontal splitters' translated for: #SmartHorizontalSplitters help: #(horizontal splitter).<br> self createCheckbox: 'Smart vertical splitters' translated for: #SmartVerticalSplitters help: #(vertical splitter).<br> self createVerticalSpace.<br>+ self createCheckbox: 'Filterable lists and trees' translated for: #FilterableLists help: filterableHelp.<br>- self createCheckbox: 'Filterable lists and trees' translated for: #FilterableLists help: #(filterable).<br> self createCheckbox: 'Filters clear if unfocused' translated for: #ClearFilterAutomatically help: #(filter clear).<br> self createVerticalSpace.<br> self createCheckbox: 'Attach tools to mouse' translated for: #AttachToolsToMouse help: #(tools attach). <br> }.!<br><br><br></div></blockquote></div>