<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Hi Karl,</p>
<p><br>
</p>
<p>what's your motivation for this commit? I think transparent gifs should be displayed transparently in Squeak. You can always add an opaque background in your application if it does not want this :-)</p>
<p><br>
</p>
<p>Apart from that: Why don't you use #detect:ifFound: here? There is no need to scan all images after one that contains transparency has been found. I guess.</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">Best,</div>
<div class="_rp_T4" id="Item.MessagePartBody">Christoph</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von karl ramberg <karlramberg@gmail.com><br>
<b>Gesendet:</b> Samstag, 13. Juni 2020 13:33:01<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Cc:</b> packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: MorphicExtras-kfr.275.mcz</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div>I was afraid this would be a slow search, but its negligible.<br>
</div>
<div>Tested performance on a quite big gif* and it was only 1900 ms on my slow computer</div>
<div><br>
</div>
<div>*<a href="https://web.archive.org/web/20140209162456/http://www.majhost.com/gallery/NoBullet/TF2/t2.gif">https://web.archive.org/web/20140209162456/http://www.majhost.com/gallery/NoBullet/TF2/t2.gif</a></div>
<div><br>
</div>
<div>Best,</div>
<div>Karl<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat, Jun 13, 2020 at 1:12 PM <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Karl Ramberg uploaded a new version of MorphicExtras to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/MorphicExtras-kfr.275.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk/MorphicExtras-kfr.275.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: MorphicExtras-kfr.275<br>
Author: kfr<br>
Time: 10 June 2020, 6:41:33.727777 pm<br>
UUID: 26fa97c9-e242-8048-8c7c-53b2061c19f4<br>
Ancestors: MorphicExtras-mt.274<br>
<br>
Detect if animated image (eg. gif) has transparent color and use opaque background if so.<br>
<br>
=============== Diff against MorphicExtras-mt.274 ===============<br>
<br>
Item was changed:<br>
----- Method: AnimatedImageMorph>>fromReader: (in category 'private') -----<br>
fromReader: reader<br>
- <br>
images := reader forms.<br>
delays := reader delays.<br>
+ images do:[: each | (each colors includes: Color transparent) ifTrue:[self isOpaque: true]].<br>
- self isOpaque: true.<br>
self reset.!<br>
<br>
<br>
</blockquote>
</div>
</div>
</body>
</html>