<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>I have stopped to commit the patches to all affected packages, which was a terrible idea as I recognize now. In case we can agree on deprecating #doWithIndex:, I am attaching the corresponding changeset.</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
<div class="_rp_T4" id="Item.MessagePartBody">FWIW, here is the snippet I used to rename all senders of the deprecated selectors:</div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="js-discussion js-socket-channel ml-0 pl-0 ml-md-6 pl-md-3" data-channel="eyJjIjoibWFya2VkLWFzLXJlYWQ6Mzg3ODI5MjIiLCJ0IjoxNTk3ODU3NjY5fQ==--d76bceb433a9303e60d3ee26312d828ffc1ada88ca948f190ee1d4a62694ea23" data-channel-target="MDU6SXNzdWU2ODA4NTk4NDg=" style="box-sizing: border-box; color: rgb(36, 41, 46); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; margin-left: 40px !important; padding-left: 16px !important;">
<div class="js-issue-timeline-container" style="box-sizing: border-box;">
<div class="js-issue-timeline-container" style="box-sizing: border-box;">
<div class="js-issue-timeline-container" style="box-sizing: border-box;">
<div class="js-issue-timeline-container" style="box-sizing: border-box;">
<div class="js-issue-timeline-container" style="box-sizing: border-box;">
<div class="js-issue-timeline-container" style="box-sizing: border-box;">
<div class="js-issue-timeline-container" style="box-sizing: border-box;">
<div class="js-issue-timeline-container" style="box-sizing: border-box;">
<div class="js-issue-timeline-container" style="box-sizing: border-box;">
<div class="js-issue-timeline-container" style="box-sizing: border-box;">
<div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="MDEyOklzc3VlQ29tbWVudDY3NzY0ODM0Ng==" style="box-sizing: border-box;">
<div class="TimelineItem js-comment-container" data-gid="MDEyOklzc3VlQ29tbWVudDY3NzY0ODM0Ng==" data-url="/_render_node/MDEyOklzc3VlQ29tbWVudDY3NzY0ODM0Ng==/timeline/issue_comment" style="box-sizing: border-box; ">
<div class="timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-677648346" style="box-sizing: border-box; margin-top: 4px; margin-bottom: 0px !important; min-width: 0px; max-width: 100%; color: rgb(68, 77, 86); flex: 1 1 auto;">
<div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container editable-comment js-comment timeline-comment--caret reorderable-task-lists current-user" data-body-version="04bf271b3b294aebd32c156fa526f4bf" data-unfurl-hide-url="/content_reference_attachments/hide" style="box-sizing: border-box; ">
<div class="edit-comment-hide" style="box-sizing: border-box;"><task-lists sortable="" style="box-sizing: border-box;">
<table class="d-block" data-paste-markdown-skip="" style="border-spacing: 0px; border-collapse: collapse; display: block !important;">
<tbody class="d-block" style="box-sizing: border-box; display: block !important;">
<tr class="d-block" style="box-sizing: border-box; display: block !important;">
<td class="d-block comment-body markdown-body js-comment-body" style="box-sizing: border-box; padding: 15px; line-height: 1.5; overflow-wrap: break-word; width: 846px; overflow: visible; display: block !important;">
<div class="highlight highlight-source-smalltalk" style="box-sizing: border-box; margin-bottom: 16px; background-color: initial; overflow: visible !important;">
<pre style="box-sizing: border-box; font-family: SFMono-Regular, Consolas, "Liberation Mono", Menlo, monospace; font-size: 11.9px; margin-top: 0px; margin-bottom: 0px; overflow-wrap: normal; padding: 16px; overflow: auto; line-height: 1.45; background-color: rgb(246, 248, 250); border-radius: 6px; word-break: normal;">oldSelector <span class="pl-k" style="box-sizing: border-box; color: rgb(215, 58, 73);">:=</span> <span class="pl-c1" style="box-sizing: border-box; color: rgb(0, 92, 197);">#collectWithIndex:</span>.
newSelector <span class="pl-k" style="box-sizing: border-box; color: rgb(215, 58, 73);">:=</span> <span class="pl-c1" style="box-sizing: border-box; color: rgb(0, 92, 197);">#withIndexCollect:</span>.
methods <span class="pl-k" style="box-sizing: border-box; color: rgb(215, 58, 73);">:=</span> <span class="pl-k" style="box-sizing: border-box; color: rgb(215, 58, 73);">self</span> systemNavigation <span class="pl-c1" style="box-sizing: border-box; color: rgb(0, 92, 197);">allCallsOn:</span> oldSelector.
methods
<span class="pl-c1" style="box-sizing: border-box; color: rgb(0, 92, 197);">do:</span> [<span class="pl-en" style="box-sizing: border-box; color: rgb(111, 66, 193);">:method</span> |
method actualClass <span class="pl-c1" style="box-sizing: border-box; color: rgb(0, 92, 197);">compile:</span> (method sourceCode
<span class="pl-c1" style="box-sizing: border-box; color: rgb(0, 92, 197);">copyReplaceTokens:</span> oldSelector
<span class="pl-c1" style="box-sizing: border-box; color: rgb(0, 92, 197);">with:</span> newSelector) ]
<span class="pl-c1" style="box-sizing: border-box; color: rgb(0, 92, 197);">displayingProgress:</span> (<span class="pl-s" style="box-sizing: border-box; color: rgb(3, 47, 98);"><span class="pl-pds" style="box-sizing: border-box;">'</span>Replacing {1} with {2}<span class="pl-pds" style="box-sizing: border-box;">'</span></span> <span class="pl-c1" style="box-sizing: border-box; color: rgb(0, 92, 197);">format:</span> {oldSelector. newSelector})</pre>
</div>
</td>
</tr>
</tbody>
</table>
</task-lists></div>
<form class="js-comment-update" action="https://github.com/hpi-swa-lab/squeak/issue_comments/677648346" accept-charset="UTF-8" method="post" style="box-sizing: border-box;">
</form>
</div>
</div>
</div>
</div>
<div class="js-issue-timeline-container" style="box-sizing: border-box;">
<div class="js-timeline-marker js-socket-channel js-updatable-content" id="partial-timeline" data-channel="eyJjIjoiaXNzdWU6NjgwODU5ODQ4IiwidCI6MTU5NzkyODI0M30=--cba5c9e06da5797248315cfba81a1e447f999250bfeeb3e54d464a851704ca90" data-url="/_render_node/MDU6SXNzdWU2ODA4NTk4NDg=/issues/unread_timeline?variables%5BhasFocusedReviewComment%5D=false&variables%5BhasFocusedReviewThread%5D=false&variables%5BsyntaxHighlightingEnabled%5D=true&variables%5BtimelinePageSize%5D=30&variables%5BtimelineSince%5D=2020-08-20T12%3A57%3A21Z" data-last-modified="Thu, 20 Aug 2020 12:57:21 GMT" data-gid="MDU6SXNzdWU2ODA4NTk4NDg=" style="box-sizing: border-box;">
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<span id="issue-comment-box" style="box-sizing: border-box; color: rgb(36, 41, 46); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px;"></span><span style="color: rgb(36, 41, 46); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px;"></span>
<div class="discussion-timeline-actions" style="box-sizing: border-box; border-top: 2px solid rgb(225, 228, 232); color: rgb(36, 41, 46); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px;">
<div class="timeline-comment-wrapper timeline-new-comment js-comment-container ml-0 pl-0 ml-md-6 pl-md-3" style="box-sizing: border-box; margin-left: 40px !important; padding-left: 56px; ">
<div class=" d-none d-md-block" style="box-sizing: border-box;"></div>
</div>
</div>
<div class="_rp_T4" id="Item.MessagePartBody"><br>
</div>
Best,</div>
<div class="_rp_T4" id="Item.MessagePartBody">Christoph</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Donnerstag, 20. August 2020 14:55:14<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: 60Deprecated-ct.80.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Thank you for this explanation. Would have made a great commit message ;-)
<div><br>
</div>
<div>Also thanks for the highlighted example. Never thought of it that way. Makes sense.</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 20.08.2020 14:52:33 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div id="divtagdefaultwrapper" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif" dir="ltr">
<p>Sorry for the overhasty commit storm. From what the old method comment in SequenceableCollection >> #doWithIndex: stated, I believed that the formal deprecation of this selector was already decided but never realized:</p>
<p><br>
</p>
<p><span>"Use the new version with consistent naming"</span><br>
</p>
<p><span><br>
</span></p>
<p><span style="font-size: 12pt">In my image, #doWithIndex: has 89 senders opposed to #withIndexDo: which has 156 senders. #doWithIndex: could be a confusing name because usually, the latest phrase before the argument specifies the role or type of the argument,
but in this case, the argument is not an index, but a block.</span><br>
</p>
<p><span><br>
</span></p>
<p><span>Marcel said #withIndexDo: could be considered as confusing either because its name would not match the arguments in the expected block. However, I think it still matches the order because the element is already represented by the receiver of the MessageSend:</span></p>
<p><span><br>
</span></p>
<p><span><span><span style="color: rgb(0, 111, 201);">classes</span> with<span style="color: rgb(208, 92, 18);">Index</span>Do: [<span style="color: rgb(0, 111, 201);">:</span><span style="color: rgb(0, 111, 201);">class</span> <span style="color: rgb(208, 92, 18);">:index</span>
| ...]</span><br>
</span></p>
<p><span><span><br>
</span></span></p>
<p><span><span>Open to hear your opinions! However we decide, <span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;font-size: 16px">I think
it would improve the overall Smalltalk experience to have a single preferred name for protocols like this one to clean up the things.</span></span></span></p>
<p><span><span><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;font-size: 16px"><br>
</span></span></span></p>
<p>Best,</p>
<p>Christoph</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: rgb(0, 0, 0);font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols">
<div name="divtagdefaultwrapper" style="font-family: Calibri,Arial,Helvetica,sans-serif;font-size: ;margin: 0">
<div><span style="font-size: 10pt;color: #808080"></span></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Donnerstag, 20. August 2020 14:39:58<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: 60Deprecated-ct.80.mcz</span>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
... just why?
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 20.08.2020 14:33:41 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">A new version of 60Deprecated was added to project The Inbox:<br>
http://source.squeak.org/inbox/60Deprecated-ct.80.mcz<br>
<br>
==================== Summary ====================<br>
<br>
Name: 60Deprecated-ct.80<br>
Author: ct<br>
Time: 20 August 2020, 2:33:32.63864 pm<br>
UUID: 1295269c-62ee-5c45-9315-e66ff5eef57a<br>
Ancestors: 60Deprecated-mt.79<br>
<br>
Finnaly deprecate #doWithIndex: and #collectWithIndex:. Other packages will be patched right now.<br>
<br>
=============== Diff against 60Deprecated-mt.79 ===============<br>
<br>
Item was added:<br>
+ ----- Method: HashedCollection>>doWithIndex: (in category '*60Deprecated-enumerating') -----<br>
+ doWithIndex: elementAndIndexBlock<br>
+ <br>
+ self deprecated: 'Use #withIndexDo: instead'.<br>
+ ^ self withIndexDo: elementAndIndexBlock!<br>
<br>
Item was added:<br>
+ ----- Method: SequenceableCollection>>collectWithIndex: (in category '*60Deprecated-enumerating') -----<br>
+ collectWithIndex: elementAndIndexBlock<br>
+ <br>
+ self deprecated: 'Use #withIndexCollect: instead'.<br>
+ ^ self withIndexCollect: elementAndIndexBlock!<br>
<br>
Item was added:<br>
+ ----- Method: SequenceableCollection>>doWithIndex: (in category '*60Deprecated-enumerating') -----<br>
+ doWithIndex: elementAndIndexBlock<br>
+ <br>
+ self deprecated: 'Use #withIndexDo: instead'.<br>
+ ^ self withIndexDo: elementAndIndexBlock!<br>
<br>
Item was changed:<br>
----- Method: StandardFileMenu>>menuSelectionsArray: (in category 'menu building') -----<br>
menuSelectionsArray: aDirectory<br>
"Answer a menu selections object corresponding to aDirectory. The object is an array corresponding to each item, each element itself constituting a two-element array, the first element of which contains a selector to operate on and the second element of which
contains the parameters for that selector."<br>
<br>
|dirSize|<br>
dirSize := aDirectory pathParts size.<br>
^Array streamContents: [:s |<br>
canTypeFileName ifTrue:<br>
[s nextPut: (StandardFileMenuResult<br>
directory: aDirectory<br>
name: nil)].<br>
s nextPut: (StandardFileMenuResult<br>
directory: (FileDirectory root)<br>
name: '').<br>
+ aDirectory pathParts withIndexDo: <br>
- aDirectory pathParts doWithIndex: <br>
[:d :i | s nextPut: (StandardFileMenuResult<br>
directory: (self <br>
advance: dirSize - i<br>
containingDirectoriesFrom: aDirectory)<br>
name: '')].<br>
aDirectory directoryNames do: <br>
[:dn | s nextPut: (StandardFileMenuResult<br>
directory: (FileDirectory on: (aDirectory fullNameFor: dn))<br>
name: '')].<br>
aDirectory fileNames do: <br>
[:fn | pattern do: [:pat | (pat match: fn) ifTrue: [<br>
s nextPut: (StandardFileMenuResult<br>
directory: aDirectory<br>
name: fn)]]]]!<br>
<br>
Item was changed:<br>
----- Method: StandardFileMenu>>pathPartsString: (in category 'menu building') -----<br>
pathPartsString: aDirectory<br>
"Answer a string concatenating the path parts strings in aDirectory, each string followed by a cr."<br>
<br>
^String streamContents:<br>
[:s | <br>
s nextPutAll: '[]'; cr.<br>
+ aDirectory pathParts asArray withIndexDo: <br>
- aDirectory pathParts asArray doWithIndex: <br>
[:part :i |<br>
s next: i put: $ .<br>
s nextPutAll: part withBlanksTrimmed; cr]]!<br>
<br>
<br>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</body>
</html>