<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Sorry for the overhasty commit storm. From what the old method comment in SequenceableCollection >> #doWithIndex: stated, I believed that the formal deprecation of this selector was already decided but never realized:</p>
<p><br>
</p>
<p><span>"Use the new version with consistent naming"</span><br>
</p>
<p><span><br>
</span></p>
<p><span style="font-size: 12pt;">In my image, #doWithIndex: has 89 senders opposed to #withIndexDo: which has 156 senders. #doWithIndex: could be a confusing name because usually, the latest phrase before the argument specifies the role or type of the argument,
but in this case, the argument is not an index, but a block.</span><br>
</p>
<p><span><br>
</span></p>
<p><span>Marcel said #withIndexDo: could be considered as confusing either because its name would not match the arguments in the expected block. However, I think it still matches the order because the element is already represented by the receiver of the MessageSend:</span></p>
<p><span><br>
</span></p>
<p><span><span><span style="color: rgb(0, 111, 201);">classes</span> with<span style="color: rgb(208, 92, 18);">Index</span>Do: [<span style="color: rgb(0, 111, 201);">:</span><span style="color: rgb(0, 111, 201);">class</span> <span style="color: rgb(208, 92, 18);">:index</span>
| ...]</span><br>
</span></p>
<p><span><span><br>
</span></span></p>
<p><span><span>Open to hear your opinions! However we decide, <span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">I think
it would improve the overall Smalltalk experience to have a single preferred name for protocols like this one to clean up the things.</span></span></span></p>
<p><span><span><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"><br>
</span></span></span></p>
<p>Best,</p>
<p>Christoph</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel<br>
<b>Gesendet:</b> Donnerstag, 20. August 2020 14:39:58<br>
<b>An:</b> squeak-dev<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: 60Deprecated-ct.80.mcz</font>
<div> </div>
</div>
<div>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
... just why?
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 20.08.2020 14:33:41 schrieb commits@source.squeak.org <commits@source.squeak.org>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">A new version of 60Deprecated was added to project The Inbox:<br>
http://source.squeak.org/inbox/60Deprecated-ct.80.mcz<br>
<br>
==================== Summary ====================<br>
<br>
Name: 60Deprecated-ct.80<br>
Author: ct<br>
Time: 20 August 2020, 2:33:32.63864 pm<br>
UUID: 1295269c-62ee-5c45-9315-e66ff5eef57a<br>
Ancestors: 60Deprecated-mt.79<br>
<br>
Finnaly deprecate #doWithIndex: and #collectWithIndex:. Other packages will be patched right now.<br>
<br>
=============== Diff against 60Deprecated-mt.79 ===============<br>
<br>
Item was added:<br>
+ ----- Method: HashedCollection>>doWithIndex: (in category '*60Deprecated-enumerating') -----<br>
+ doWithIndex: elementAndIndexBlock<br>
+ <br>
+ self deprecated: 'Use #withIndexDo: instead'.<br>
+ ^ self withIndexDo: elementAndIndexBlock!<br>
<br>
Item was added:<br>
+ ----- Method: SequenceableCollection>>collectWithIndex: (in category '*60Deprecated-enumerating') -----<br>
+ collectWithIndex: elementAndIndexBlock<br>
+ <br>
+ self deprecated: 'Use #withIndexCollect: instead'.<br>
+ ^ self withIndexCollect: elementAndIndexBlock!<br>
<br>
Item was added:<br>
+ ----- Method: SequenceableCollection>>doWithIndex: (in category '*60Deprecated-enumerating') -----<br>
+ doWithIndex: elementAndIndexBlock<br>
+ <br>
+ self deprecated: 'Use #withIndexDo: instead'.<br>
+ ^ self withIndexDo: elementAndIndexBlock!<br>
<br>
Item was changed:<br>
----- Method: StandardFileMenu>>menuSelectionsArray: (in category 'menu building') -----<br>
menuSelectionsArray: aDirectory<br>
"Answer a menu selections object corresponding to aDirectory. The object is an array corresponding to each item, each element itself constituting a two-element array, the first element of which contains a selector to operate on and the second element of which
contains the parameters for that selector."<br>
<br>
|dirSize|<br>
dirSize := aDirectory pathParts size.<br>
^Array streamContents: [:s |<br>
canTypeFileName ifTrue:<br>
[s nextPut: (StandardFileMenuResult<br>
directory: aDirectory<br>
name: nil)].<br>
s nextPut: (StandardFileMenuResult<br>
directory: (FileDirectory root)<br>
name: '').<br>
+ aDirectory pathParts withIndexDo: <br>
- aDirectory pathParts doWithIndex: <br>
[:d :i | s nextPut: (StandardFileMenuResult<br>
directory: (self <br>
advance: dirSize - i<br>
containingDirectoriesFrom: aDirectory)<br>
name: '')].<br>
aDirectory directoryNames do: <br>
[:dn | s nextPut: (StandardFileMenuResult<br>
directory: (FileDirectory on: (aDirectory fullNameFor: dn))<br>
name: '')].<br>
aDirectory fileNames do: <br>
[:fn | pattern do: [:pat | (pat match: fn) ifTrue: [<br>
s nextPut: (StandardFileMenuResult<br>
directory: aDirectory<br>
name: fn)]]]]!<br>
<br>
Item was changed:<br>
----- Method: StandardFileMenu>>pathPartsString: (in category 'menu building') -----<br>
pathPartsString: aDirectory<br>
"Answer a string concatenating the path parts strings in aDirectory, each string followed by a cr."<br>
<br>
^String streamContents:<br>
[:s | <br>
s nextPutAll: '[]'; cr.<br>
+ aDirectory pathParts asArray withIndexDo: <br>
- aDirectory pathParts asArray doWithIndex: <br>
[:part :i |<br>
s next: i put: $ .<br>
s nextPutAll: part withBlanksTrimmed; cr]]!<br>
<br>
<br>
</div>
</blockquote>
</div>
</div>
</body>
</html>