<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Aug 20, 2020 at 7:07 AM Levente Uzonyi <<a href="mailto:leves@caesar.elte.hu">leves@caesar.elte.hu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Hi Christoph,<br>
<br>
+1 from me to deprecate it.<br>
Even if the final decision will be to not deprecate/remove those methods, <br>
using #withIndex*: instead of #*WithIndex: in Trunk won't hurt.<br>
So, feel free to push those changes, as those should be in the Trunk IMO.<br></blockquote><div><br></div><div>+1</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
<br>
Levente<br>
<br>
On Thu, 20 Aug 2020, Thiede, Christoph wrote:<br>
<br>
> <br>
> I have stopped to commit the patches to all affected packages, which was a terrible idea as I recognize now. In case we can agree on deprecating #doWithIndex:, I am attaching the corresponding changeset.<br>
> <br>
> <br>
> FWIW, here is the snippet I used to rename all senders of the deprecated selectors:<br>
> <br>
> oldSelector := #collectWithIndex:.<br>
> newSelector := #withIndexCollect:.<br>
> <br>
> methods := self systemNavigation allCallsOn: oldSelector.<br>
> methods<br>
> do: [:method |<br>
> method actualClass compile: (method sourceCode<br>
> copyReplaceTokens: oldSelector<br>
> with: newSelector) ]<br>
> displayingProgress: ('Replacing {1} with {2}' format: {oldSelector. newSelector})<br>
> [FORM]<br>
> <br>
> Best,<br>
> Christoph<br>
> <br>
> _________________________________________________________________________________________________________________________________________________________________________________________________________________________________<br>
> Von: Squeak-dev <<a href="mailto:squeak-dev-bounces@lists.squeakfoundation.org" target="_blank">squeak-dev-bounces@lists.squeakfoundation.org</a>> im Auftrag von Taeumel, Marcel<br>
> Gesendet: Donnerstag, 20. August 2020 14:55:14<br>
> An: squeak-dev<br>
> Betreff: Re: [squeak-dev] The Inbox: 60Deprecated-ct.80.mcz <br>
> Thank you for this explanation. Would have made a great commit message ;-)<br>
> Also thanks for the highlighted example. Never thought of it that way. Makes sense.<br>
> <br>
> Best,<br>
> Marcel<br>
><br>
> Am 20.08.2020 14:52:33 schrieb Thiede, Christoph <<a href="mailto:christoph.thiede@student.hpi.uni-potsdam.de" target="_blank">christoph.thiede@student.hpi.uni-potsdam.de</a>>:<br>
><br>
> Sorry for the overhasty commit storm. From what the old method comment in SequenceableCollection >> #doWithIndex: stated, I believed that the formal deprecation of this selector was already decided but never<br>
> realized:<br>
> <br>
><br>
> "Use the new version with consistent naming"<br>
> <br>
><br>
> In my image, #doWithIndex: has 89 senders opposed to #withIndexDo: which has 156 senders. #doWithIndex: could be a confusing name because usually, the latest phrase before the argument specifies the role or type<br>
> of the argument, but in this case, the argument is not an index, but a block.<br>
> <br>
><br>
> Marcel said #withIndexDo: could be considered as confusing either because its name would not match the arguments in the expected block. However, I think it still matches the order because the element is already<br>
> represented by the receiver of the MessageSend:<br>
> <br>
><br>
> classes withIndexDo: [:class :index | ...]<br>
> <br>
><br>
> Open to hear your opinions! However we decide, I think it would improve the overall Smalltalk experience to have a single preferred name for protocols like this one to clean up the things.<br>
> <br>
><br>
> Best,<br>
><br>
> Christoph<br>
> <br>
> _________________________________________________________________________________________________________________________________________________________________________________________________________________________________<br>
> Von: Squeak-dev <<a href="mailto:squeak-dev-bounces@lists.squeakfoundation.org" target="_blank">squeak-dev-bounces@lists.squeakfoundation.org</a>> im Auftrag von Taeumel, Marcel<br>
> Gesendet: Donnerstag, 20. August 2020 14:39:58<br>
> An: squeak-dev<br>
> Betreff: Re: [squeak-dev] The Inbox: 60Deprecated-ct.80.mcz <br>
> ... just why?<br>
> Best,<br>
> Marcel<br>
><br>
> Am 20.08.2020 14:33:41 schrieb <a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a> <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>>:<br>
><br>
> A new version of 60Deprecated was added to project The Inbox:<br>
> <a href="http://source.squeak.org/inbox/60Deprecated-ct.80.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/inbox/60Deprecated-ct.80.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: 60Deprecated-ct.80<br>
> Author: ct<br>
> Time: 20 August 2020, 2:33:32.63864 pm<br>
> UUID: 1295269c-62ee-5c45-9315-e66ff5eef57a<br>
> Ancestors: 60Deprecated-mt.79<br>
><br>
> Finnaly deprecate #doWithIndex: and #collectWithIndex:. Other packages will be patched right now.<br>
><br>
> =============== Diff against 60Deprecated-mt.79 ===============<br>
><br>
> Item was added:<br>
> + ----- Method: HashedCollection>>doWithIndex: (in category '*60Deprecated-enumerating') -----<br>
> + doWithIndex: elementAndIndexBlock<br>
> +<br>
> + self deprecated: 'Use #withIndexDo: instead'.<br>
> + ^ self withIndexDo: elementAndIndexBlock!<br>
><br>
> Item was added:<br>
> + ----- Method: SequenceableCollection>>collectWithIndex: (in category '*60Deprecated-enumerating') -----<br>
> + collectWithIndex: elementAndIndexBlock<br>
> +<br>
> + self deprecated: 'Use #withIndexCollect: instead'.<br>
> + ^ self withIndexCollect: elementAndIndexBlock!<br>
><br>
> Item was added:<br>
> + ----- Method: SequenceableCollection>>doWithIndex: (in category '*60Deprecated-enumerating') -----<br>
> + doWithIndex: elementAndIndexBlock<br>
> +<br>
> + self deprecated: 'Use #withIndexDo: instead'.<br>
> + ^ self withIndexDo: elementAndIndexBlock!<br>
><br>
> Item was changed:<br>
> ----- Method: StandardFileMenu>>menuSelectionsArray: (in category 'menu building') -----<br>
> menuSelectionsArray: aDirectory<br>
> "Answer a menu selections object corresponding to aDirectory. The object is an array corresponding to each item, each element itself constituting a two-element array, the first element of which contains a<br>
> selector to operate on and the second element of which contains the parameters for that selector."<br>
><br>
> |dirSize|<br>
> dirSize := aDirectory pathParts size.<br>
> ^Array streamContents: [:s |<br>
> canTypeFileName ifTrue:<br>
> [s nextPut: (StandardFileMenuResult<br>
> directory: aDirectory<br>
> name: nil)].<br>
> s nextPut: (StandardFileMenuResult<br>
> directory: (FileDirectory root)<br>
> name: '').<br>
> + aDirectory pathParts withIndexDo:<br>
> - aDirectory pathParts doWithIndex:<br>
> [:d :i | s nextPut: (StandardFileMenuResult<br>
> directory: (self<br>
> advance: dirSize - i<br>
> containingDirectoriesFrom: aDirectory)<br>
> name: '')].<br>
> aDirectory directoryNames do:<br>
> [:dn | s nextPut: (StandardFileMenuResult<br>
> directory: (FileDirectory on: (aDirectory fullNameFor: dn))<br>
> name: '')].<br>
> aDirectory fileNames do:<br>
> [:fn | pattern do: [:pat | (pat match: fn) ifTrue: [<br>
> s nextPut: (StandardFileMenuResult<br>
> directory: aDirectory<br>
> name: fn)]]]]!<br>
><br>
> Item was changed:<br>
> ----- Method: StandardFileMenu>>pathPartsString: (in category 'menu building') -----<br>
> pathPartsString: aDirectory<br>
> "Answer a string concatenating the path parts strings in aDirectory, each string followed by a cr."<br>
><br>
> ^String streamContents:<br>
> [:s |<br>
> s nextPutAll: '[]'; cr.<br>
> + aDirectory pathParts asArray withIndexDo:<br>
> - aDirectory pathParts asArray doWithIndex:<br>
> [:part :i |<br>
> s next: i put: $ .<br>
> s nextPutAll: part withBlanksTrimmed; cr]]!<br>
> <br>
> <br>
> <br>
><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div></div>