<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>No problem. Thank you for reviewing the other commits!</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="_rp_T4" id="Item.MessagePartBody">
<div class="_rp_U4 ms-font-weight-regular ms-font-color-neutralDark rpHighlightAllClass rpHighlightBodyClass" id="Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont">
<div><font size="3" color="black"><span style="font-size:12pt"><a href="http://www.hpi.de/" target="_blank" rel="noopener noreferrer" id="LPNoLP"><font size="2"><span id="LPlnk909538"><font color="#757B80"></font></span></font></a></span></font></div>
</font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Eliot Miranda <eliot.miranda@gmail.com><br>
<b>Gesendet:</b> Sonntag, 23. August 2020 04:14:16<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: Morphic-ct.1677.mcz</font>
<div> </div>
</div>
<div>
<div dir="ltr">Hi Christoph,<br>
<div><br>
</div>
<div> I haven't copied this to trunk. not because it looks bad (it doesn't), but because I'm not qualified. Better someone who knows menus better than I does the integration.</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat, Aug 22, 2020 at 10:35 AM <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
A new version of Morphic was added to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Morphic-ct.1677.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/inbox/Morphic-ct.1677.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-ct.1677<br>
Author: ct<br>
Time: 22 August 2020, 7:34:52.856555 pm<br>
UUID: 094ccc97-c3f6-364c-a10d-7418b3482703<br>
Ancestors: Morphic-mt.1674<br>
<br>
Nuke backward compatibility for Squeak 2.x menus. This should really not be relevant any longer I think. ;-)<br>
<br>
Also minor refactoring to MenuItemMorph >> #invokeWithEvent:.<br>
<br>
=============== Diff against Morphic-mt.1674 ===============<br>
<br>
Item was changed:<br>
----- Method: MenuItemMorph>>invokeWithEvent: (in category 'events') -----<br>
invokeWithEvent: evt<br>
"Perform the action associated with the given menu item."<br>
<br>
- | w |<br>
self isEnabled ifFalse: [^ self].<br>
+ <br>
+ (owner notNil and: [self isStayUpItem not]) ifTrue: [<br>
- target class == HandMorph ifTrue: [(self notObsolete) ifFalse: [^ self]].<br>
- owner ifNotNil:[self isStayUpItem ifFalse:[<br>
self flag: #workAround. "The tile system invokes menus straightforwardly so the menu might not be in the world."<br>
+ self world ifNotNil: [:world |<br>
- (w := self world) ifNotNil:[<br>
owner deleteIfPopUp: evt.<br>
"Repair damage before invoking the action for better feedback"<br>
+ world displayWorldSafely]].<br>
+ <br>
+ selector ifNil: [^ self].<br>
+ <br>
+ Cursor normal showWhile: [<br>
+ "show cursor in case item opens a new MVC window"<br>
+ selector numArgs isZero<br>
+ ifTrue: [target perform: selector]<br>
+ ifFalse: [target perform: selector withArguments: (<br>
+ selector numArgs = arguments size<br>
+ ifTrue: [arguments]<br>
+ ifFalse: [arguments copyWith: evt] )] ].!<br>
- w displayWorldSafely]]].<br>
- selector ifNil:[^self].<br>
- Cursor normal showWhile: [ | selArgCount | "show cursor in case item opens a new MVC window"<br>
- (selArgCount := selector numArgs) = 0<br>
- ifTrue:<br>
- [target perform: selector]<br>
- ifFalse:<br>
- [selArgCount = arguments size<br>
- ifTrue: [target perform: selector withArguments: arguments]<br>
- ifFalse: [target perform: selector withArguments: (arguments copyWith: evt)]]].!<br>
<br>
Item was removed:<br>
- ----- Method: MenuItemMorph>>notObsolete (in category 'private') -----<br>
- notObsolete<br>
- "Provide backward compatibility with messages being sent to the Hand. Remove this when no projects made prior to 2.9 are likely to be used. If this method is removed early, the worst that can happen is a notifier when invoking an item in an obsolete
menu."<br>
- <br>
- (HandMorph canUnderstand: (selector)) ifTrue: [^ true]. "a modern one"<br>
- <br>
- self inform: 'This world menu is obsolete.<br>
- Please dismiss the menu and open a new one.'.<br>
- ^ false<br>
- !<br>
<br>
<br>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div><span style="font-size:small;border-collapse:separate">
<div>_,,,^..^,,,_<br>
</div>
<div>best, Eliot</div>
</span></div>
</div>
</div>
</div>
</body>
</html>