<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000">
Hi Tony.<div><br></div><div>Maybe also take a look at:</div><div><br></div><div>Preferences class >> #setDemoFonts</div><div>Preferences class >> #setDefaultFonts:</div><div>UserInterfaceTheme >> #applyAfter:</div><div><br></div><div>It is possible to see the effects of your changes without closing all your widgets. Just use #apply or #applyAfter:.</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style: solid;border-width: 1px;margin-top: 20px;margin-left: 0px;padding-left: 10px;min-width: 500px">
<p style="color: #AAAAAA; margin-top: 10px;">Am 27.08.2020 19:57:17 schrieb Tony Garnock-Jones <tonyg@leastfixedpoint.com>:</p><div style="font-family:Arial,Helvetica,sans-serif">I committed those changes.<br><br>Next:<br><br> should TextStyle class >> pixelsPerInch be moved to<br> DisplayScreen >> pixelsPerInch ?<br><br>If so: TextPrinter >> defaultResolution is probably wrong, and should<br>probably just answer some constant like 300dpi...?<br><br>;;--<br><br>If, after loading the recent changes to pixelsPerInch: etc., you want to<br>see their effect, try this:<br><br>1.<br><br> | s |<br> s := TextStyle named: #BitstreamVeraSans.<br> UserInterfaceTheme current properties associationsDo: [:a |<br> (a value isKindOf: StrikeFont) ifTrue: [<br> s addNewFontSize: a value pointSize.<br> a value: (s fontOfPointSize: a value pointSize)]].<br><br>2. Close and reopen all your widgets (sigh), including running<br><br> TheWorldMainDockingBar initialize<br><br>3. Open a few windows<br><br>4. Alternate between the following:<br><br> TextStyle pixelsPerInch: 163<br> TextStyle pixelsPerInch: 96<br><br><br>Cheers,<br> Tony<br><br><br><br>On 8/26/20 4:20 PM, Tony Garnock-Jones wrote:<br>> Hi all,<br>> <br>> I'm looking at the image-side DPI-change code, namely TextStyle >><br>> pixelsPerInch:.<br>> <br>> The broadcast of the change is fine. But the handler in TTCFont is<br>> subtly wrong, I think.<br>> <br>> - I believe instance variables height, ascent, descent have to be nil'd<br>> as part of pixelsPerInchChanged. Is that right? Without nil'ing them,<br>> my TTCFonts don't resize properly.<br>> <br>> - This suggests flushCachedValues, which has NO SENDERS (!), should be<br>> folded into flushCache. Does that sound right?<br>> <br>> - Finally, if both the above hold, then pixelsPerInchChanged should be<br>> calling flushCache instead of recreateCache. Does that sound right?<br>> <br>> I'll be running for a few days with these changes in my image, to see if<br>> there are any obvious problems with them.<br>> <br>> But, before I push a commit out to Trunk, if I could get a thumbs-up<br>> from someone who knows a bit about the font subsystem, that'd be great!<br>> <br>> Regards,<br>> Tony<br>> <br><br></div></blockquote></div>