<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Hi Chris,</p>
<p><br>
</p>
<p>thanks for your feedback!</p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont"></font></div>
</div>
</font></div>
</div>
</div>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody"><br>
</div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">> <span style="font-size:12pt">For your code contributions in general, please allow methods to have </span><span style="font-size:12pt">only a single exit as much as possible, as in the attached.</span>
<div><br>
</div>
<div>I think this is very much a question of favor - personally, I prefer guard clauses over the functional style unless both code paths have the same relevance for the whole method. In my opinion, an empty message list is clearly a secondary edge case only.
:-)</div>
<div><br>
</div>
<div>> <span style="font-size:12pt">I like the multilingual change, but the purpose of using </span><span style="font-size:12pt">#headingAndAutoselectForLiteral:do: here wasn't obvious to me.</span>
<div><br>
</div>
<div>Yes, this is not really an intuitive message name ... What do you think about calling it #readLiteral:withHeadingAndStringDo: instead (plus making it public)?</div>
<div><br>
</div>
<div>Best,</div>
<div>Christoph</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Chris Muller <asqueaker@gmail.com><br>
<b>Gesendet:</b> Mittwoch, 2. September 2020 23:59:46<br>
<b>An:</b> squeak dev; Thiede, Christoph<br>
<b>Betreff:</b> Re: [squeak-dev] The Inbox: Tools-ct.986.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Hi Christoph,<br>
<br>
For your code contributions in general, please allow methods to have<br>
only a single exit as much as possible, as in the attached.<br>
<br>
I like the multilingual change, but the purpose of using<br>
#headingAndAutoselectForLiteral:do: here wasn't obvious to me.<br>
<br>
Best,<br>
Chris<br>
<br>
On Wed, Sep 2, 2020 at 9:56 AM <commits@source.squeak.org> wrote:<br>
><br>
> Christoph Thiede uploaded a new version of Tools to project The Inbox:<br>
> <a href="http://source.squeak.org/inbox/Tools-ct.986.mcz">http://source.squeak.org/inbox/Tools-ct.986.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: Tools-ct.986<br>
> Author: ct<br>
> Time: 2 September 2020, 4:55:38.538083 pm<br>
> UUID: b4cdf611-f04b-0b40-8f61-34429f414cca<br>
> Ancestors: Tools-ct.985<br>
><br>
> Fixes MNU when adding senders of a non-string literal to a message trace (at the end, FindText was set to a number or something similar). Improves multilingual support.<br>
><br>
> =============== Diff against Tools-ct.985 ===============<br>
><br>
> Item was changed:<br>
> ----- Method: MessageTrace>>addParentMethodsSending: (in category 'building') -----<br>
> addParentMethodsSending: selectorSymbol<br>
><br>
> + ^ self systemNavigation<br>
> + headingAndAutoselectForLiteral: selectorSymbol<br>
> + do: [:label :autoSelect |<br>
> + | methodsList |<br>
> + methodsList := self systemNavigation allCallsOn: selectorSymbol.<br>
> + methodsList ifEmpty: [<br>
> + ^ self inform: ('There are no {1}' translated format: {label})].<br>
> + self<br>
> - | methodsList |<br>
> - (methodsList := self systemNavigation allCallsOn: selectorSymbol) isEmpty<br>
> - ifTrue:<br>
> - [ ^(PopUpMenu labels: ' OK ')<br>
> - startUpWithCaption: 'There are no methods that send ', selectorSymbol ]<br>
> - ifFalse:<br>
> - [ self<br>
> addParentMessages: methodsList<br>
> + autoSelectString: autoSelect]<br>
> - autoSelectString: selectorSymbol ]<br>
> !<br>
><br>
><br>
</div>
</span></font>
</body>
</html>