<div dir="ltr"><div>Great :-D</div><div><br></div><div>Best,</div><div>Karl<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 15, 2020 at 2:24 AM David T. Lewis <<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I tracked this down a bit further, and the issue began after this change:<br>
<br>
Name: Collections-eem.885<br>
Author: eem<br>
Time: 15 April 2020, 4:37:54.800631 pm<br>
UUID: 45d219d3-6ed0-4401-a820-44eebe21d71a<br>
Ancestors: Collections-eem.883, Collections-dtl.884<br>
<br>
Switch elementsForwardIdentityTo: to not copy the hash, see <a href="http://forum.world.st/How-to-become-immediate-objects-td5114931.html" rel="noreferrer" target="_blank">http://forum.world.st/How-to-become-immediate-objects-td5114931.html</a>.<br>
Add elementsForwardIdentityAndHashTo: for the old behavior.<br>
<br>
I made some updates to image segments to accomodate this change, and<br>
the Etoys project loading works again. Updates are in the inbox in<br>
System-dtl.1171.<br>
<br>
@eliot- This needs review because I just made naive updates that seem<br>
to work, but I touched several methods and I'm not sure if it got it<br>
right.<br>
<br>
Dave<br>
<br>
<br>
On Mon, Sep 14, 2020 at 04:45:08PM -0400, David T. Lewis wrote:<br>
> Changing the subject line for follow up.<br>
> <br>
> We seem to have introduced a bug in project loading somewhere between<br>
> #19537 and #19582 in trunk. Karl has done the initial analysis, see below.<br>
> <br>
> Dave<br>
> <br>
> <br>
> On Mon, Sep 14, 2020 at 07:44:30PM +0200, karl ramberg wrote:<br>
> > So I narrowed it down a little more.<br>
> > In image #19537 I can both Inspect and Explore IdentityDictionary<br>
> > allVarMaps here:<br>
> > <br>
> > SmartRefStream>>convert2: partiallyCorrectInst allVarMaps: allVarMaps<br>
> > "Go through the normal instance conversion process and return a modern<br>
> > object."<br>
> > <br>
> > | className varMap |<br>
> > <br>
> > self flag: #bobconv.<br>
> > self halt.<br>
> > varMap := allVarMaps at: partiallyCorrectInst.<br>
> > className := varMap at: #ClassName. "original"<br>
> > ^self applyConversionMethodsTo: partiallyCorrectInst className: className<br>
> > varMap: varMap.<br>
> > <br>
> > <br>
> > In image 19582 it is broken. I can Inspect allVarMaps but Explore i give<br>
> > error 'Key not found:'<br>
> > <br>
> > So that is between 13 of mars and 16 of april 2020.<br>
> > <br>
> > <br>
> > <br>
> > <br>
> > Best,<br>
> > Karl<br>
> > <br>
> > <br>
> > <br>
> > <br>
> > On Mon, Sep 14, 2020 at 6:44 PM karl ramberg <<a href="mailto:karlramberg@gmail.com" target="_blank">karlramberg@gmail.com</a>> wrote:<br>
> > <br>
> > > There is some change that broke project loading.<br>
> > > I can load <a href="http://CarAndPen.014.pr" rel="noreferrer" target="_blank">CarAndPen.014.pr</a> in image update: #19422<br>
> > > In #19616 I get the "Key not found:" error from IdentityDictionary<br>
> > ><br>
> > > Best,<br>
> > > Karl<br>
> > ><br>
> > ><br>
> > ><br>
> > > On Mon, Sep 14, 2020 at 5:31 PM karl ramberg <<a href="mailto:karlramberg@gmail.com" target="_blank">karlramberg@gmail.com</a>><br>
> > > wrote:<br>
> > ><br>
> > >> While looking at this error I found another issue I think is a bug.<br>
> > >> I can't explore IndentityDictionary but I can inspect it.<br>
> > >><br>
> > >> [image: bild.png]<br>
> > >><br>
> > >> [image: bild.png]<br>
> > >> Best,<br>
> > >> Karl<br>
> > >><br>
> > >> On Mon, Sep 14, 2020 at 5:01 PM David T. Lewis <<a href="mailto:lewis@mail.msen.com" target="_blank">lewis@mail.msen.com</a>><br>
> > >> wrote:<br>
> > >><br>
> > >>> On Mon, Sep 14, 2020 at 01:45:39PM +0200, Tobias Pape wrote:<br>
> > >>> ><br>
> > >>> > > On 14.09.2020, at 13:36, Thiede, Christoph <<br>
> > >>> <a href="mailto:Christoph.Thiede@student.hpi.uni-potsdam.de" target="_blank">Christoph.Thiede@student.hpi.uni-potsdam.de</a>> wrote:<br>
> > >>> > ><br>
> > >>> > > I tested this in a fresh trunk image before deleting any binding.<br>
> > >>> ><br>
> > >>> > ah, well,<br>
> > >>> > But it doesn't find it's world, either way :D<br>
> > >>> > -t<br>
> > >>> ><br>
> > >>><br>
> > >>> I see very different errors when I try to load an old Etoys project. I do<br>
> > >>> not know why, and I don't have time to debug it. That is why I am hoping<br>
> > >>> that<br>
> > >>> someone (Karl perhaps) has a trunk-level image that *can* load old<br>
> > >>> projects.<br>
> > >>><br>
> > >>> If so, then my question is: What sort of errors or failure do you<br>
> > >>> actually<br>
> > >>> see when you load one of those projects after "Smalltalk removeKey:<br>
> > >>> #World"?<br>
> > >>><br>
> > >>> It may or may not be a problem that needs to be fixed. It is hard to know<br>
> > >>> without actually seeing the problem.<br>
> > >>><br>
> > >>> Dave<br>
> > >>><br>
> > >>><br>
> > >>><br>
> > >>><br>
> <br>
> <br>
> <br>
> <br>
> > <br>
> <br>
> <br>
<br>
</blockquote></div>