<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Before:</p>
<p><img size="58970" id="x_img981438" tabindex="0" style="max-width:99.9%" src="cid:e853f811-9aac-4450-8e0c-f4cb0a622e50"><br>
</p>
<p><br>
</p>
<p>After:</p>
<p><img size="27934" id="x_img320706" tabindex="0" style="max-width:99.9%" src="cid:fabc3777-170e-4222-abf9-35c599634f15"><br>
</p>
<p><br>
</p>
<p>However, I have follow-up questions:</p>
<p><br>
</p>
<p>A. Why do clients need to care about #<span>withNoLineLongerThan:/word-wrapping stuff? Shouldn't this be a responsibility of UserDialogBoxMorph instead?</span></p>
<p><span><br>
</span></p>
<p><span>B. Should we maybe turn off this warning for commits to the MCRepository inbox? In this particular case, our declared workflow says that you should ignore this message anyway, doesn't it?</span></p>
<p><span><br>
</span></p>
<p><span>Best,</span></p>
<p><span>Christoph</span></p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div name="x_divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div>
<div class="x__rp_T4" id="x_Item.MessagePartBody">
<div class="x__rp_U4 x_ms-font-weight-regular x_ms-font-color-neutralDark x_rpHighlightAllClass x_rpHighlightBodyClass" id="x_Item.MessageUniqueBody" style="font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont">
<div dir="ltr">
<div id="x_divtagdefaultwrapper"><font face="Calibri,Helvetica,sans-serif,EmojiFont,Apple Color Emoji,Segoe UI Emoji,NotoColorEmoji,Segoe UI Symbol,Android Emoji,EmojiSymbols">
<div id="x_Signature">
<div style="margin:0px"><font style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont"></font></div>
</div>
</font></div>
</div>
</div>
</div>
</div>
<div><font size="2" color="#808080"></font></div>
</div>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Donnerstag, 17. September 2020 19:04:57<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Inbox: Monticello-ct.729.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">A new version of Monticello was added to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Monticello-ct.729.mcz">http://source.squeak.org/inbox/Monticello-ct.729.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Monticello-ct.729<br>
Author: ct<br>
Time: 17 September 2020, 7:04:53.385813 pm<br>
UUID: 5eea47cc-405e-7841-9544-0f57a9b92fa0<br>
Ancestors: Monticello-cmm.726<br>
<br>
Proposal: Enhance truncation of "newer versions avaiable" warning (and make it multilingual-ready)<br>
<br>
=============== Diff against Monticello-cmm.726 ===============<br>
<br>
Item was changed:<br>
----- Method: MCWorkingCopyBrowser>>checkForNewerVersions (in category 'actions') -----<br>
checkForNewerVersions<br>
+ "Answer true if there are no newer versions preventing us from saving a version."<br>
+ <br>
| newer |<br>
newer := workingCopy possiblyNewerVersionsIn: self repository.<br>
+ <br>
+ newer ifEmpty: [^ true].<br>
+ <br>
+ ^ self confirm: ('CAUTION!! {1}:\{2}\Do you really want to save this version?' withCRs translated format: {<br>
+ newer size = 1<br>
+ ifTrue: ['This version in the repository may be newer' translated]<br>
+ ifFalse: ['These {1} versions in the repository may be newer' translated format: {newer size}].<br>
+ (newer size > 3<br>
+ ifFalse: [newer]<br>
+ ifTrue: [(newer first: 3) , {'...'} , {newer last}]) asCommaString withNoLineLongerThan: 150<br>
+ })!<br>
- ^ newer isEmpty or: [<br>
- self confirm: 'CAUTION!! These versions in the repository may be newer:',
<br>
- String cr, ((newer asCommaString withNoLineLongerThan: 150) truncateWithElipsisTo: 5 * 149), String cr,<br>
- 'Do you really want to save this version?'].!<br>
<br>
<br>
</div>
</span></font>
</body>
</html>